From patchwork Fri Jul 12 15:26:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerhard Sittig X-Patchwork-Id: 258766 X-Patchwork-Delegate: agust@denx.de Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 6257A2C076A for ; Sat, 13 Jul 2013 01:30:08 +1000 (EST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2FCB82C038C; Sat, 13 Jul 2013 01:27:23 +1000 (EST) Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3bsJ0P44qBz4KK45; Fri, 12 Jul 2013 17:27:17 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3bsJ0P3bQGzbbrf; Fri, 12 Jul 2013 17:27:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id BWvkeBNTPM2U; Fri, 12 Jul 2013 17:27:16 +0200 (CEST) X-Auth-Info: UOkc9rz/pEBPdKCYBq+U/1UMX8POmcehRvxhxSX65xA= Received: from localhost (kons-4d03eed5.pool.mediaWays.net [77.3.238.213]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 12 Jul 2013 17:27:16 +0200 (CEST) From: Gerhard Sittig To: linuxppc-dev@lists.ozlabs.org, devicetree-discuss@lists.ozlabs.org, Alexander Popov Subject: [PATCH RFC 2/8] dma: mpc512x: fix start condition in execute() Date: Fri, 12 Jul 2013 17:26:15 +0200 Message-Id: <1373642781-32631-3-git-send-email-gsi@denx.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1373642781-32631-1-git-send-email-gsi@denx.de> References: <1373642781-32631-1-git-send-email-gsi@denx.de> Cc: Lars-Peter Clausen , Arnd Bergmann , Vinod Koul , Gerhard Sittig , Dan Williams , Anatolij Gustschin X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" adjust the conditions how submitted DMA jobs get started: memory transfers need to get initiated by an explicit software request, all transfers which involve peripherals need to reference the external requester line Signed-off-by: Gerhard Sittig --- drivers/dma/mpc512x_dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c index f90b717..df10a48 100644 --- a/drivers/dma/mpc512x_dma.c +++ b/drivers/dma/mpc512x_dma.c @@ -272,10 +272,12 @@ static void mpc_dma_execute(struct mpc_dma_chan *mchan) mdma->tcd[cid].e_sg = 1; switch (cid) { - case 26: + default: + /* peripherals involved, use external request */ out_8(&mdma->regs->dmaserq, cid); break; case 32: + /* memory transfer, software provided start signal */ out_8(&mdma->regs->dmassrt, cid); break; }