From patchwork Fri Jul 12 11:15:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 258739 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id B14722C0345 for ; Fri, 12 Jul 2013 21:15:51 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UxbKH-0003cC-8o; Fri, 12 Jul 2013 11:15:49 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1UxbKB-0003c0-OK for fwts-devel@lists.ubuntu.com; Fri, 12 Jul 2013 11:15:43 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginmedia.com ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UxbKB-0005z8-Jv for fwts-devel@lists.ubuntu.com; Fri, 12 Jul 2013 11:15:43 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH][FWTS-TEST] syntaxcheck-0001: bug LP: #1200568 fixes the ASL errors being skipped over Date: Fri, 12 Jul 2013 12:15:43 +0100 Message-Id: <1373627743-14434-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.1.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King This fixes the test now that bug LP: #1200568 is fixed. Signed-off-by: Colin Ian King Acked-by: Ivan Hu Acked-by: Keng-Yu Lin --- syntaxcheck-0001/syntaxcheck-0001.log | 70 +++++++++++++++++++++++++++++++++-- 1 file changed, 67 insertions(+), 3 deletions(-) diff --git a/syntaxcheck-0001/syntaxcheck-0001.log b/syntaxcheck-0001/syntaxcheck-0001.log index 679967a..80a7b80 100644 --- a/syntaxcheck-0001/syntaxcheck-0001.log +++ b/syntaxcheck-0001/syntaxcheck-0001.log @@ -5,8 +5,72 @@ syntaxcheck Test 1 of 2: Disassemble and reassemble DSDT syntaxcheck syntaxcheck Checking ACPI table DSDT (#0) syntaxcheck -syntaxcheck PASSED: Test 1, DSDT (0) reassembly, Found 0 errors, 0 -syntaxcheck warnings. +syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_UPPER_CASE: Test 1, Assembler +syntaxcheck error in line 709 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 00706| { +syntaxcheck 00707| Device (AMW0) +syntaxcheck 00708| { +syntaxcheck 00709| Name (_HID, "pnp0c14") // _HID: Hardware ID +syntaxcheck | ^ +syntaxcheck | Error 6136: Non-hex letters must be upper case (pnp0c14) +syntaxcheck 00710| Name (_UID, Zero) // _UID: Unique ID +syntaxcheck 00711| Name (_WDG, Buffer (0x3C) +syntaxcheck 00712| { +syntaxcheck ========================================================== +syntaxcheck +syntaxcheck ADVICE: (for Error #6136, ASL_MSG_UPPER_CASE): Characters +syntaxcheck in literal string that are not hexadecimal letters must be +syntaxcheck upper case. +syntaxcheck +syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1, +syntaxcheck Assembler error in line 1069 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 01066| 0x00000000, // Range Minimum +syntaxcheck 01067| 0xDFFFFFFF, // Range Maximum +syntaxcheck 01068| 0x00000000, // Translation Offset +syntaxcheck 01069| 0x00000000, // Length +syntaxcheck | ^ +syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags +syntaxcheck 01070| ,, _Y0D, AddressRangeMemory, TypeStatic) +syntaxcheck 01071| DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite, +syntaxcheck 01072| 0x00000000, // Granularity +syntaxcheck ========================================================== +syntaxcheck +syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS): +syntaxcheck This occurs if the length is zero and just one of the +syntaxcheck resource MIF/MAF flags are set, or the length is non-zero +syntaxcheck and resource MIF/MAF flags are both set. These are illegal +syntaxcheck combinations and need to be fixed. See section 6.4.3.5 +syntaxcheck Address Space Resource Descriptors of the ACPI +syntaxcheck specification for more details. +syntaxcheck +syntaxcheck FAILED [HIGH] AMLAsmASL_MSG_INVALID_ADDR_FLAGS: Test 1, +syntaxcheck Assembler error in line 1083 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 01080| 0xFED40000, // Range Minimum +syntaxcheck 01081| 0xFED44FFF, // Range Maximum +syntaxcheck 01082| 0x00000000, // Translation Offset +syntaxcheck 01083| 0x00000000, // Length +syntaxcheck | ^ +syntaxcheck | Error 6043: Invalid combination of Length and Min/Max fixed flags +syntaxcheck 01084| ,, , AddressRangeMemory, TypeStatic) +syntaxcheck 01085| }) +syntaxcheck 01086| Method (_CRS, 0, Serialized) // _CRS: Current Resource Settings +syntaxcheck ========================================================== +syntaxcheck +syntaxcheck ADVICE: (for Error #6043, ASL_MSG_INVALID_ADDR_FLAGS): +syntaxcheck This occurs if the length is zero and just one of the +syntaxcheck resource MIF/MAF flags are set, or the length is non-zero +syntaxcheck and resource MIF/MAF flags are both set. These are illegal +syntaxcheck combinations and need to be fixed. See section 6.4.3.5 +syntaxcheck Address Space Resource Descriptors of the ACPI +syntaxcheck specification for more details. +syntaxcheck +syntaxcheck Table DSDT (0) reassembly: Found 3 errors, 0 warnings. syntaxcheck syntaxcheck syntaxcheck Test 2 of 2: Disassemble and reassemble SSDT @@ -42,6 +106,6 @@ syntaxcheck warnings. syntaxcheck syntaxcheck syntaxcheck ========================================================== -syntaxcheck 6 passed, 0 failed, 0 warnings, 0 aborted, 0 skipped, 0 +syntaxcheck 5 passed, 3 failed, 0 warnings, 0 aborted, 0 skipped, 0 syntaxcheck info only. syntaxcheck ==========================================================