| Message ID | 1373556206-29238-1-git-send-email-marex@denx.de |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On 11/07/2013 17:23, Marek Vasut wrote: > Remove incorrectly called and duplicate flush_dcache_range() call > from fec_mxc driver. The call is not needed, since the caches are > already flushed in fec_tbd_init(), moreover the second argument should > be the ending address, not size. > > Signed-off-by: Marek Vasut <marex@denx.de> > Reported-by: Albert Aribaud <albert.u.boot@aribaud.net> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Tom Rini <trini@ti.com> > --- > drivers/net/fec_mxc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index da95e28..97bf8fe 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd) > } > memset(fec->tbd_base, 0, size); > fec_tbd_init(fec); > - flush_dcache_range((unsigned)fec->tbd_base, size); > } > > /* > Applied to u-boot-imx (fix), thanks ! Best regards, Stefano Babic
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index da95e28..97bf8fe 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd) } memset(fec->tbd_base, 0, size); fec_tbd_init(fec); - flush_dcache_range((unsigned)fec->tbd_base, size); } /*
Remove incorrectly called and duplicate flush_dcache_range() call from fec_mxc driver. The call is not needed, since the caches are already flushed in fec_tbd_init(), moreover the second argument should be the ending address, not size. Signed-off-by: Marek Vasut <marex@denx.de> Reported-by: Albert Aribaud <albert.u.boot@aribaud.net> Cc: Stefano Babic <sbabic@denx.de> Cc: Tom Rini <trini@ti.com> --- drivers/net/fec_mxc.c | 1 - 1 file changed, 1 deletion(-)