Patchwork [v2] ARM: imx: Kconfig: Select ARM1136 related errata

login
register
mail settings
Submitter Fabio Estevam
Date July 11, 2013, 2:26 p.m.
Message ID <1373552782-14196-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/258497/
State New
Headers show

Comments

Fabio Estevam - July 11, 2013, 2:26 p.m.
CONFIG_ARM_ERRATA_411920 and CONFIG_ARM_ERRATA_364296 should be selected for
ARM1136 SoCs.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Select the errata via Kconfig

 arch/arm/mach-imx/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
Shawn Guo - July 12, 2013, 7:49 a.m.
On Thu, Jul 11, 2013 at 11:26:22AM -0300, Fabio Estevam wrote:
> CONFIG_ARM_ERRATA_411920 and CONFIG_ARM_ERRATA_364296 should be selected for
> ARM1136 SoCs.
> 
Per help text of the erratums, 364296 affects ARM1136 r0p2, and 411920
affects ARM1136 before r1p4.  Do you know the revisions used on imx31
and imx35?  Or do you see that enabling the workaround help fix some
real issues?

Shawn

> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Select the errata via Kconfig
> 
>  arch/arm/mach-imx/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index f7a5ad1..1d15d5c 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -123,6 +123,8 @@ config SOC_IMX27
>  
>  config SOC_IMX31
>  	bool
> +	select ARM_ERRATA_364296
> +	select ARM_ERRATA_411920
>  	select COMMON_CLK
>  	select CPU_V6
>  	select IMX_HAVE_PLATFORM_MXC_RNGA
> @@ -132,6 +134,8 @@ config SOC_IMX31
>  config SOC_IMX35
>  	bool
>  	select ARCH_MXC_IOMUX_V3
> +	select ARM_ERRATA_364296
> +	select ARM_ERRATA_411920
>  	select COMMON_CLK
>  	select CPU_V6K
>  	select HAVE_EPIT
> -- 
> 1.8.1.2
> 
>
Fabio Estevam - July 12, 2013, 11:03 a.m.
On Fri, Jul 12, 2013 at 4:49 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Thu, Jul 11, 2013 at 11:26:22AM -0300, Fabio Estevam wrote:
>> CONFIG_ARM_ERRATA_411920 and CONFIG_ARM_ERRATA_364296 should be selected for
>> ARM1136 SoCs.
>>
> Per help text of the erratums, 364296 affects ARM1136 r0p2, and 411920
> affects ARM1136 before r1p4.  Do you know the revisions used on imx31
> and imx35?  Or do you see that enabling the workaround help fix some
> real issues?

I haven't checked the exact revisions of mx31/mx35.

The reason I selected these two errata was due to comparison with the
FSL BSP defconfig for mx31:
http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/arch/arm/configs/imx31_3stack_defconfig?h=imx_2.6.31

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index f7a5ad1..1d15d5c 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -123,6 +123,8 @@  config SOC_IMX27
 
 config SOC_IMX31
 	bool
+	select ARM_ERRATA_364296
+	select ARM_ERRATA_411920
 	select COMMON_CLK
 	select CPU_V6
 	select IMX_HAVE_PLATFORM_MXC_RNGA
@@ -132,6 +134,8 @@  config SOC_IMX31
 config SOC_IMX35
 	bool
 	select ARCH_MXC_IOMUX_V3
+	select ARM_ERRATA_364296
+	select ARM_ERRATA_411920
 	select COMMON_CLK
 	select CPU_V6K
 	select HAVE_EPIT