Patchwork [01/98] zram: avoid invalid memory access in zram_exit()

mail settings
Submitter Luis Henriques
Date July 11, 2013, 2:23 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/258469/
State New
Headers show


Luis Henriques - July 11, 2013, 2:23 p.m. -stable review patch.  If anyone has any objections, please let me know.


From: Jiang Liu <>

commit 6030ea9b35971a4200062f010341ab832e878ac9 upstream.

Memory for zram->disk object may have already been freed after returning
from destroy_device(zram), then it's unsafe for zram_reset_device(zram)
to access zram->disk again.

We can't solve this bug by flipping the order of destroy_device(zram)
and zram_reset_device(zram), that will cause deadlock issues to the
zram sysfs handler.

So fix it by holding an extra reference to zram->disk before calling

Signed-off-by: Jiang Liu <>
Signed-off-by: Greg Kroah-Hartman <>
[ luis: backported to 3.5: adjusted context ]
Signed-off-by: Luis Henriques <>
 drivers/staging/zram/zram_drv.c | 2 ++
 1 file changed, 2 insertions(+)


diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index fb7f9fb..900f0ed 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -841,9 +841,11 @@  static void __exit zram_exit(void)
 	for (i = 0; i < num_devices; i++) {
 		zram = &zram_devices[i];
+		get_disk(zram->disk);
 		if (zram->init_done)
+		put_disk(zram->disk);
 	unregister_blkdev(zram_major, "zram");