From patchwork Thu Jul 11 13:51:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonas Jensen X-Patchwork-Id: 258459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-lb0-x23c.google.com (mail-lb0-x23c.google.com [IPv6:2a00:1450:4010:c04::23c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id ADE7B2C0302 for ; Thu, 11 Jul 2013 23:54:33 +1000 (EST) Received: by mail-lb0-f188.google.com with SMTP id x10sf1343352lbi.5 for ; Thu, 11 Jul 2013 06:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:x-beenthere:from:to:cc:subject:date:message-id :x-mailer:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=veYvFbqKjlkMy/bnGFh+yeIjz8GxvsW+6Ddw0iAHZnU=; b=G15t9l5XXVG3dsI/qK8x2LzOgyvedzpWm+OQP7phTDtQ0b4aEp1qFiBhnVYYiC34ck phthW+7hzUQkHYPRPJUFGiTb8ReQveQ4gJcIMgwcsGJ4JAZPweoT8m/x+mIQ7DVE8FcG u4LCmxgwcjlLbTZ+Fh9n6nszThc/TrzsgqnUwV63h+p/66nRZmjxyGhJgXSzmVZHhkiB NBQCeHKN38mc5ppe7QG4U7GIWRWBStTuYFECHm5pBmiBiv0hi0DZQjw7SE5cBBftz5np cAaYvYVZp1gcP3GT3e9YNwcBQ0MCGLhZ4t86FAsP/Y5IiFCDOvubdOzI2I6lLR61Dwla /BOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-beenthere:from:to:cc:subject:date:message-id :x-mailer:in-reply-to:references:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=veYvFbqKjlkMy/bnGFh+yeIjz8GxvsW+6Ddw0iAHZnU=; b=emxsTbCA8H83lgR8Aqop+jgu4jFVgv/6FV/Xf9g0KJJGAEaEtTM55yfBAe9E28e5he wmthairHsIq/sfY3NDnp605kLzxYSxWbwKBymoA2nNDZ3Kb71h10RwuPPkKJ9XX+3hvQ jtXJP7aeFnW170mUJ980xa3gos2NKunyFhiWCmZuYWBOiEinrwMsK1kQI5LYRb6Wn6+K Zx9403QbINi95LWZNHjb1ibO65XnuVSXeYiTdfcT8VKOunbmXGhlMuq47RQiKVWHBnyR V5Pn3SHYMCf8WivyyZ99a8hhCyf/OZRj+T5NLu1nyV1IcMW56jzJFFQWfv93sQ6GGwTy haUg== X-Received: by 10.180.11.231 with SMTP id t7mr2070119wib.5.1373550869195; Thu, 11 Jul 2013 06:54:29 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.91.116 with SMTP id cd20ls1833112wib.9.gmail; Thu, 11 Jul 2013 06:54:28 -0700 (PDT) X-Received: by 10.204.106.67 with SMTP id w3mr2325001bko.2.1373550868540; Thu, 11 Jul 2013 06:54:28 -0700 (PDT) Received: from mail-la0-x236.google.com (mail-la0-x236.google.com [2a00:1450:4010:c03::236]) by gmr-mx.google.com with ESMTPS id nl4si1845304bkb.2.2013.07.11.06.54.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 11 Jul 2013 06:54:28 -0700 (PDT) Received-SPF: pass (google.com: domain of jonas.jensen@gmail.com designates 2a00:1450:4010:c03::236 as permitted sender) client-ip=2a00:1450:4010:c03::236; Received: by mail-la0-f54.google.com with SMTP id ec20so6903162lab.27 for ; Thu, 11 Jul 2013 06:54:28 -0700 (PDT) X-Received: by 10.152.44.225 with SMTP id h1mr16898054lam.90.1373550868173; Thu, 11 Jul 2013 06:54:28 -0700 (PDT) Received: from Ildjarn.ildjarn.botech.se (static-213-115-41-10.sme.bredbandsbolaget.se. [213.115.41.10]) by mx.google.com with ESMTPSA id 8sm12432727lbq.4.2013.07.11.06.54.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 11 Jul 2013 06:54:27 -0700 (PDT) From: Jonas Jensen To: rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, broonie@kernel.org, Jonas Jensen Subject: [rtc-linux] [PATCH v2] rtc: Add MOXA ART RTC driver Date: Thu, 11 Jul 2013 15:51:51 +0200 Message-Id: <1373550711-18828-1-git-send-email-jonas.jensen@gmail.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1373464848-28146-1-git-send-email-jonas.jensen@gmail.com> References: <1373464848-28146-1-git-send-email-jonas.jensen@gmail.com> X-Original-Sender: jonas.jensen@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jonas.jensen@gmail.com designates 2a00:1450:4010:c03::236 as permitted sender) smtp.mail=jonas.jensen@gmail.com; dkim=pass header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Add RTC driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Thanks for the review Mark, what you said should be fixed in v2. Applies to next-20130711 Changes since v1: 1. remove defines GPIO_EM1240_HIGH and GPIO_EM1240_LOW 2. rename struct "rtc_plat_data" "moxart_rtc" 3. move rtc_lock to struct moxart_rtc 4. add delay after setting GPIO high 5. remove moxart_rtc_ioctl 6. use devm_gpio_request instead of gpio_request 7. remove explicit devm_kfree 8. change Makefile list order drivers/rtc/Kconfig | 9 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-moxart.c | 316 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 326 insertions(+) create mode 100644 drivers/rtc/rtc-moxart.c diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 9e3498b..9654aa3 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1249,6 +1249,15 @@ config RTC_DRV_SIRFSOC Say "yes" here to support the real time clock on SiRF SOC chips. This driver can also be built as a module called rtc-sirfsoc. +config RTC_DRV_MOXART + tristate "MOXA ART RTC" + help + If you say yes here you get support for the MOXA ART + RTC module. + + This driver can also be built as a module. If so, the module + will be called rtc-moxart + comment "HID Sensor RTC drivers" config RTC_DRV_HID_SENSOR_TIME diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile index d3b4488..2dff3d2 100644 --- a/drivers/rtc/Makefile +++ b/drivers/rtc/Makefile @@ -130,3 +130,4 @@ obj-$(CONFIG_RTC_DRV_WM831X) += rtc-wm831x.o obj-$(CONFIG_RTC_DRV_WM8350) += rtc-wm8350.o obj-$(CONFIG_RTC_DRV_X1205) += rtc-x1205.o obj-$(CONFIG_RTC_DRV_SIRFSOC) += rtc-sirfsoc.o +obj-$(CONFIG_RTC_DRV_MOXART) += rtc-moxart.o diff --git a/drivers/rtc/rtc-moxart.c b/drivers/rtc/rtc-moxart.c new file mode 100644 index 0000000..dd8615e --- /dev/null +++ b/drivers/rtc/rtc-moxart.c @@ -0,0 +1,316 @@ +/* + * MOXA ART RTC driver. + * + * Copyright (C) 2013 Jonas Jensen + * + * Jonas Jensen + * + * Based on code from + * Moxa Technology Co., Ltd. + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This program is licensed "as is" without any + * warranty of any kind, whether express or implied. + */ + +#include +#include +#include +#include +#include +#include +#include + +#define GPIO_EM1240_OUTPUT 1 +#define GPIO_EM1240_INPUT 0 + +#define GPIO_RTC_SCLK (5) +#define GPIO_RTC_DATA (6) +#define GPIO_RTC_RESET (7) + +#define GPIO_RTC_RESERVED 0x0C +#define GPIO_RTC_DATA_SET 0x10 +#define GPIO_RTC_DATA_CLEAR 0x14 +#define GPIO_RTC_PIN_PULL_ENABLE 0x18 +#define GPIO_RTC_PIN_PULL_TYPE 0x1C +#define GPIO_RTC_INT_ENABLE 0x20 +#define GPIO_RTC_INT_RAW_STATE 0x24 +#define GPIO_RTC_INT_MASKED_STATE 0x28 +#define GPIO_RTC_INT_MASK 0x2C +#define GPIO_RTC_INT_CLEAR 0x30 +#define GPIO_RTC_INT_TRIGGER 0x34 +#define GPIO_RTC_INT_BOTH 0x38 +#define GPIO_RTC_INT_RISE_NEG 0x3C +#define GPIO_RTC_BOUNCE_ENABLE 0x40 +#define GPIO_RTC_BOUNCE_PRE_SCALE 0x44 + +#define GPIO_RTC_PROTECT_W 0x8E +#define GPIO_RTC_PROTECT_R 0x8F +#define GPIO_RTC_YEAR_W 0x8C +#define GPIO_RTC_YEAR_R 0x8D +#define GPIO_RTC_DAY_W 0x8A +#define GPIO_RTC_DAY_R 0x8B +#define GPIO_RTC_MONTH_W 0x88 +#define GPIO_RTC_MONTH_R 0x89 +#define GPIO_RTC_DATE_W 0x86 +#define GPIO_RTC_DATE_R 0x87 +#define GPIO_RTC_HOURS_W 0x84 +#define GPIO_RTC_HOURS_R 0x85 +#define GPIO_RTC_MINUTES_W 0x82 +#define GPIO_RTC_MINUTES_R 0x83 +#define GPIO_RTC_SECONDS_W 0x80 +#define GPIO_RTC_SECONDS_R 0x81 +#define GPIO_RTC_DELAY_TIME 8 /* 8 usecond */ +#define GPIO_RTC_IS_OPEN 0x01 /* /dev/rtc in use */ +#define GPIO_PIO(x) (1 << x) + +struct moxart_rtc { + struct rtc_device *rtc; + spinlock_t rtc_lock; +}; + +static int day_of_year[12] = { 0, 31, 59, 90, 120, 151, 181, + 212, 243, 273, 304, 334 }; + +void moxart_rtc_write_byte(u8 data) +{ + int i; + + for (i = 0; i < 8; i++, data >>= 1) { + gpio_set_value(GPIO_RTC_SCLK, 0); + gpio_set_value(GPIO_RTC_DATA, ((data & 1) == 1)); + udelay(GPIO_RTC_DELAY_TIME); + gpio_set_value(GPIO_RTC_SCLK, 1); + udelay(GPIO_RTC_DELAY_TIME); + } +} + +u8 moxart_rtc_read_byte(void) +{ + int i; + u8 data = 0; + + for (i = 0; i < 8; i++) { + gpio_set_value(GPIO_RTC_SCLK, 0); + udelay(GPIO_RTC_DELAY_TIME); + gpio_set_value(GPIO_RTC_SCLK, 1); + udelay(GPIO_RTC_DELAY_TIME); + if (gpio_get_value(GPIO_RTC_DATA)) + data |= (1 << i); + udelay(GPIO_RTC_DELAY_TIME); + } + return data; +} + +static u8 moxart_rtc_read_register(u8 cmd) +{ + u8 data; + unsigned long flags; + + local_irq_save(flags); + + gpio_direction_output(GPIO_RTC_DATA, 0); + gpio_set_value(GPIO_RTC_RESET, 1); + udelay(GPIO_RTC_DELAY_TIME); + moxart_rtc_write_byte(cmd); + gpio_direction_input(GPIO_RTC_DATA); + udelay(GPIO_RTC_DELAY_TIME); + data = moxart_rtc_read_byte(); + gpio_set_value(GPIO_RTC_SCLK, 0); + gpio_set_value(GPIO_RTC_RESET, 0); + udelay(GPIO_RTC_DELAY_TIME); + + local_irq_restore(flags); + + return data; +} + +static void moxart_rtc_write_register(u8 cmd, u8 data) +{ + unsigned long flags; + + local_irq_save(flags); + + gpio_direction_output(GPIO_RTC_DATA, 0); + gpio_set_value(GPIO_RTC_RESET, 1); + udelay(GPIO_RTC_DELAY_TIME); + moxart_rtc_write_byte(cmd); + moxart_rtc_write_byte(data); + gpio_set_value(GPIO_RTC_SCLK, 0); + gpio_set_value(GPIO_RTC_RESET, 0); + udelay(GPIO_RTC_DELAY_TIME); + + local_irq_restore(flags); +} + +static int moxart_rtc_set_time(struct device *dev, struct rtc_time *tm) +{ + struct moxart_rtc *moxart_rtc = dev_get_drvdata(dev); + + spin_lock_irq(&moxart_rtc->rtc_lock); + + moxart_rtc_write_register(GPIO_RTC_PROTECT_W, 0); + moxart_rtc_write_register(GPIO_RTC_YEAR_W, + (((tm->tm_year - 100) / 10) << 4) | + ((tm->tm_year - 100) % 10)); + + moxart_rtc_write_register(GPIO_RTC_MONTH_W, + (((tm->tm_mon + 1) / 10) << 4) | + ((tm->tm_mon + 1) % 10)); + + moxart_rtc_write_register(GPIO_RTC_DATE_W, + ((tm->tm_mday / 10) << 4) | + (tm->tm_mday % 10)); + + moxart_rtc_write_register(GPIO_RTC_HOURS_W, + ((tm->tm_hour / 10) << 4) | + (tm->tm_hour % 10)); + + moxart_rtc_write_register(GPIO_RTC_MINUTES_W, + ((tm->tm_min / 10) << 4) | + (tm->tm_min % 10)); + + moxart_rtc_write_register(GPIO_RTC_SECONDS_W, + ((tm->tm_sec / 10) << 4) | + (tm->tm_sec % 10)); + + moxart_rtc_write_register(GPIO_RTC_PROTECT_W, 0x80); + + spin_unlock_irq(&moxart_rtc->rtc_lock); + + dev_dbg(dev, "%s: success tm_year=%d tm_mon=%d\n" + "tm_mday=%d tm_hour=%d tm_min=%d tm_sec=%d\n", + __func__, tm->tm_year, tm->tm_mon, tm->tm_mday, + tm->tm_hour, tm->tm_min, tm->tm_sec); + + return 0; +} + +static int moxart_rtc_read_time(struct device *dev, struct rtc_time *tm) +{ + struct moxart_rtc *moxart_rtc = dev_get_drvdata(dev); + unsigned char v; + + spin_lock_irq(&moxart_rtc->rtc_lock); + + v = moxart_rtc_read_register(GPIO_RTC_SECONDS_R); + tm->tm_sec = (((v & 0x70) >> 4) * 10) + (v & 0x0F); + + v = moxart_rtc_read_register(GPIO_RTC_MINUTES_R); + tm->tm_min = (((v & 0x70) >> 4) * 10) + (v & 0x0F); + + v = moxart_rtc_read_register(GPIO_RTC_HOURS_R); + if (v & 0x80) { /* 12-hour mode */ + tm->tm_hour = (((v & 0x10) >> 4) * 10) + (v & 0x0F); + if (v & 0x20) { /* PM mode */ + tm->tm_hour += 12; + if (tm->tm_hour >= 24) + tm->tm_hour = 0; + } + } else { /* 24-hour mode */ + tm->tm_hour = (((v & 0x30) >> 4) * 10) + (v & 0x0F); + } + + v = moxart_rtc_read_register(GPIO_RTC_DATE_R); + tm->tm_mday = (((v & 0x30) >> 4) * 10) + (v & 0x0F); + + v = moxart_rtc_read_register(GPIO_RTC_MONTH_R); + tm->tm_mon = (((v & 0x10) >> 4) * 10) + (v & 0x0F); + tm->tm_mon--; + + v = moxart_rtc_read_register(GPIO_RTC_YEAR_R); + tm->tm_year = (((v & 0xF0) >> 4) * 10) + (v & 0x0F); + tm->tm_year += 100; + if (tm->tm_year <= 69) + tm->tm_year += 100; + + v = moxart_rtc_read_register(GPIO_RTC_DAY_R); + tm->tm_wday = (v & 0x0f) - 1; + tm->tm_yday = day_of_year[tm->tm_mon]; + tm->tm_yday += (tm->tm_mday - 1); + if (tm->tm_mon >= 2) { + if (!(tm->tm_year % 4) && (tm->tm_year % 100)) + tm->tm_yday++; + } + + tm->tm_isdst = 0; + + spin_unlock_irq(&moxart_rtc->rtc_lock); + + return 0; +} + +static const struct rtc_class_ops moxart_rtc_ops = { + .read_time = moxart_rtc_read_time, + .set_time = moxart_rtc_set_time, +}; + +static int moxart_rtc_probe(struct platform_device *pdev) +{ + struct moxart_rtc *moxart_rtc; + int ret = 0; + + moxart_rtc = devm_kzalloc(&pdev->dev, sizeof(*moxart_rtc), GFP_KERNEL); + if (!moxart_rtc) { + dev_err(&pdev->dev, "devm_kzalloc failed\n"); + return -ENOMEM; + } + + spin_lock_init(&moxart_rtc->rtc_lock); + platform_set_drvdata(pdev, moxart_rtc); + + devm_gpio_request(&pdev->dev, GPIO_RTC_DATA, "rtc_data"); + devm_gpio_request(&pdev->dev, GPIO_RTC_SCLK, "rtc_sclk"); + devm_gpio_request(&pdev->dev, GPIO_RTC_RESET, "rtc_reset"); + + gpio_direction_output(GPIO_RTC_RESET, 0); + gpio_direction_output(GPIO_RTC_SCLK, 0); + + moxart_rtc->rtc = rtc_device_register(pdev->name, &pdev->dev, + &moxart_rtc_ops, THIS_MODULE); + if (IS_ERR(moxart_rtc->rtc)) { + ret = PTR_ERR(moxart_rtc->rtc); + goto out; + } + + dev_dbg(&pdev->dev, "%s\n", __func__); + + if (ret) + goto out; + + return 0; + + out: + if (moxart_rtc->rtc) + rtc_device_unregister(moxart_rtc->rtc); + return ret; +} + +static int moxart_rtc_remove(struct platform_device *pdev) +{ + struct moxart_rtc *moxart_rtc = platform_get_drvdata(pdev); + + rtc_device_unregister(moxart_rtc->rtc); + + return 0; +} + +static const struct of_device_id moxart_rtc_match[] = { + { .compatible = "moxa,moxart-rtc" }, + { }, +}; + +static struct platform_driver moxart_rtc_driver = { + .probe = moxart_rtc_probe, + .remove = moxart_rtc_remove, + .driver = { + .name = "moxart-rtc", + .owner = THIS_MODULE, + .of_match_table = moxart_rtc_match, + }, +}; +module_platform_driver(moxart_rtc_driver); + +MODULE_DESCRIPTION("MOXART RTC driver"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Jonas Jensen ");