Patchwork Restore cr16-elf

login
register
mail settings
Submitter Jan-Benedict Glaw
Date July 9, 2013, 11:05 p.m.
Message ID <20130709230520.GA5610@lug-owl.de>
Download mbox | patch
Permalink /patch/257899/
State New
Headers show

Comments

Jan-Benedict Glaw - July 9, 2013, 11:05 p.m.
Hi!

I just tried to build cr16-elf, which fails due to a dependency
problem: `gencodes' is needed to build insn-codes.h, but for building
it, target.h is included in cr16-protos.h, which in turn includes
insn-codes.h:

[...]
g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE -I. -Ibuild -I../../../../gcc/gcc -I../../../../gcc/gcc/build -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    \
                -o build/gencondmd.o build/gencondmd.c
In file included from ../../../../gcc/gcc/config/cr16/cr16-protos.h:24:0,
                 from ./tm_p.h:4,
                 from build/gencondmd.c:24:
../../../../gcc/gcc/target.h:52:24: fatal error: insn-codes.h: No such file or directory
compilation terminated.
make[2]: *** [build/gencondmd.o] Error 1
make[2]: Leaving directory `/mnt/devel/src/linux/build/cr16-elf/gcc-stage1/gcc'
make[1]: *** [all-gcc] Error 2
make[1]: Leaving directory `/mnt/devel/src/linux/build/cr16-elf/gcc-stage1'



The target.h include in cr16-protos.h isn't needed, so don't include
it. This allows to build for cr16-elf again.

Ok to commit?

2013-07-10  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

gcc/
	* config/cr16/cr16-protos.h: Don't include target.h.
Jan-Benedict Glaw - July 9, 2013, 11:44 p.m.
On Wed, 2013-07-10 01:05:21 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
[...]
The email address listed in MAINTAINERS for the person who submitted
this port, Jayant Sonar <jayant.sonar@kpitcummins.com>, bounces, though.

MfG, JBG
Jeff Law - July 10, 2013, 3:08 a.m.
On 07/09/2013 05:05 PM, Jan-Benedict Glaw wrote:
> Hi!
>
> I just tried to build cr16-elf, which fails due to a dependency
> problem: `gencodes' is needed to build insn-codes.h, but for building
> it, target.h is included in cr16-protos.h, which in turn includes
> insn-codes.h:
>
> [...]
> g++ -c   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE -I. -Ibuild -I../../../../gcc/gcc -I../../../../gcc/gcc/build -I../../../../gcc/gcc/../include -I../../../../gcc/gcc/../libcpp/include  -I../../../../gcc/gcc/../libdecnumber -I../../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../../gcc/gcc/../libbacktrace    \
>                  -o build/gencondmd.o build/gencondmd.c
> In file included from ../../../../gcc/gcc/config/cr16/cr16-protos.h:24:0,
>                   from ./tm_p.h:4,
>                   from build/gencondmd.c:24:
> ../../../../gcc/gcc/target.h:52:24: fatal error: insn-codes.h: No such file or directory
> compilation terminated.
> make[2]: *** [build/gencondmd.o] Error 1
> make[2]: Leaving directory `/mnt/devel/src/linux/build/cr16-elf/gcc-stage1/gcc'
> make[1]: *** [all-gcc] Error 2
> make[1]: Leaving directory `/mnt/devel/src/linux/build/cr16-elf/gcc-stage1'
>
>
>
> The target.h include in cr16-protos.h isn't needed, so don't include
> it. This allows to build for cr16-elf again.
>
> Ok to commit?
>
> 2013-07-10  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>
> gcc/
> 	* config/cr16/cr16-protos.h: Don't include target.h.
This is fine.  Thanks.

jeff

Patch

diff --git a/gcc/config/cr16/cr16-protos.h b/gcc/config/cr16/cr16-protos.h
index a521315..f6663c9 100644
--- a/gcc/config/cr16/cr16-protos.h
+++ b/gcc/config/cr16/cr16-protos.h
@@ -21,8 +21,6 @@ 
 #ifndef GCC_CR16_PROTOS_H
 #define GCC_CR16_PROTOS_H
 
-#include "target.h"
-
 /* Register usage.  */
 extern enum reg_class cr16_regno_reg_class (int);
 extern int cr16_hard_regno_mode_ok (int regno, enum machine_mode);