From patchwork Thu Apr 9 08:02:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 25773 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id A3020DE111 for ; Thu, 9 Apr 2009 18:03:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758806AbZDIIDu (ORCPT ); Thu, 9 Apr 2009 04:03:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757343AbZDIIDt (ORCPT ); Thu, 9 Apr 2009 04:03:49 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:54588 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1756086AbZDIIDr (ORCPT ); Thu, 9 Apr 2009 04:03:47 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 7083B17012D; Thu, 9 Apr 2009 16:49:04 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n3984Q2f031838; Thu, 9 Apr 2009 16:04:26 +0800 Received: from [127.0.0.1] (unknown [10.167.141.76]) by fnst.cn.fujitsu.com (Postfix) with ESMTP id 9C8DB2921A2; Thu, 9 Apr 2009 16:08:56 +0800 (CST) Message-ID: <49DDAB8A.5000300@cn.fujitsu.com> Date: Thu, 09 Apr 2009 16:02:18 +0800 From: Wei Yongjun User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Andy Grover , David Miller , netdev@vger.kernel.org Subject: rds: use kmem_cache_zalloc instead of kmem_cache_alloc/memset Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use kmem_cache_zalloc instead of kmem_cache_alloc/memset. Signed-off-by: Wei Yongjun --- net/rds/connection.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/net/rds/connection.c b/net/rds/connection.c index 273f064..d14445c 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -148,14 +148,12 @@ static struct rds_connection *__rds_conn_create(__be32 laddr, __be32 faddr, if (conn) goto out; - conn = kmem_cache_alloc(rds_conn_slab, gfp); + conn = kmem_cache_zalloc(rds_conn_slab, gfp); if (conn == NULL) { conn = ERR_PTR(-ENOMEM); goto out; } - memset(conn, 0, sizeof(*conn)); - INIT_HLIST_NODE(&conn->c_hash_node); conn->c_version = RDS_PROTOCOL_3_0; conn->c_laddr = laddr;