Patchwork [1/3] ACPI / hotplug / PCI: Always return success after adding a function

mail settings
Submitter Rafael J. Wysocki
Date July 8, 2013, 1:28 p.m.
Message ID <1502675.WMZKWG2iox@vostro.rjw.lan>
Download mbox | patch
Permalink /patch/257555/
State Not Applicable
Headers show


Rafael J. Wysocki - July 8, 2013, 1:28 p.m.
From: Rafael J. Wysocki <>

When a new ACPIPHP function is added by register_slot() and the
notify handler cannot be installed for it, register_slot() returns an
error status without cleaning up, which causes the entire namespace
walk in acpiphp_enumerate_slots() to be aborted, although it still
may be possible to successfully install the function notify handler
for other device objects under the given brigde.

To address this issue make register_slot() return success after
a new function has been added, even if the addition of the notify
handler for it has failed.

Signed-off-by: Rafael J. Wysocki <>
 drivers/pci/hotplug/acpiphp_glue.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to
More majordomo info at


Index: linux-pm/drivers/pci/hotplug/acpiphp_glue.c
--- linux-pm.orig/drivers/pci/hotplug/acpiphp_glue.c
+++ linux-pm/drivers/pci/hotplug/acpiphp_glue.c
@@ -335,10 +335,9 @@  register_slot(acpi_handle handle, u32 lv
 		if (ACPI_FAILURE(status))
 			err("failed to register interrupt notify handler\n");
-	} else
-		status = AE_OK;
+	}
-	return status;
+	return AE_OK;