From patchwork Mon Jul 8 03:10:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 257461 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id C07A82C00AA for ; Mon, 8 Jul 2013 13:11:10 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id AE6CB4A051; Mon, 8 Jul 2013 05:11:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A5tLo4h9+WP8; Mon, 8 Jul 2013 05:11:07 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id F22884A047; Mon, 8 Jul 2013 05:11:04 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1504C4A047 for ; Mon, 8 Jul 2013 05:10:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gWxCC4rosrwT for ; Mon, 8 Jul 2013 05:10:50 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pb0-f42.google.com (mail-pb0-f42.google.com [209.85.160.42]) by theia.denx.de (Postfix) with ESMTPS id C2CBC4A046 for ; Mon, 8 Jul 2013 05:10:42 +0200 (CEST) Received: by mail-pb0-f42.google.com with SMTP id un1so3816857pbc.29 for ; Sun, 07 Jul 2013 20:10:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=C4Tu71b5uyqSQxdUfdBMnuUL6DX32kmW6TXejaKRsRU=; b=Lo/YpLNmW1icQe7iCvgbCsgVozwjUfgHs4c+TkJbKwTGTL4HFNzw6+1eLNHLWPo9M3 vorE5mxK99LLV3Gk3xPR7L7QKXwnZflBX885V4zNvg9fBvAqn3zJ0rPwXimfMT+fNbG/ 6SPvm3TIJTWxJAXXvWXvKmHT069yh6bGmg2R+EjvF93r8ryT+y/5vOhp5ONSBjr8F7Ah dHggnxV9DR9yhbqUhCvCp6QAXcPad9Sp9ddPNYAT/gexXZqnctZDSHSntn1btwoxnzHy fyJFwCK/YnnwU5AR+W96i1QjzZ2CceWtcKdVemihPprWrne/rrSl3uLcpZKnA9VD42pm Kp7A== X-Received: by 10.68.200.104 with SMTP id jr8mr19477887pbc.43.1373253040524; Sun, 07 Jul 2013 20:10:40 -0700 (PDT) Received: from [10.10.10.29] ([115.113.119.130]) by mx.google.com with ESMTPSA id lk9sm3441853pab.2.2013.07.07.20.10.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 07 Jul 2013 20:10:39 -0700 (PDT) Message-ID: <51DA2DAC.9010103@linaro.org> Date: Mon, 08 Jul 2013 08:40:36 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Simon Glass References: <1373013620-13812-1-git-send-email-tushar.behera@linaro.org> In-Reply-To: X-Gm-Message-State: ALoCoQkl/TMelhF2q040ty3YquNnHIfCfKVpPuaSz0sYHp2C8R7SCjGhEQv8s+LRU/MMVXBoIvb5 Cc: U-Boot Mailing List , Patch Tracking Subject: Re: [U-Boot] [PATCH] common: board_f: Fix build error when CONFIG_TRACE is not defined X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On 07/06/2013 01:27 AM, Simon Glass wrote: > Hi Tushar, > > On Fri, Jul 5, 2013 at 1:40 AM, Tushar Behera wrote: > >> When CONFIG_TRACE is not defined, definition of trace_early_init is not >> compiled and we get following error. >> >> common/libcommon.o:(.data.init_sequence_f+0xc): undefined reference to >> `trace_early_init' >> >> While at it, also define reserve_trace only if CONFIG_TRACE is defined. >> >> CC: Simon Glass >> Signed-off-by: Tushar Behera >> --- >> common/board_f.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/common/board_f.c b/common/board_f.c >> index ab4242a..a685368 100644 >> --- a/common/board_f.c >> +++ b/common/board_f.c >> @@ -501,17 +501,17 @@ static int reserve_lcd(void) >> } >> #endif /* CONFIG_LCD */ >> >> +#ifdef CONFIG_TRACE >> static int reserve_trace(void) >> { >> -#ifdef CONFIG_TRACE >> gd->relocaddr -= CONFIG_TRACE_BUFFER_SIZE; >> gd->trace_buff = map_sysmem(gd->relocaddr, >> CONFIG_TRACE_BUFFER_SIZE); >> debug("Reserving %dk for trace data at: %08lx\n", >> CONFIG_TRACE_BUFFER_SIZE >> 10, gd->relocaddr); >> -#endif >> >> return 0; >> } >> +#endif >> >> #if defined(CONFIG_VIDEO) && (!defined(CONFIG_PPC) || >> defined(CONFIG_8xx)) \ >> && !defined(CONFIG_ARM) && !defined(CONFIG_X86) >> @@ -833,7 +833,9 @@ static init_fnc_t init_sequence_f[] = { >> #endif >> setup_mon_len, >> setup_fdt, >> +#ifdef CONFIG_TRACE >> trace_early_init, >> +#endif >> #if defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) >> /* TODO: can this go into arch_cpu_init()? */ >> probecpu, >> @@ -977,7 +979,9 @@ static init_fnc_t init_sequence_f[] = { >> #ifdef CONFIG_LCD >> reserve_lcd, >> #endif >> +#ifdef CONFIG_TRACE >> reserve_trace, >> +#endif >> /* TODO: Why the dependency on CONFIG_8xx? */ >> #if defined(CONFIG_VIDEO) && (!defined(CONFIG_PPC) || >> defined(CONFIG_8xx)) \ >> && !defined(CONFIG_ARM) && !defined(CONFIG_X86) >> > > Does the static inline not work for you? What toolchain are you using? I > assume this is ARM? > I was testing on EXYNOS5250 using 4.7.3 toolchain. My mistake: while testing this patch, I had disabled CONFIG_TRACE, but CONFIG_TRACE_EARLY was still enabled, hence the error. You may ignore the patch. IMHO, we should define the TRACE related config options only if TRACE is enabled. If that is ok for you, I will submit a patch for that. > Simon > --- a/include/configs/exynos5250-dt.h +++ b/include/configs/exynos5250-dt.h @@ -45,11 +45,13 @@ /* Allow tracing to be enabled */ #define CONFIG_TRACE +#ifdef CONFIG_TRACE #define CONFIG_CMD_TRACE #define CONFIG_TRACE_BUFFER_SIZE (16 << 20) #define CONFIG_TRACE_EARLY_SIZE (8 << 20) #define CONFIG_TRACE_EARLY #define CONFIG_TRACE_EARLY_ADDR 0x50000000 +#endif > Regards,