From patchwork Wed Apr 8 22:53:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Miller X-Patchwork-Id: 25746 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BEB3CDE0CE for ; Thu, 9 Apr 2009 08:54:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753711AbZDHWx5 (ORCPT ); Wed, 8 Apr 2009 18:53:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753498AbZDHWx5 (ORCPT ); Wed, 8 Apr 2009 18:53:57 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:33815 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751745AbZDHWx4 (ORCPT ); Wed, 8 Apr 2009 18:53:56 -0400 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 2522735C4E0 for ; Wed, 8 Apr 2009 15:53:47 -0700 (PDT) Date: Wed, 08 Apr 2009 15:53:47 -0700 (PDT) Message-Id: <20090408.155347.60915086.davem@davemloft.net> To: netdev@vger.kernel.org Subject: [PATCH]: Fix niu warning... From: David Miller X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For a while GCC has been emitting driver/net/niu.c:4937 'val' may be use uninitialized in this function I finally got fed up enough with it to commit the following. niu: Fix unused variable warning. Don't strain gcc's tiny mind. Signed-off-by: David S. Miller --- drivers/net/niu.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/niu.c b/drivers/net/niu.c index 2cd6109..2b17453 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -4834,6 +4834,7 @@ static int niu_compute_rbr_cfig_b(struct rx_ring_info *rp, u64 *ret) { u64 val = 0; + *ret = 0; switch (rp->rbr_block_size) { case 4 * 1024: val |= (RBR_BLKSIZE_4K << RBR_CFIG_B_BLKSIZE_SHIFT);