Patchwork : Fix niu warning...

login
register
mail settings
Submitter David Miller
Date April 8, 2009, 10:53 p.m.
Message ID <20090408.155347.60915086.davem@davemloft.net>
Download mbox | patch
Permalink /patch/25746/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - April 8, 2009, 10:53 p.m.
For a while GCC has been emitting driver/net/niu.c:4937
'val' may be use uninitialized in this function

I finally got fed up enough with it to commit the following.

niu: Fix unused variable warning.

Don't strain gcc's tiny mind.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/niu.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 2cd6109..2b17453 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -4834,6 +4834,7 @@  static int niu_compute_rbr_cfig_b(struct rx_ring_info *rp, u64 *ret)
 {
 	u64 val = 0;
 
+	*ret = 0;
 	switch (rp->rbr_block_size) {
 	case 4 * 1024:
 		val |= (RBR_BLKSIZE_4K << RBR_CFIG_B_BLKSIZE_SHIFT);