mbox

[PULL,v4,00/18] pci,misc enhancements

Message ID 1373228271-31223-1-git-send-email-mst@redhat.com
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony

Message

Michael S. Tsirkin July 7, 2013, 8:19 p.m. UTC 
From: Michael S. Tsirkin <mst@redhat.com>

Changes from v3:
    - fix up xen build

Changes from v2:
    - rebased to origin/master
    - fixed up botched posting

The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf:

  Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-07-03 08:37:00 -0500)

are available in the git repository at:


  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony

for you to fetch changes up to 7588e2b0559ae72d3c2952c7807fc05c03099970:

  pci: Fold host_buses list into PCIHostState functionality (2013-07-07 23:10:57 +0300)

----------------------------------------------------------------
pci,misc enhancements

This includes some pci enhancements:

Better support for systems with multiple PCI root buses
FW cfg interface for more robust pci programming in BIOS
Minor fixes/cleanups for fw cfg and cross-version migration -
    because of dependencies with other patches

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Andrew Jones (1):
      e1000: cleanup process_tx_desc

David Gibson (10):
      pci: Cleanup configuration for pci-hotplug.c
      pci: Move pci_read_devaddr to pci-hotplug-old.c
      pci: Abolish pci_find_root_bus()
      pci: Use helper to find device's root bus in pci_find_domain()
      pci: Replace pci_find_domain() with more general pci_root_bus_path()
      pci: Add root bus argument to pci_get_bus_devfn()
      pci: Add root bus parameter to pci_nic_init()
      pci: Simpler implementation of primary PCI bus
      pci: Remove domain from PCIHostBus
      pci: Fold host_buses list into PCIHostState functionality

Michael S. Tsirkin (7):
      range: add Range structure
      pci: store PCI hole ranges in guestinfo structure
      pc: pass PCI hole ranges to Guests
      pc_piix: cleanup init compat handling
      MAINTAINERS: s/Marcelo/Paolo/
      pvpanic: initialization cleanup
      pvpanic: fix fwcfg for big endian hosts

 MAINTAINERS                                 |   2 +-
 default-configs/i386-softmmu.mak            |   3 +-
 default-configs/ppc64-softmmu.mak           |   2 -
 default-configs/x86_64-softmmu.mak          |   3 +-
 hmp-commands.hx                             |   4 +-
 hw/alpha/dp264.c                            |   2 +-
 hw/arm/realview.c                           |   6 +-
 hw/arm/versatilepb.c                        |   2 +-
 hw/i386/pc.c                                |  74 ++++++++++++++-
 hw/i386/pc_piix.c                           |  42 ++++++---
 hw/i386/pc_q35.c                            |  18 +++-
 hw/mips/mips_fulong2e.c                     |   6 +-
 hw/mips/mips_malta.c                        |   6 +-
 hw/misc/pvpanic.c                           |  31 ++++---
 hw/net/e1000.c                              |  18 ++--
 hw/pci-host/piix.c                          |   9 ++
 hw/pci-host/q35.c                           |  17 ++++
 hw/pci/Makefile.objs                        |   2 +-
 hw/pci/{pci-hotplug.c => pci-hotplug-old.c} |  75 ++++++++++++---
 hw/pci/pci.c                                | 137 ++++++++++++++--------------
 hw/pci/pci_host.c                           |   1 +
 hw/pci/pcie_aer.c                           |   9 +-
 hw/ppc/e500.c                               |   2 +-
 hw/ppc/mac_newworld.c                       |   2 +-
 hw/ppc/mac_oldworld.c                       |   2 +-
 hw/ppc/ppc440_bamboo.c                      |   2 +-
 hw/ppc/prep.c                               |   2 +-
 hw/ppc/spapr.c                              |   2 +-
 hw/ppc/spapr_pci.c                          |  10 ++
 hw/sh4/r2d.c                                |   5 +-
 hw/sparc64/sun4u.c                          |   2 +-
 include/hw/i386/pc.h                        |  22 ++++-
 include/hw/pci-host/q35.h                   |   2 +
 include/hw/pci/pci.h                        |  17 ++--
 include/hw/pci/pci_host.h                   |  12 +++
 include/qemu/range.h                        |  16 ++++
 include/qemu/typedefs.h                     |   1 +
 37 files changed, 405 insertions(+), 163 deletions(-)
 rename hw/pci/{pci-hotplug.c => pci-hotplug-old.c} (78%)

Comments

Stefano Stabellini July 10, 2013, 2:11 p.m. UTC | #1 
On Sun, 7 Jul 2013, Michael S. Tsirkin wrote:
> From: Michael S. Tsirkin <mst@redhat.com>
> 
> Changes from v3:
>     - fix up xen build
> 
> Changes from v2:
>     - rebased to origin/master
>     - fixed up botched posting
> 
> The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf:
> 
>   Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-07-03 08:37:00 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
> 
> for you to fetch changes up to 7588e2b0559ae72d3c2952c7807fc05c03099970:
> 
>   pci: Fold host_buses list into PCIHostState functionality (2013-07-07 23:10:57 +0300)

This patch series breaks Xen support in QEMU.
Unfortunately QEMU exits at boot time with no output, I'll try to get
back to you with more info.
Michael S. Tsirkin July 10, 2013, 2:21 p.m. UTC | #2 
On Wed, Jul 10, 2013 at 03:11:27PM +0100, Stefano Stabellini wrote:
> On Sun, 7 Jul 2013, Michael S. Tsirkin wrote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> > 
> > Changes from v3:
> >     - fix up xen build
> > 
> > Changes from v2:
> >     - rebased to origin/master
> >     - fixed up botched posting
> > 
> > The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf:
> > 
> >   Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-07-03 08:37:00 -0500)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
> > 
> > for you to fetch changes up to 7588e2b0559ae72d3c2952c7807fc05c03099970:
> > 
> >   pci: Fold host_buses list into PCIHostState functionality (2013-07-07 23:10:57 +0300)
> 
> This patch series breaks Xen support in QEMU.
> Unfortunately QEMU exits at boot time with no output, I'll try to get
> back to you with more info.

This is the main change for Xen:

-    bus = pci_find_root_bus(0);
+    bus = pci_find_primary_bus();

Could you please try 1ef7a2a2afedbba47e06af5081a8b4bf6dc1cf71
that made this change, and 1ef7a2a2afedbba47e06af5081a8b4bf6dc1cf71~1 
before it?
Stefano Stabellini July 10, 2013, 2:30 p.m. UTC | #3 
On Wed, 10 Jul 2013, Michael S. Tsirkin wrote:
> On Wed, Jul 10, 2013 at 03:11:27PM +0100, Stefano Stabellini wrote:
> > On Sun, 7 Jul 2013, Michael S. Tsirkin wrote:
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > 
> > > Changes from v3:
> > >     - fix up xen build
> > > 
> > > Changes from v2:
> > >     - rebased to origin/master
> > >     - fixed up botched posting
> > > 
> > > The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf:
> > > 
> > >   Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-07-03 08:37:00 -0500)
> > > 
> > > are available in the git repository at:
> > > 
> > > 
> > >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
> > > 
> > > for you to fetch changes up to 7588e2b0559ae72d3c2952c7807fc05c03099970:
> > > 
> > >   pci: Fold host_buses list into PCIHostState functionality (2013-07-07 23:10:57 +0300)
> > 
> > This patch series breaks Xen support in QEMU.
> > Unfortunately QEMU exits at boot time with no output, I'll try to get
> > back to you with more info.
> 
> This is the main change for Xen:
> 
> -    bus = pci_find_root_bus(0);
> +    bus = pci_find_primary_bus();
> 
> Could you please try 1ef7a2a2afedbba47e06af5081a8b4bf6dc1cf71
> that made this change, and 1ef7a2a2afedbba47e06af5081a8b4bf6dc1cf71~1 
> before it?
> 

git bisect tells me that the problem is caused by:

commit f8c457b88d72a48989f190bc3d7b79f4f3b7d11c
Author: Michael S. Tsirkin <mst@redhat.com>
Date:   Mon May 13 20:00:23 2013 +0300

    pc: pass PCI hole ranges to Guests