Patchwork [-next] ethoc: fix library build errors

login
register
mail settings
Submitter Randy Dunlap
Date April 8, 2009, 5 p.m.
Message ID <20090408100039.855ab138.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/25733/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - April 8, 2009, 5 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

ethoc indirectly uses crc32_le() and bitrev32(), so select
those library functions to be built.

drivers/built-in.o: In function `ethoc_set_multicast_list':
ethoc.c:(.text+0x6226f): undefined reference to `crc32_le'
ethoc.c:(.text+0x62276): undefined reference to `bitrev32'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Thierry Reding <thierry.reding@avionic-design.de>
---
 drivers/net/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 8, 2009, 10:41 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 8 Apr 2009 10:00:39 -0700

> ethoc indirectly uses crc32_le() and bitrev32(), so select
> those library functions to be built.
> 
> drivers/built-in.o: In function `ethoc_set_multicast_list':
> ethoc.c:(.text+0x6226f): undefined reference to `crc32_le'
> ethoc.c:(.text+0x62276): undefined reference to `bitrev32'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20090408.orig/drivers/net/Kconfig
+++ linux-next-20090408/drivers/net/Kconfig
@@ -977,6 +977,8 @@  config ETHOC
 	depends on NET_ETHERNET && HAS_IOMEM
 	select MII
 	select PHYLIB
+	select CRC32
+	select BITREVERSE
 	help
 	  Say Y here if you want to use the OpenCores 10/100 Mbps Ethernet MAC.