| Message ID | 1373124796-6810-4-git-send-email-eric@regit.org |
|---|---|
| State | Accepted |
| Headers | show |
On Sat, Jul 06, 2013 at 05:33:16PM +0200, Eric Leblond wrote: > The function nft_rule_attr_is_set() is doing no modification so it > is possible to type it to const. I have mangled this patch to adapt all other nft_*_attr_is_set as well. This patch is master now, thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/libnftables/rule.h b/include/libnftables/rule.h index ab61eb8..5496561 100644 --- a/include/libnftables/rule.h +++ b/include/libnftables/rule.h @@ -26,7 +26,7 @@ enum { }; void nft_rule_attr_unset(struct nft_rule *r, uint16_t attr); -bool nft_rule_attr_is_set(struct nft_rule *r, uint16_t attr); +bool nft_rule_attr_is_set(const struct nft_rule *r, uint16_t attr); void nft_rule_attr_set(struct nft_rule *r, uint16_t attr, const void *data); void nft_rule_attr_set_u32(struct nft_rule *r, uint16_t attr, uint32_t val); void nft_rule_attr_set_u64(struct nft_rule *r, uint16_t attr, uint64_t val); diff --git a/src/rule.c b/src/rule.c index 9dc82b8..dc98a8f 100644 --- a/src/rule.c +++ b/src/rule.c @@ -73,7 +73,7 @@ void nft_rule_free(struct nft_rule *r) } EXPORT_SYMBOL(nft_rule_free); -bool nft_rule_attr_is_set(struct nft_rule *r, uint16_t attr) +bool nft_rule_attr_is_set(const struct nft_rule *r, uint16_t attr) { return r->flags & (1 << attr); }
The function nft_rule_attr_is_set() is doing no modification so it is possible to type it to const. Signed-off-by: Eric Leblond <eric@regit.org> --- include/libnftables/rule.h | 2 +- src/rule.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)