From patchwork Wed Apr 8 11:39:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 25726 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 72A86DDFBA for ; Wed, 8 Apr 2009 21:45:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932899AbZDHLnw (ORCPT ); Wed, 8 Apr 2009 07:43:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932892AbZDHLnu (ORCPT ); Wed, 8 Apr 2009 07:43:50 -0400 Received: from qw-out-2122.google.com ([74.125.92.25]:34586 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932885AbZDHLns (ORCPT ); Wed, 8 Apr 2009 07:43:48 -0400 Received: by qw-out-2122.google.com with SMTP id 8so56150qwh.37 for ; Wed, 08 Apr 2009 04:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:x-x-sender:to :subject:message-id:user-agent:mime-version:content-type; bh=LejaYzZk1UWboIWDQfsI5MloZDZc7HFNwrrpEeacucw=; b=Kpj8ADjs2h2adn/Q4oncc9YPUqp3GdC4SvaGicg5R6BJ3j7PMKnjenHX6HHukX0qXf jAtUi1jR0wYcEV7m/SC7pM3SeDUrhyyBNTryVk3OiLwU3QnUHG0Fx5KhS7swq8kM6q9X CcPr9p4w31g3IfSzpNVIaJASbZiJ6LvW2nYMw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:subject:message-id:user-agent:mime-version :content-type; b=KgT5uWYVVkUUDrKuTAbHrarQdfEUvE1nL1+2RLr8Tr6xDHknaOhDJZT2NVN/R3dHnQ IEKDqWNDLpMcjMqhi2tVTlw39inGpoUs00jUBsWIyc5lVlbOv7Lc+O5+FOZr6Sc392MY w2pFYBehlc7dBOQnFxNQa7/p4iMoKjrouwDFs= Received: by 10.224.37.10 with SMTP id v10mr1373893qad.159.1239191027783; Wed, 08 Apr 2009 04:43:47 -0700 (PDT) Received: from bicker.local ([41.220.212.131]) by mx.google.com with ESMTPS id 7sm946939qwf.19.2009.04.08.04.43.43 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 08 Apr 2009 04:43:47 -0700 (PDT) Date: Wed, 8 Apr 2009 14:39:28 +0300 (EAT) From: Dan Carpenter X-X-Sender: dcarpenter@bicker To: netdev@vger.kernel.org Subject: [patch] nui.c error handling Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_device_register_simple() returns ERR_PTR(), not NULL, if an error occurs. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- orig/drivers/net/niu.c 2009-04-07 21:59:22.000000000 +0300 +++ devel/drivers/net/niu.c 2009-04-07 22:00:45.000000000 +0300 @@ -8757,7 +8757,7 @@ plat_dev = platform_device_register_simple("niu", niu_parent_index, NULL, 0); - if (!plat_dev) + if (IS_ERR(plat_dev)) return NULL; for (i = 0; attr_name(niu_parent_attributes[i]); i++) {