From patchwork Wed Apr 8 10:45:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 25725 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 76EC0DDFB6 for ; Wed, 8 Apr 2009 20:50:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751261AbZDHKuB (ORCPT ); Wed, 8 Apr 2009 06:50:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750772AbZDHKuB (ORCPT ); Wed, 8 Apr 2009 06:50:01 -0400 Received: from yw-out-2324.google.com ([74.125.46.29]:36065 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750706AbZDHKuA (ORCPT ); Wed, 8 Apr 2009 06:50:00 -0400 Received: by yw-out-2324.google.com with SMTP id 5so44503ywb.1 for ; Wed, 08 Apr 2009 03:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:x-x-sender:to :subject:message-id:user-agent:mime-version:content-type; bh=sKspWAsloWID5zJNwX8E4q9LNakws9qqBGXx6zp5zrQ=; b=hXx0TjArb4K6pzib0UJ7qaNSleKdUxyOjt+Tiyvn367vweIhHuS0xQdil/KMVNmTrD Ga6riEhAJuHSMZ6+koibdXOzY8hyhCLhHtfAAPpRsuRXMaLgpqMnAMLYV9wlGf/+RNzJ QvKB1x4cLOjTFKwNmb5N9ecZMJcz+zrlpclT4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:subject:message-id:user-agent:mime-version :content-type; b=bMtwwBhE/WxVun6Jy2BQReEeoySvmMPe0bzFoEVZ92qf8XH3cEuabj/Li+bkpgjp6B xI3tT4x7NWIKzW93u5eSfungndMjP46IyXTQgX+TK+WPKQrPPmVe5GzAzSMUl+Y++1Ft kYBi+NAoAcOnaOHlSHPz3+zJ5JeuxmtwC/MGE= Received: by 10.100.164.20 with SMTP id m20mr2604683ane.85.1239187795096; Wed, 08 Apr 2009 03:49:55 -0700 (PDT) Received: from bicker.local ([41.220.212.131]) by mx.google.com with ESMTPS id c37sm4262200ana.2.2009.04.08.03.49.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 08 Apr 2009 03:49:54 -0700 (PDT) Date: Wed, 8 Apr 2009 13:45:48 +0300 (EAT) From: Dan Carpenter X-X-Sender: dcarpenter@bicker To: netdev@vger.kernel.org Subject: [patch] locking typo in xfrm_state.c Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I'm not sure who to send this patch to. There is a double lock instead of an unlock. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. regards, dan carpenter Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- orig/net/xfrm/xfrm_state.c 2009-04-08 09:19:10.000000000 +0300 +++ devel/net/xfrm/xfrm_state.c 2009-04-08 09:19:18.000000000 +0300 @@ -1615,7 +1615,7 @@ spin_lock_bh(&xfrm_state_lock); list_del(&walk->all); - spin_lock_bh(&xfrm_state_lock); + spin_unlock_bh(&xfrm_state_lock); } EXPORT_SYMBOL(xfrm_state_walk_done);