Patchwork PR57792: Bootstrap darwin13 or later with --with-sysroot to find SDK

login
register
mail settings
Submitter Jack Howarth
Date July 5, 2013, 2:27 a.m.
Message ID <20130705022730.GA566@bromo.med.uc.edu>
Download mbox | patch
Permalink /patch/257031/
State New
Headers show

Comments

Jack Howarth - July 5, 2013, 2:27 a.m.
The attached patch eliminates the problem of the SDK being removed from / in darwin13
and later by appending --with-sysroot=\"`xcrun --show-sdk-path`\" to host_configargs
in the top-level configure for those cases . Bootstrap tested on x86_64-apple-darwin13. 
Okay for gcc trunk and gcc-4_8-branch?
        Jack
2013-07-05  Jack Howarth  <howarth@bromo.med.uc.edu>

	PR target/57792
	* configure.ac: Use --with-sysroot=\"`xcrun --show-sdk-path`\" on darwin13 and later.
	* configure: Regenerated.
Mike Stump - July 10, 2013, 9:24 p.m.
On Jul 4, 2013, at 7:27 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>  The attached patch eliminates the problem of the SDK being removed from / in darwin13
> and later by appending --with-sysroot=\"`xcrun --show-sdk-path`\" to host_configargs
> in the top-level configure for those cases . Bootstrap tested on x86_64-apple-darwin13. 
> Okay for gcc trunk and gcc-4_8-branch?

Ok.

Thanks.

If you could try a build of the software from src, that'd be nice.

gcc/trunk:
Committed revision 200886.
Committed revision 200890.

src:
Checking in ChangeLog;
/cvs/src/src/ChangeLog,v  <--  ChangeLog
new revision: 1.1074; previous revision: 1.1073
done
Checking in configure;
/cvs/src/src/configure,v  <--  configure
new revision: 1.447; previous revision: 1.446
done
Checking in configure.ac;
/cvs/src/src/configure.ac,v  <--  configure.ac
new revision: 1.190; previous revision: 1.189
done

gcc/branches/gcc-4_8-branch:
Committed revision 200889.
Jack Howarth - July 11, 2013, 2:05 a.m.
On Wed, Jul 10, 2013 at 02:24:48PM -0700, Mike Stump wrote:
> On Jul 4, 2013, at 7:27 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> >  The attached patch eliminates the problem of the SDK being removed from / in darwin13
> > and later by appending --with-sysroot=\"`xcrun --show-sdk-path`\" to host_configargs
> > in the top-level configure for those cases . Bootstrap tested on x86_64-apple-darwin13. 
> > Okay for gcc trunk and gcc-4_8-branch?
> 
> Ok.
> 
> Thanks.
> 
> If you could try a build of the software from src, that'd be nice.

Current gcc trunk now builds fine on darwin13. Thanks for the commit.
                     Jack

> 
> gcc/trunk:
> Committed revision 200886.
> Committed revision 200890.
> 
> src:
> Checking in ChangeLog;
> /cvs/src/src/ChangeLog,v  <--  ChangeLog
> new revision: 1.1074; previous revision: 1.1073
> done
> Checking in configure;
> /cvs/src/src/configure,v  <--  configure
> new revision: 1.447; previous revision: 1.446
> done
> Checking in configure.ac;
> /cvs/src/src/configure.ac,v  <--  configure.ac
> new revision: 1.190; previous revision: 1.189
> done
> 
> gcc/branches/gcc-4_8-branch:
> Committed revision 200889.
Mike Stump - July 11, 2013, 5:57 p.m.
On Jul 10, 2013, at 7:05 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> Current gcc trunk now builds fine on darwin13. Thanks for the commit.

Thanks the checking (and the work).

Patch

Index: configure.ac
===================================================================
--- configure.ac	(revision 200683)
+++ configure.ac	(working copy)
@@ -2850,6 +2850,13 @@  if test x${is_cross_compiler} = xyes ; t
   target_configargs="--with-cross-host=${host_noncanonical} ${target_configargs}"
 fi
 
+# Pass --with-sysroot on darwin without SDK in /
+case "${target}" in
+  x86_64-*-darwin1[[3-9]]*)
+    host_configargs="--with-sysroot=\"`xcrun --show-sdk-path`\"  ${host_configargs}"
+    ;;
+esac
+
 # Default to --enable-multilib.
 if test x${enable_multilib} = x ; then
   target_configargs="--enable-multilib ${target_configargs}"