Patchwork [v4,11/15] tcg-arm: Use AT_PLATFORM to detect the host ISA

login
register
mail settings
Submitter Richard Henderson
Date July 4, 2013, 8:40 p.m.
Message ID <1372970462-10338-12-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/257011/
State New
Headers show

Comments

Richard Henderson - July 4, 2013, 8:40 p.m.
With this we can generate armv7 insns even when the OS compiles for a
lower common denominator.  The macros are arranged so that when we do
compile for a given ISA, all of the runtime checks for that ISA are
optimized away.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/arm/tcg-target.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)
Peter Maydell - July 5, 2013, 9:33 a.m.
On 4 July 2013 21:40, Richard Henderson <rth@twiddle.net> wrote:
> With this we can generate armv7 insns even when the OS compiles for a
> lower common denominator.  The macros are arranged so that when we do
> compile for a given ISA, all of the runtime checks for that ISA are
> optimized away.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

Patch

diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index fde1715..4710046 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -41,6 +41,8 @@ 
 # endif
 #endif
 
+static int arm_arch = __ARM_ARCH;
+
 #if defined(__ARM_ARCH_5T__) \
     || defined(__ARM_ARCH_5TE__) || defined(__ARM_ARCH_5TEJ__)
 # define use_armv5t_instructions 1
@@ -48,8 +50,8 @@ 
 # define use_armv5t_instructions use_armv6_instructions
 #endif
 
-#define use_armv6_instructions  (__ARM_ARCH >= 6)
-#define use_armv7_instructions  (__ARM_ARCH >= 7)
+#define use_armv6_instructions  (__ARM_ARCH >= 6 || arm_arch >= 6)
+#define use_armv7_instructions  (__ARM_ARCH >= 7 || arm_arch >= 7)
 
 #ifndef use_idiv_instructions
 bool use_idiv_instructions;
@@ -2028,12 +2030,22 @@  static const TCGTargetOpDef arm_op_defs[] = {
 
 static void tcg_target_init(TCGContext *s)
 {
-#if defined(CONFIG_GETAUXVAL) && !defined(use_idiv_instructions)
+#if defined(CONFIG_GETAUXVAL)
+    /* Only probe for the platform and capabilities if we havn't already
+       determined maximum values at compile time.  */
+# if !defined(use_idiv_instructions)
     {
         unsigned long hwcap = getauxval(AT_HWCAP);
         use_idiv_instructions = (hwcap & HWCAP_ARM_IDIVA) != 0;
     }
-#endif
+# endif
+    if (__ARM_ARCH < 7) {
+        const char *pl = (const char *)getauxval(AT_PLATFORM);
+        if (pl != NULL && pl[0] == 'v' && pl[1] >= '4' && pl[1] <= '9') {
+            arm_arch = pl[1] - '0';
+        }
+    }
+#endif /* GETAUXVAL */
 
     tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff);
     tcg_regset_set32(tcg_target_call_clobber_regs, 0,