From patchwork Wed Apr 8 03:06:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Hongyang X-Patchwork-Id: 25701 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id AAF43DDF8A for ; Wed, 8 Apr 2009 13:07:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbZDHDGX (ORCPT ); Tue, 7 Apr 2009 23:06:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751528AbZDHDGX (ORCPT ); Tue, 7 Apr 2009 23:06:23 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:55644 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751158AbZDHDGW (ORCPT ); Tue, 7 Apr 2009 23:06:22 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 24C6917012E; Wed, 8 Apr 2009 11:50:48 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n383A7Pl018773; Wed, 8 Apr 2009 11:10:07 +0800 Received: from localhost.localdomain (unknown [10.167.141.200]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id 70644290B0E; Wed, 8 Apr 2009 11:11:27 +0800 (CST) Message-ID: <49DC14B3.9020308@cn.fujitsu.com> Date: Wed, 08 Apr 2009 11:06:27 +0800 From: Yang Hongyang User-Agent: Thunderbird 2.0.0.17 (X11/20081009) MIME-Version: 1.0 To: netdev@vger.kernel.org, "David S. Miller" Subject: [PATCH]drivers/net/eql.c:fix a dev leakage Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org After dev_get_by_name(),we should follow a dev_put().build test only. Signed-off-by: Yang Hongyang --- drivers/net/eql.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/eql.c b/drivers/net/eql.c index 51ead79..5210bb1 100644 --- a/drivers/net/eql.c +++ b/drivers/net/eql.c @@ -542,6 +542,8 @@ static int eql_s_slave_cfg(struct net_device *dev, slave_config_t __user *scp) } spin_unlock_bh(&eql->queue.lock); + dev_put(slave_dev); + return ret; }