Patchwork [rs6000] PR target/57150, do not use VSX instructions for long double caller saves

login
register
mail settings
Submitter Joseph S. Myers
Date July 4, 2013, 2:11 p.m.
Message ID <Pine.LNX.4.64.1307041409460.7061@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/256908/
State New
Headers show

Comments

Joseph S. Myers - July 4, 2013, 2:11 p.m.
On Wed, 3 Jul 2013, Joseph S. Myers wrote:

> That change has the effect that reload thinks TFmode (and no doubt
> TDmode) only takes two registers even when in general registers,
> causing a segfault in glibc's test-ldouble built for soft float.
> 
> I'm testing this patch (this diff is against 4.8 branch) to fix this;
> at least, it fixes the glibc testing issue.  Since the original patch
> went on 4.7 and 4.8 branches as well as trunk, I propose this patch
> for the branches as well as trunk.  You may wish to test it in your
> original VSX configuration.

And here is the patch diffed against trunk sources and tested with no
regressions for cross to powerpc-linux-gnu (soft-float).  This fixes
testsuite failures of the tests
c-c++-common/torture/complex-sign-mixed-add.c,
c-c++-common/torture/complex-sign-mixed-div.c,
c-c++-common/torture/complex-sign-mixed-mul.c,
c-c++-common/torture/complex-sign-mixed-sub.c,
c-c++-common/torture/complex-sign-mul-minus-one.c,
g++.dg/torture/type-generic-1.C, gcc.c-torture/execute/pr44942.c,
gcc.c-torture/execute/regstack-1.c,
gcc.c-torture/execute/ieee/fp-cmp-8l.c, gcc.dg/pr28796-2.c and
gcc.dg/torture/type-generic-1.c.  OK to commit?

2013-07-04  Joseph Myers  <joseph@codesourcery.com>

	* config/rs6000/rs6000.c (rs6000_init_hard_regno_mode_ok): Only
	adjust register size for TDmode and TFmode for VSX registers.
Joseph S. Myers - July 9, 2013, 9:02 p.m.
Ping.  This patch 
<http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00164.html> is pending 
review.

Patch

Index: config/rs6000/rs6000.c
===================================================================
--- config/rs6000/rs6000.c	(revision 200643)
+++ config/rs6000/rs6000.c	(working copy)
@@ -2518,7 +2518,8 @@  rs6000_init_hard_regno_mode_ok (bool global_init_p
 	  int reg_size2 = reg_size;
 
 	  /* TFmode/TDmode always takes 2 registers, even in VSX.  */
-	  if (m == TDmode || m == TFmode)
+	  if (TARGET_VSX && VSX_REG_CLASS_P (c)
+	      && (m == TDmode || m == TFmode))
 	    reg_size2 = UNITS_PER_FP_WORD;
 
 	  rs6000_class_max_nregs[m][c]