From patchwork Thu Jul 4 09:53:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wanlong Gao X-Patchwork-Id: 256855 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 333CA2C009E for ; Thu, 4 Jul 2013 19:56:16 +1000 (EST) Received: from localhost ([::1]:51480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UugGr-0007ri-QH for incoming@patchwork.ozlabs.org; Thu, 04 Jul 2013 05:56:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UugEV-00049F-Jm for qemu-devel@nongnu.org; Thu, 04 Jul 2013 05:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UugEU-0002L8-0r for qemu-devel@nongnu.org; Thu, 04 Jul 2013 05:53:47 -0400 Received: from [222.73.24.84] (port=53256 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UugET-0002Jf-N5 for qemu-devel@nongnu.org; Thu, 04 Jul 2013 05:53:45 -0400 X-IronPort-AV: E=Sophos;i="4.87,993,1363104000"; d="scan'208";a="7782337" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 04 Jul 2013 17:50:40 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r649rZes017315; Thu, 4 Jul 2013 17:53:35 +0800 Received: from G08FNSTD121251.fnst.cn.fujitsu.com ([10.167.233.84]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013070417520625-2711620 ; Thu, 4 Jul 2013 17:52:06 +0800 From: Wanlong Gao To: qemu-devel@nongnu.org Date: Thu, 4 Jul 2013 17:53:16 +0800 Message-Id: <1372931597-28115-10-git-send-email-gaowanlong@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.2.634.g7a3187e In-Reply-To: <1372931597-28115-1-git-send-email-gaowanlong@cn.fujitsu.com> References: <1372931597-28115-1-git-send-email-gaowanlong@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/07/04 17:52:06, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/07/04 17:52:07, Serialize complete at 2013/07/04 17:52:07 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 222.73.24.84 Cc: aliguori@us.ibm.com, ehabkost@redhat.com, lcapitulino@redhat.com, bsd@redhat.com, y-goto@jp.fujitsu.com, pbonzini@redhat.com, afaerber@suse.de, gaowanlong@cn.fujitsu.com Subject: [Qemu-devel] [PATCH V4 09/10] NUMA: add hmp command set-mpol X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Add hmp command set-mpol to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mpol 0 mem-policy=membind,mem-hostnode=0-1 Signed-off-by: Wanlong Gao --- hmp-commands.hx | 16 ++++++++++++++++ hmp.c | 35 +++++++++++++++++++++++++++++++++++ hmp.h | 1 + 3 files changed, 52 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..417b69f 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1567,6 +1567,22 @@ Executes a qemu-io command on the given block device. ETEXI { + .name = "set-mpol", + .args_type = "nodeid:i,args:s?", + .params = "nodeid [args]", + .help = "set host memory policy for a guest NUMA node", + .mhandler.cmd = hmp_set_mpol, + }, + +STEXI +@item set-mpol @var{nodeid} @var{args} +@findex set-mpol + +Set host memory policy for a guest NUMA node + +ETEXI + + { .name = "info", .args_type = "item:s?", .params = "[subcommand]", diff --git a/hmp.c b/hmp.c index 2daed43..57a5730 100644 --- a/hmp.c +++ b/hmp.c @@ -1482,3 +1482,38 @@ void hmp_qemu_io(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &err); } + +void hmp_set_mpol(Monitor *mon, const QDict *qdict) +{ + Error *local_err = NULL; + bool has_mpol = true; + bool has_hostnode = true; + const char *mpol = NULL; + const char *hostnode = NULL; + QemuOpts *opts; + + uint64_t nodeid = qdict_get_int(qdict, "nodeid"); + const char *args = qdict_get_try_str(qdict, "args"); + + if (args == NULL) { + has_mpol = false; + has_hostnode = false; + } else { + opts = qemu_opts_parse(qemu_find_opts("numa"), args, 1); + if (opts == NULL) { + error_setg(&local_err, "Parsing memory policy args failed"); + } else { + mpol = qemu_opt_get(opts, "mem-policy"); + if (mpol == NULL) { + has_mpol = false; + } + hostnode = qemu_opt_get(opts, "mem-hostnode"); + if (hostnode == NULL) { + has_hostnode = false; + } + } + } + + qmp_set_mpol(nodeid, has_mpol, mpol, has_hostnode, hostnode, &local_err); + hmp_handle_error(mon, &local_err); +} diff --git a/hmp.h b/hmp.h index 56d2e92..81f631b 100644 --- a/hmp.h +++ b/hmp.h @@ -86,5 +86,6 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict *qdict); void hmp_chardev_add(Monitor *mon, const QDict *qdict); void hmp_chardev_remove(Monitor *mon, const QDict *qdict); void hmp_qemu_io(Monitor *mon, const QDict *qdict); +void hmp_set_mpol(Monitor *mon, const QDict *qdict); #endif