Patchwork libiqrf: Bump to v0.1.2 + update build system.

login
register
mail settings
Submitter Marek Belisko
Date July 3, 2013, 8:51 p.m.
Message ID <1372884680-14309-1-git-send-email-marek.belisko@open-nandra.com>
Download mbox | patch
Permalink /patch/256742/
State Accepted
Headers show

Comments

Marek Belisko - July 3, 2013, 8:51 p.m.
v0.1.2 update build system from autotools to cmake.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 package/libiqrf/libiqrf.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Yann E. MORIN - July 3, 2013, 9:04 p.m.
Marek, All,

On 2013-07-03 22:51 +0200, Marek Belisko spake thusly:
> v0.1.2 update build system from autotools to cmake.

Is it mandatory to switch to cmake when upgrading?
If not, then please split this in two: one to upgrade, one to switch.

If possible, I'd prefer we stick to using autotools if it is still
supported (and maintained) by libiqrf. I'm wary of the fuss around
cmake (but agreed, that's a personal taste). Every now and then, I
pester at cmake usage, since I don't really want to pay the price for
Yet-Another-Build-System, and the very few packages that I need and
use cmake, do compile in an aggregated time much smaller than it takes
to build cmake itself.

So, my personal taste would be to favour autotools against cmake
where/if possible, please. ;-)

Note: of course, if autotools is no longer supported by libiqrf, then
the switch is mandatory, but if so, state it explicitly in the commit
message.

> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  package/libiqrf/libiqrf.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libiqrf/libiqrf.mk b/package/libiqrf/libiqrf.mk
> index f2d5b4c..df4bb42 100644
> --- a/package/libiqrf/libiqrf.mk
> +++ b/package/libiqrf/libiqrf.mk
> @@ -4,11 +4,11 @@
>  #
>  ################################################################################
>  
> -LIBIQRF_VERSION = v0.1.0
> +LIBIQRF_VERSION = v0.1.2
>  LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
>  LIBIQRF_INSTALL_STAGING = YES
>  
>  LIBIQRF_DEPENDENCIES = libusb
>  
> -$(eval $(autotools-package))
> +$(eval $(cmake-package))

Regards,
Yann E. MORIN.
Belisko Marek - July 4, 2013, 4:51 a.m.
Hi Yann,

On Wed, Jul 3, 2013 at 11:04 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Marek, All,
>
> On 2013-07-03 22:51 +0200, Marek Belisko spake thusly:
>> v0.1.2 update build system from autotools to cmake.
>
> Is it mandatory to switch to cmake when upgrading?
> If not, then please split this in two: one to upgrade, one to switch.
>
> If possible, I'd prefer we stick to using autotools if it is still
> supported (and maintained) by libiqrf. I'm wary of the fuss around
> cmake (but agreed, that's a personal taste). Every now and then, I
> pester at cmake usage, since I don't really want to pay the price for
> Yet-Another-Build-System, and the very few packages that I need and
> use cmake, do compile in an aggregated time much smaller than it takes
> to build cmake itself.
>
> So, my personal taste would be to favour autotools against cmake
> where/if possible, please. ;-)
>
> Note: of course, if autotools is no longer supported by libiqrf, then
> the switch is mandatory, but if so, state it explicitly in the commit
> message.
Right, autotools was replaced by cmake in version v0.1.2.
>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>>  package/libiqrf/libiqrf.mk | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/libiqrf/libiqrf.mk b/package/libiqrf/libiqrf.mk
>> index f2d5b4c..df4bb42 100644
>> --- a/package/libiqrf/libiqrf.mk
>> +++ b/package/libiqrf/libiqrf.mk
>> @@ -4,11 +4,11 @@
>>  #
>>  ################################################################################
>>
>> -LIBIQRF_VERSION = v0.1.0
>> +LIBIQRF_VERSION = v0.1.2
>>  LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
>>  LIBIQRF_INSTALL_STAGING = YES
>>
>>  LIBIQRF_DEPENDENCIES = libusb
>>
>> -$(eval $(autotools-package))
>> +$(eval $(cmake-package))
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

Marek

--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
Thomas Petazzoni - July 28, 2013, 2:05 p.m.
Dear Marek Belisko,

On Wed,  3 Jul 2013 22:51:20 +0200, Marek Belisko wrote:
> v0.1.2 update build system from autotools to cmake.

Committed, thanks. I had to add a simple patch to the CMakeLists.txt to
avoid CMake needlessly checking for a C++ compiler. It would be good if
this patch could be upstreamed.

Thanks,

Thomas
Belisko Marek - July 28, 2013, 7:38 p.m.
Hi Thomas,

On Sun, Jul 28, 2013 at 4:05 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marek Belisko,
>
> On Wed,  3 Jul 2013 22:51:20 +0200, Marek Belisko wrote:
>> v0.1.2 update build system from autotools to cmake.
>
> Committed, thanks. I had to add a simple patch to the CMakeLists.txt to
> avoid CMake needlessly checking for a C++ compiler. It would be good if
> this patch could be upstreamed.
Thanks. Sure I'll take your patch and add it upstream.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

marek

Patch

diff --git a/package/libiqrf/libiqrf.mk b/package/libiqrf/libiqrf.mk
index f2d5b4c..df4bb42 100644
--- a/package/libiqrf/libiqrf.mk
+++ b/package/libiqrf/libiqrf.mk
@@ -4,11 +4,11 @@ 
 #
 ################################################################################
 
-LIBIQRF_VERSION = v0.1.0
+LIBIQRF_VERSION = v0.1.2
 LIBIQRF_SITE = http://github.com/nandra/libiqrf/tarball/$(LIBIQRF_VERSION)
 LIBIQRF_INSTALL_STAGING = YES
 
 LIBIQRF_DEPENDENCIES = libusb
 
-$(eval $(autotools-package))
+$(eval $(cmake-package))