Patchwork [3/5] tg3: missing break statement in tg3_get_5720_nvram_info()

login
register
mail settings
Submitter Stefan Bader
Date July 3, 2013, 8:24 p.m.
Message ID <1372883088-8397-4-git-send-email-stefan.bader@canonical.com>
Download mbox | patch
Permalink /patch/256739/
State New
Headers show

Comments

Stefan Bader - July 3, 2013, 8:24 p.m.
From: Dan Carpenter <dan.carpenter@oracle.com>

There is a missing break statement so FLASH_5762_EEPROM_HD gets treated
like FLASH_5762_EEPROM_LD.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

BugLink: http://bugs.launchpad.net/bugs/1178899

(cherry-picked from commit 17e1a42f2e377ec5809af79eb651d9ed5958fb97 upstream)
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 drivers/net/ethernet/broadcom/tg3.c |    2 ++
 1 file changed, 2 insertions(+)

Patch

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index dece073..dc4c7780 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -13761,8 +13761,10 @@  static void tg3_get_5720_nvram_info(struct tg3 *tp)
 		switch (nvmpinstrp) {
 		case FLASH_5762_EEPROM_HD:
 			nvmpinstrp = FLASH_5720_EEPROM_HD;
+			break;
 		case FLASH_5762_EEPROM_LD:
 			nvmpinstrp = FLASH_5720_EEPROM_LD;
+			break;
 		}
 	}