From patchwork Wed Jul 3 19:37:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 256731 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-x23f.google.com (mail-vb0-x23f.google.com [IPv6:2607:f8b0:400c:c02::23f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id AB4982C0077 for ; Thu, 4 Jul 2013 05:37:43 +1000 (EST) Received: by mail-vb0-f63.google.com with SMTP id e12sf115925vbg.8 for ; Wed, 03 Jul 2013 12:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:x-beenthere:from:to:cc:subject:date:message-id :x-mailer:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=weY/5Z261Ncbm8jbtevfE+zS4zx2orGBaHcgNwo/mNo=; b=luCBDUD2k5I9QwxDXvxzXf4RMYgM7TcPoZgfhoY+qXgol/P9c4bxpOOz1+/OZs2uZ2 ydh0EG0G0IsNgqcVD62pFe9bJPPwyGiL/zkwqS+94qg0Y9g4lvwOGAox2jPxW5ryMxdt Gs19fTlQ5nketTm9yXL13Q7FvHX1ez/sIuROprR9D/bciaAG+DD8NcAWEha3H/BZ/tHg UUKKu69k+/TlLWsP62ZrIvYJ4E0Eg1GQpMH3ltEjzFO+Bwr8OcTcpl0ONMlVi6I4/YPR xAhSzjZ7skzqQc3bNZoAdDsh0sic99JQRTdhDi+8T2J3ex7+g8Y0THGtqn2PIaFuJNy7 FkvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-beenthere:from:to:cc:subject:date:message-id :x-mailer:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=weY/5Z261Ncbm8jbtevfE+zS4zx2orGBaHcgNwo/mNo=; b=oNBGD4GKWX5X4EQDWdAWKaY0dOrMc6U8/3gWRd3ITi7wXPU3+/1yWROQfTI9JGwm84 WL0cYjob7RZE6DbvabZIr23rRGTM+QMsDaUn1fz+03msWJdcZBY2pITFQqhV8nYg20h9 XilyLKH5AyIWdi+CQHK8ienHL2WK/MF276sxCPkxXmcnIx/OHJ5cAVvCy5Hhie9vUoTq Zwgt3YMYD48W0sLtdLoNu2QgN95yb8J7polIQGffKOhJSim9UgH2Y4uS5Qn7MR2tmjtT oiQUuqkVqcTc9RqsQOZKY+GLNY/vJJPcDOIMjTa8bFmHw8SBJpzr/gvznSznk3VwQao/ IQXw== X-Received: by 10.49.1.112 with SMTP id 16mr73381qel.20.1372880260699; Wed, 03 Jul 2013 12:37:40 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.49.108.74 with SMTP id hi10ls435483qeb.50.gmail; Wed, 03 Jul 2013 12:37:40 -0700 (PDT) X-Received: by 10.236.77.166 with SMTP id d26mr1074270yhe.40.1372880260382; Wed, 03 Jul 2013 12:37:40 -0700 (PDT) Received: from mail-ye0-x235.google.com (mail-ye0-x235.google.com [2607:f8b0:4002:c04::235]) by gmr-mx.google.com with ESMTPS id o24si7729631yhm.1.2013.07.03.12.37.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Jul 2013 12:37:40 -0700 (PDT) Received-SPF: pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4002:c04::235 as permitted sender) client-ip=2607:f8b0:4002:c04::235; Received: by mail-ye0-f181.google.com with SMTP id g12so142428yee.12 for ; Wed, 03 Jul 2013 12:37:40 -0700 (PDT) X-Received: by 10.236.197.72 with SMTP id s48mr996305yhn.183.1372880260181; Wed, 03 Jul 2013 12:37:40 -0700 (PDT) Received: from localhost.localdomain ([187.106.36.171]) by mx.google.com with ESMTPSA id g66sm35379208yhd.11.2013.07.03.12.37.38 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 03 Jul 2013 12:37:39 -0700 (PDT) From: Fabio Estevam To: akpm@linux-foundation.org Cc: a.zummo@towertech.it, shawn.guo@linaro.org, kernel@pengutronix.de, rtc-linux@googlegroups.com, Fabio Estevam Subject: [rtc-linux] [PATCH] rtc: rtc-stmp3xxx: Check the return value from stmp_reset_block() Date: Wed, 3 Jul 2013 16:37:32 -0300 Message-Id: <1372880252-23269-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 X-Original-Sender: festevam@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of festevam@gmail.com designates 2607:f8b0:4002:c04::235 as permitted sender) smtp.mail=festevam@gmail.com; dkim=pass header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , From: Fabio Estevam stmp_reset_block() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Acked-by: Shawn Guo --- drivers/rtc/rtc-stmp3xxx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index 90a3e86..767fee2 100644 --- a/drivers/rtc/rtc-stmp3xxx.c +++ b/drivers/rtc/rtc-stmp3xxx.c @@ -261,7 +261,12 @@ static int stmp3xxx_rtc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rtc_data); - stmp_reset_block(rtc_data->io); + err = stmp_reset_block(rtc_data->io); + if (err) { + dev_err(&pdev->dev, "stmp_reset_block failed: %d\n", err); + return err; + } + writel(STMP3XXX_RTC_PERSISTENT0_ALARM_EN | STMP3XXX_RTC_PERSISTENT0_ALARM_WAKE_EN | STMP3XXX_RTC_PERSISTENT0_ALARM_WAKE,