From patchwork Tue Jul 2 23:01:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 256522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ve0-x23a.google.com (mail-ve0-x23a.google.com [IPv6:2607:f8b0:400c:c01::23a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 182342C0095 for ; Wed, 3 Jul 2013 09:01:55 +1000 (EST) Received: by mail-ve0-f186.google.com with SMTP id jw11sf2196500veb.3 for ; Tue, 02 Jul 2013 16:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-beenthere:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=pMc0Z9YcNi8CF3FVDuJo3pkHKn21SNuuMAW/M/TnDbE=; b=U+6+s7Fy2kd4L55OO+7nZui9glRJqlwMScYbScLsAR+5qSlvC+T2REAluD2WmSC0Xv /PIZw3WORdLhZ6PK5i/hSbnpx+ARfzSw8AV3zarpa3wOXljarQOe37sGdVK1EE4YRmGI UhkWIzAULA6YmmUIA1KgrE5Vmydjz8R98n7GnipV8UZbu5LjS0/myoFOEjtAqGnxcnIm i9n0Ipw8KR9zYzYYIMYS49+Di6V2OhwX92XqGWyUiG6JyH/BMuAAoXjb0yqoLI+fgoEk 9GZsXBo2StimL6QvipLRCRbNqSYpIFWLQ3tmDo/CpPs+9AOJDUNqfDFmnxbxOs3z8YQ2 crnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=x-beenthere:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=pMc0Z9YcNi8CF3FVDuJo3pkHKn21SNuuMAW/M/TnDbE=; b=FDajRhX/g8ZdlxuwBQQ9NAQ7VMxihPq3DYJfl+Fuf1mpc95pSjIn18iZln6N3BcPi8 XCA4MXxw/ynz9yd6Hkq726AMjpGgP/BOzIkpNEUCnsi+CRPbxVPU+ZnXopbB+eDVzech +UUXucimuAsPmW5GxL9kq2vYTGXM1DiYRY6qw= X-Received: by 10.50.13.105 with SMTP id g9mr1182446igc.9.1372806112855; Tue, 02 Jul 2013 16:01:52 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.73.229 with SMTP id o5ls961907igv.43.canary; Tue, 02 Jul 2013 16:01:52 -0700 (PDT) X-Received: by 10.66.225.239 with SMTP id rn15mr8174296pac.36.1372806112175; Tue, 02 Jul 2013 16:01:52 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTP id cw1si2640711pbb.0.2013.07.02.16.01.52 for ; Tue, 02 Jul 2013 16:01:52 -0700 (PDT) Received-SPF: pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Received: from akpm3.mtv.corp.google.com (unknown [216.239.45.95]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CAE108B6; Tue, 2 Jul 2013 23:01:51 +0000 (UTC) Date: Tue, 2 Jul 2013 16:01:50 -0700 From: Andrew Morton To: rtc-linux@googlegroups.com Cc: Renaud Cerrato , a.zummo@towertech.it Subject: Re: [rtc-linux] [PATCH] rtc: add NXP PCF2127 support (i2c) Message-Id: <20130702160150.8780d314e2f74e4cb477760d@linux-foundation.org> In-Reply-To: <1371731788-1440-1-git-send-email-r.cerrato@til-technologies.fr> References: <1371731788-1440-1-git-send-email-r.cerrato@til-technologies.fr> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Original-Sender: akpm@linux-foundation.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mail=akpm@linux-foundation.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , On Thu, 20 Jun 2013 14:36:28 +0200 Renaud Cerrato wrote: > Added support for NXP PCF2127 RTC (i2c). Little fixes: From: Andrew Morton Subject: rtc-add-nxp-pcf2127-support-i2c-fix fix typo, fix warnings Cc: Jingoo Han Cc: Renaud Cerrato Signed-off-by: Andrew Morton --- drivers/rtc/rtc-pcf2127.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN drivers/rtc/Kconfig~rtc-add-nxp-pcf2127-support-i2c-fix drivers/rtc/Kconfig diff -puN drivers/rtc/Makefile~rtc-add-nxp-pcf2127-support-i2c-fix drivers/rtc/Makefile diff -puN drivers/rtc/rtc-pcf2127.c~rtc-add-nxp-pcf2127-support-i2c-fix drivers/rtc/rtc-pcf2127.c --- a/drivers/rtc/rtc-pcf2127.c~rtc-add-nxp-pcf2127-support-i2c-fix +++ a/drivers/rtc/rtc-pcf2127.c @@ -37,7 +37,7 @@ static struct i2c_driver pcf2127_driver; struct pcf2127 { struct rtc_device *rtc; - int voltage_low; /* incicates if a low_voltage was detected */ + int voltage_low; /* indicates if a low_voltage was detected */ }; /* @@ -99,7 +99,6 @@ static int pcf2127_get_datetime(struct i static int pcf2127_set_datetime(struct i2c_client *client, struct rtc_time *tm) { - struct pcf2127 *pcf2127 = i2c_get_clientdata(client); unsigned char buf[8]; int i = 0, err; @@ -141,7 +140,6 @@ static int pcf2127_rtc_ioctl(struct devi unsigned int cmd, unsigned long arg) { struct pcf2127 *pcf2127 = i2c_get_clientdata(to_i2c_client(dev)); - struct rtc_time tm; switch (cmd) { case RTC_VL_READ: