Patchwork [U-Boot,PATCHv2] socfpga: Move board/socfpga_cyclone5 to board/socfpga

login
register
mail settings
Submitter dinguyen@altera.com
Date July 2, 2013, 10 p.m.
Message ID <1372802418-9010-1-git-send-email-dinguyen@altera.com>
Download mbox | patch
Permalink /patch/256518/
State Accepted
Delegated to: Albert ARIBAUD
Headers show

Comments

dinguyen@altera.com - July 2, 2013, 10 p.m.
From: Dinh Nguyen <dinguyen@altera.com>

Because the SOCFPGA platform will include support for Cyclone V and
Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
be more generic.

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Reviewed-by: Pavel Machek <pavel@denx.de>
Cc: Chin Liang See <clsee@altera.com>
Cc: Wolfgang Denk <wd@denx.de>
CC: Pavel Machek <pavel@denx.de>
Cc: Tom Rini <trini@ti.com>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---
 .../altera/{socfpga_cyclone5 => socfpga}/Makefile  |    0
 .../socfpga_cyclone5.c                             |    0
 boards.cfg                                         |    2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename board/altera/{socfpga_cyclone5 => socfpga}/Makefile (100%)
 rename board/altera/{socfpga_cyclone5 => socfpga}/socfpga_cyclone5.c (100%)
Albert ARIBAUD - July 5, 2013, 9:04 p.m.
Hi dinguyen@altera.com,

On Tue, 2 Jul 2013 17:00:18 -0500, <dinguyen@altera.com> wrote:

> From: Dinh Nguyen <dinguyen@altera.com>
> 
> Because the SOCFPGA platform will include support for Cyclone V and
> Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> be more generic.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Reviewed-by: Pavel Machek <pavel@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Wolfgang Denk <wd@denx.de>
> CC: Pavel Machek <pavel@denx.de>
> Cc: Tom Rini <trini@ti.com>
> 
> v2:
> - Add Reviewed-by: Pavel Machek
> - Cc: Tom Rini
> ---

Do you really mean that V2 is the exact same code as V1? If it is, then
V2 is unneeded. And if V2 is different from V1, then history should
tells us the difference(s).

Amicalement,
dinguyen@altera.com - July 8, 2013, 4:10 p.m.
Hi Albert,

On Fri, 2013-07-05 at 23:04 +0200, ZY - albert.u.boot wrote:
> Hi dinguyen@altera.com,
> 
> On Tue, 2 Jul 2013 17:00:18 -0500, <dinguyen@altera.com> wrote:
> 
> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > Because the SOCFPGA platform will include support for Cyclone V and
> > Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> > be more generic.
> > 
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Reviewed-by: Pavel Machek <pavel@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Wolfgang Denk <wd@denx.de>
> > CC: Pavel Machek <pavel@denx.de>
> > Cc: Tom Rini <trini@ti.com>
> > 
> > v2:
> > - Add Reviewed-by: Pavel Machek
> > - Cc: Tom Rini
> > ---
> 
> Do you really mean that V2 is the exact same code as V1? If it is, then
> V2 is unneeded. And if V2 is different from V1, then history should
> tells us the difference(s).

V2 is the same as v1 codewise. So should I resend this a V1 to be
applied?

Dinh
> 
> Amicalement,
Albert ARIBAUD - July 8, 2013, 8:01 p.m.
Hi Dinh,

On Mon, 8 Jul 2013 11:10:37 -0500, Dinh Nguyen <dinguyen@altera.com>
wrote:

> Hi Albert,
> 
> On Fri, 2013-07-05 at 23:04 +0200, ZY - albert.u.boot wrote:
> > Hi dinguyen@altera.com,
> > 
> > On Tue, 2 Jul 2013 17:00:18 -0500, <dinguyen@altera.com> wrote:
> > 
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > > 
> > > Because the SOCFPGA platform will include support for Cyclone V and
> > > Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> > > be more generic.
> > > 
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Reviewed-by: Pavel Machek <pavel@denx.de>
> > > Cc: Chin Liang See <clsee@altera.com>
> > > Cc: Wolfgang Denk <wd@denx.de>
> > > CC: Pavel Machek <pavel@denx.de>
> > > Cc: Tom Rini <trini@ti.com>
> > > 
> > > v2:
> > > - Add Reviewed-by: Pavel Machek
> > > - Cc: Tom Rini
> > > ---
> > 
> > Do you really mean that V2 is the exact same code as V1? If it is, then
> > V2 is unneeded. And if V2 is different from V1, then history should
> > tells us the difference(s).
> 
> V2 is the same as v1 codewise. So should I resend this a V1 to be
> applied?

If V1 is the same as V2 as far as the code is concerned, then there is
simply no point in sending V2 or resending V1 again.

The V2 history makes me guess you thought it necessary to officialize
Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care
of collecting all the {Reviewed,Acked,Tested,...}-by's and providing
them when applying the patch through pwclient.

> Dinh

Amicalement,
Pavel Machek - July 8, 2013, 11:22 p.m.
Hi!

> > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > 
> > > > Because the SOCFPGA platform will include support for Cyclone V and
> > > > Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> > > > be more generic.
> > > > 
> > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > Reviewed-by: Pavel Machek <pavel@denx.de>
> > > > Cc: Chin Liang See <clsee@altera.com>
> > > > Cc: Wolfgang Denk <wd@denx.de>
> > > > CC: Pavel Machek <pavel@denx.de>
> > > > Cc: Tom Rini <trini@ti.com>
> > > > 
> > > > v2:
> > > > - Add Reviewed-by: Pavel Machek
> > > > - Cc: Tom Rini
> > > > ---
> > > 
> > > Do you really mean that V2 is the exact same code as V1? If it is, then
> > > V2 is unneeded. And if V2 is different from V1, then history should
> > > tells us the difference(s).
> > 
> > V2 is the same as v1 codewise. So should I resend this a V1 to be
> > applied?
> 
> If V1 is the same as V2 as far as the code is concerned, then there is
> simply no point in sending V2 or resending V1 again.
> 
> The V2 history makes me guess you thought it necessary to officialize
> Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care
> of collecting all the {Reviewed,Acked,Tested,...}-by's and providing
> them when applying the patch through pwclient.

This got pretty confusing lately. Can we just wait for the patches to
be applied, or do we need to take some action?

Thanks,
									Pavel
Albert ARIBAUD - July 9, 2013, 8:57 a.m.
Hi Pavel,

On Tue, 9 Jul 2013 01:22:01 +0200, Pavel Machek <pavel@denx.de> wrote:

> Hi!
> 
> > > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > > 
> > > > > Because the SOCFPGA platform will include support for Cyclone V and
> > > > > Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> > > > > be more generic.
> > > > > 
> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > > Reviewed-by: Pavel Machek <pavel@denx.de>
> > > > > Cc: Chin Liang See <clsee@altera.com>
> > > > > Cc: Wolfgang Denk <wd@denx.de>
> > > > > CC: Pavel Machek <pavel@denx.de>
> > > > > Cc: Tom Rini <trini@ti.com>
> > > > > 
> > > > > v2:
> > > > > - Add Reviewed-by: Pavel Machek
> > > > > - Cc: Tom Rini
> > > > > ---
> > > > 
> > > > Do you really mean that V2 is the exact same code as V1? If it is, then
> > > > V2 is unneeded. And if V2 is different from V1, then history should
> > > > tells us the difference(s).
> > > 
> > > V2 is the same as v1 codewise. So should I resend this a V1 to be
> > > applied?
> > 
> > If V1 is the same as V2 as far as the code is concerned, then there is
> > simply no point in sending V2 or resending V1 again.
> > 
> > The V2 history makes me guess you thought it necessary to officialize
> > Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care
> > of collecting all the {Reviewed,Acked,Tested,...}-by's and providing
> > them when applying the patch through pwclient.
> 
> This got pretty confusing lately. Can we just wait for the patches to
> be applied, or do we need to take some action?

No, no need to take action; I was just clarifying why V2 was unneeded
here, so that similar uneeded new versions are avoided in the future.

Since V1 has already been marked as superseded, I'll apply V2 -- after
2013.07 is out.

> Thanks,
> 									Pavel

Amicalement,
Albert ARIBAUD - July 25, 2013, 8:56 a.m.
Hi dinguyen@altera.com,

On Tue, 2 Jul 2013 17:00:18 -0500, <dinguyen@altera.com> wrote:

> From: Dinh Nguyen <dinguyen@altera.com>
> 
> Because the SOCFPGA platform will include support for Cyclone V and
> Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to
> be more generic.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Reviewed-by: Pavel Machek <pavel@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Wolfgang Denk <wd@denx.de>
> CC: Pavel Machek <pavel@denx.de>
> Cc: Tom Rini <trini@ti.com>
> 
> v2:
> - Add Reviewed-by: Pavel Machek
> - Cc: Tom Rini
> ---
>  .../altera/{socfpga_cyclone5 => socfpga}/Makefile  |    0
>  .../socfpga_cyclone5.c                             |    0
>  boards.cfg                                         |    2 +-
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename board/altera/{socfpga_cyclone5 => socfpga}/Makefile (100%)
>  rename board/altera/{socfpga_cyclone5 => socfpga}/socfpga_cyclone5.c (100%)
> 
> diff --git a/board/altera/socfpga_cyclone5/Makefile b/board/altera/socfpga/Makefile
> similarity index 100%
> rename from board/altera/socfpga_cyclone5/Makefile
> rename to board/altera/socfpga/Makefile
> diff --git a/board/altera/socfpga_cyclone5/socfpga_cyclone5.c b/board/altera/socfpga/socfpga_cyclone5.c
> similarity index 100%
> rename from board/altera/socfpga_cyclone5/socfpga_cyclone5.c
> rename to board/altera/socfpga/socfpga_cyclone5.c
> diff --git a/boards.cfg b/boards.cfg
> index c0c4282..eea92d5 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -335,7 +335,7 @@ kzm9g                        arm         armv7       kzm9g               kmc
>  armadillo-800eva             arm         armv7       armadillo-800eva    atmark-techno  rmobile
>  zynq                         arm         armv7       zynq                xilinx         zynq
>  zynq_dcc                     arm         armv7       zynq                xilinx         zynq        zynq:ZYNQ_DCC
> -socfpga_cyclone5                arm         armv7          socfpga_cyclone5    altera		    socfpga
> +socfpga_cyclone5                arm         armv7          socfpga    altera		    socfpga
>  actux1_4_16                  arm         ixp         actux1              -              -           actux1:FLASH2X2
>  actux1_4_32                  arm         ixp         actux1              -              -           actux1:FLASH2X2,RAM_32MB
>  actux1_8_16                  arm         ixp         actux1              -              -           actux1:FLASH1X8

Applied to u-boot-arm/master, thanks!

Amicalement,

Patch

diff --git a/board/altera/socfpga_cyclone5/Makefile b/board/altera/socfpga/Makefile
similarity index 100%
rename from board/altera/socfpga_cyclone5/Makefile
rename to board/altera/socfpga/Makefile
diff --git a/board/altera/socfpga_cyclone5/socfpga_cyclone5.c b/board/altera/socfpga/socfpga_cyclone5.c
similarity index 100%
rename from board/altera/socfpga_cyclone5/socfpga_cyclone5.c
rename to board/altera/socfpga/socfpga_cyclone5.c
diff --git a/boards.cfg b/boards.cfg
index c0c4282..eea92d5 100644
--- a/boards.cfg
+++ b/boards.cfg
@@ -335,7 +335,7 @@  kzm9g                        arm         armv7       kzm9g               kmc
 armadillo-800eva             arm         armv7       armadillo-800eva    atmark-techno  rmobile
 zynq                         arm         armv7       zynq                xilinx         zynq
 zynq_dcc                     arm         armv7       zynq                xilinx         zynq        zynq:ZYNQ_DCC
-socfpga_cyclone5                arm         armv7          socfpga_cyclone5    altera		    socfpga
+socfpga_cyclone5                arm         armv7          socfpga    altera		    socfpga
 actux1_4_16                  arm         ixp         actux1              -              -           actux1:FLASH2X2
 actux1_4_32                  arm         ixp         actux1              -              -           actux1:FLASH2X2,RAM_32MB
 actux1_8_16                  arm         ixp         actux1              -              -           actux1:FLASH1X8