From patchwork Mon Apr 6 15:02:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 25642 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id D17E9DDEDA for ; Tue, 7 Apr 2009 01:04:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751879AbZDFPEY (ORCPT ); Mon, 6 Apr 2009 11:04:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751794AbZDFPEX (ORCPT ); Mon, 6 Apr 2009 11:04:23 -0400 Received: from smtp.nokia.com ([192.100.122.230]:43726 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780AbZDFPEX (ORCPT ); Mon, 6 Apr 2009 11:04:23 -0400 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx03.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n36F3wNr024258; Mon, 6 Apr 2009 18:04:17 +0300 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 6 Apr 2009 18:02:49 +0300 Received: from mgw-int02.ntc.nokia.com ([172.21.143.97]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Mon, 6 Apr 2009 18:02:49 +0300 Received: from localhost.localdomain (esdhcp043152.research.nokia.com [172.21.43.152]) by mgw-int02.ntc.nokia.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id n36F2lTM016533; Mon, 6 Apr 2009 18:02:48 +0300 From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= To: netdev@vger.kernel.org Cc: linux-usb@vger.kernel.org Subject: [PATCH 1/4] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback Date: Mon, 6 Apr 2009 18:02:54 +0300 Message-Id: <1239030177-28783-1-git-send-email-remi.denis-courmont@nokia.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <200904061758.58057.remi.denis-courmont@nokia.com> References: <200904061758.58057.remi.denis-courmont@nokia.com> MIME-Version: 1.0 X-OriginalArrivalTime: 06 Apr 2009 15:02:49.0411 (UTC) FILETIME=[C061A930:01C9B6C8] X-Nokia-AV: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rémi Denis-Courmont Network device TX is never run in IRQ context, and skb is freed outside of the IRQ-disabling spin lock. So checking for IRQ was a waste of time here. Signed-off-by: Rémi Denis-Courmont --- drivers/usb/gadget/f_phonet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c index c1abeb8..54451ee 100644 --- a/drivers/usb/gadget/f_phonet.c +++ b/drivers/usb/gadget/f_phonet.c @@ -255,7 +255,7 @@ out_unlock: spin_unlock_irqrestore(&port->lock, flags); out: if (unlikely(skb)) { - dev_kfree_skb_any(skb); + dev_kfree_skb(skb); dev->stats.tx_dropped++; } return 0;