Patchwork [U-Boot] CONFIG: EXYNOS5: Replace misnomer SMDK5250 with EXYNOS5250 and update Makefiles

login
register
mail settings
Submitter Inderpal Singh
Date July 2, 2013, 4:17 a.m.
Message ID <1372738648-21028-1-git-send-email-inderpal.singh@linaro.org>
Download mbox | patch
Permalink /patch/256264/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Inderpal Singh - July 2, 2013, 4:17 a.m.
Update the Makefiles so that all boards can use the same spl generation tool

Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
This is needed for the Arndale board support patch just sent
after sending this one.

 Makefile                        |    2 +-
 include/configs/exynos5250-dt.h |    2 +-
 tools/Makefile                  |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)
Simon Glass - July 2, 2013, 7:40 a.m.
On Tue, Jul 2, 2013 at 1:17 PM, Inderpal Singh <inderpal.singh@linaro.org>wrote:

> Update the Makefiles so that all boards can use the same spl generation
> tool
>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
>

Acked-by: Simon Glass <sjg@chromium.org>


> ---
> This is needed for the Arndale board support patch just sent
> after sending this one.
>
>  Makefile                        |    2 +-
>  include/configs/exynos5250-dt.h |    2 +-
>  tools/Makefile                  |    4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index af4c3c0..d8c5d3f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -821,7 +821,7 @@ clean:
>                $(obj)tools/gdb/{astest,gdbcont,gdbsend}                   \
>                $(obj)tools/gen_eth_addr    $(obj)tools/img2srec           \
>                $(obj)tools/mk{env,}image   $(obj)tools/mpc86x_clk         \
> -              $(obj)tools/mk{smdk5250,}spl                               \
> +              $(obj)tools/mk{$(BOARD),}spl                               \
>                $(obj)tools/mxsboot                                        \
>                $(obj)tools/ncb             $(obj)tools/ubsha1             \
>                $(obj)tools/kernel-doc/docproc
> diff --git a/include/configs/exynos5250-dt.h
> b/include/configs/exynos5250-dt.h
> index 1c9eca2..a782880 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -29,7 +29,7 @@
>  #define CONFIG_SAMSUNG                 /* in a SAMSUNG core */
>  #define CONFIG_S5P                     /* S5P Family */
>  #define CONFIG_EXYNOS5                 /* which is in a Exynos5 Family */
> -#define CONFIG_SMDK5250                        /* which is in a SMDK5250
> */
> +#define CONFIG_EXYNOS5250
>
>  #include <asm/arch/cpu.h>              /* get chip and board defs */
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 4630f03..5eb14c5 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -68,7 +68,7 @@ BIN_FILES-$(CONFIG_CMD_LOADS) += img2srec$(SFX)
>  BIN_FILES-$(CONFIG_XWAY_SWAP_BYTES) += xway-swap-bytes$(SFX)
>  BIN_FILES-y += mkenvimage$(SFX)
>  BIN_FILES-y += mkimage$(SFX)
> -BIN_FILES-$(CONFIG_SMDK5250) += mksmdk5250spl$(SFX)
> +BIN_FILES-$(CONFIG_EXYNOS5250) += mk$(BOARD)spl$(SFX)
>  BIN_FILES-$(CONFIG_MX23) += mxsboot$(SFX)
>  BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
>  BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
> @@ -100,7 +100,7 @@ NOPED_OBJ_FILES-y += image-host.o
>  NOPED_OBJ_FILES-y += omapimage.o
>  NOPED_OBJ_FILES-y += mkenvimage.o
>  NOPED_OBJ_FILES-y += mkimage.o
> -OBJ_FILES-$(CONFIG_SMDK5250) += mkexynosspl.o
> +OBJ_FILES-$(CONFIG_EXYNOS5250) += mkexynosspl.o
>  OBJ_FILES-$(CONFIG_MX23) += mxsboot.o
>  OBJ_FILES-$(CONFIG_MX28) += mxsboot.o
>  OBJ_FILES-$(CONFIG_NETCONSOLE) += ncb.o
> --
> 1.7.9.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Inderpal Singh - July 25, 2013, 6:51 a.m.
Adding Minkyu,


On 2 July 2013 13:10, Simon Glass <sjg@chromium.org> wrote:

>
> On Tue, Jul 2, 2013 at 1:17 PM, Inderpal Singh <inderpal.singh@linaro.org>wrote:
>
>> Update the Makefiles so that all boards can use the same spl generation
>> tool
>>
>> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
>>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>

Can it be merged ? Let me know if there is any issue.

Thanks,
inder



>
>
>> ---
>> This is needed for the Arndale board support patch just sent
>> after sending this one.
>>
>>  Makefile                        |    2 +-
>>  include/configs/exynos5250-dt.h |    2 +-
>>  tools/Makefile                  |    4 ++--
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index af4c3c0..d8c5d3f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -821,7 +821,7 @@ clean:
>>                $(obj)tools/gdb/{astest,gdbcont,gdbsend}
>> \
>>                $(obj)tools/gen_eth_addr    $(obj)tools/img2srec
>> \
>>                $(obj)tools/mk{env,}image   $(obj)tools/mpc86x_clk
>> \
>> -              $(obj)tools/mk{smdk5250,}spl
>> \
>> +              $(obj)tools/mk{$(BOARD),}spl
>> \
>>                $(obj)tools/mxsboot
>>  \
>>                $(obj)tools/ncb             $(obj)tools/ubsha1
>> \
>>                $(obj)tools/kernel-doc/docproc
>> diff --git a/include/configs/exynos5250-dt.h
>> b/include/configs/exynos5250-dt.h
>> index 1c9eca2..a782880 100644
>> --- a/include/configs/exynos5250-dt.h
>> +++ b/include/configs/exynos5250-dt.h
>> @@ -29,7 +29,7 @@
>>  #define CONFIG_SAMSUNG                 /* in a SAMSUNG core */
>>  #define CONFIG_S5P                     /* S5P Family */
>>  #define CONFIG_EXYNOS5                 /* which is in a Exynos5 Family */
>> -#define CONFIG_SMDK5250                        /* which is in a SMDK5250
>> */
>> +#define CONFIG_EXYNOS5250
>>
>>  #include <asm/arch/cpu.h>              /* get chip and board defs */
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 4630f03..5eb14c5 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -68,7 +68,7 @@ BIN_FILES-$(CONFIG_CMD_LOADS) += img2srec$(SFX)
>>  BIN_FILES-$(CONFIG_XWAY_SWAP_BYTES) += xway-swap-bytes$(SFX)
>>  BIN_FILES-y += mkenvimage$(SFX)
>>  BIN_FILES-y += mkimage$(SFX)
>> -BIN_FILES-$(CONFIG_SMDK5250) += mksmdk5250spl$(SFX)
>> +BIN_FILES-$(CONFIG_EXYNOS5250) += mk$(BOARD)spl$(SFX)
>>  BIN_FILES-$(CONFIG_MX23) += mxsboot$(SFX)
>>  BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
>>  BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
>> @@ -100,7 +100,7 @@ NOPED_OBJ_FILES-y += image-host.o
>>  NOPED_OBJ_FILES-y += omapimage.o
>>  NOPED_OBJ_FILES-y += mkenvimage.o
>>  NOPED_OBJ_FILES-y += mkimage.o
>> -OBJ_FILES-$(CONFIG_SMDK5250) += mkexynosspl.o
>> +OBJ_FILES-$(CONFIG_EXYNOS5250) += mkexynosspl.o
>>  OBJ_FILES-$(CONFIG_MX23) += mxsboot.o
>>  OBJ_FILES-$(CONFIG_MX28) += mxsboot.o
>>  OBJ_FILES-$(CONFIG_NETCONSOLE) += ncb.o
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
>

Patch

diff --git a/Makefile b/Makefile
index af4c3c0..d8c5d3f 100644
--- a/Makefile
+++ b/Makefile
@@ -821,7 +821,7 @@  clean:
 	       $(obj)tools/gdb/{astest,gdbcont,gdbsend}			  \
 	       $(obj)tools/gen_eth_addr    $(obj)tools/img2srec		  \
 	       $(obj)tools/mk{env,}image   $(obj)tools/mpc86x_clk	  \
-	       $(obj)tools/mk{smdk5250,}spl				  \
+	       $(obj)tools/mk{$(BOARD),}spl				  \
 	       $(obj)tools/mxsboot					  \
 	       $(obj)tools/ncb		   $(obj)tools/ubsha1		  \
 	       $(obj)tools/kernel-doc/docproc
diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 1c9eca2..a782880 100644
--- a/include/configs/exynos5250-dt.h
+++ b/include/configs/exynos5250-dt.h
@@ -29,7 +29,7 @@ 
 #define CONFIG_SAMSUNG			/* in a SAMSUNG core */
 #define CONFIG_S5P			/* S5P Family */
 #define CONFIG_EXYNOS5			/* which is in a Exynos5 Family */
-#define CONFIG_SMDK5250			/* which is in a SMDK5250 */
+#define CONFIG_EXYNOS5250
 
 #include <asm/arch/cpu.h>		/* get chip and board defs */
 
diff --git a/tools/Makefile b/tools/Makefile
index 4630f03..5eb14c5 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -68,7 +68,7 @@  BIN_FILES-$(CONFIG_CMD_LOADS) += img2srec$(SFX)
 BIN_FILES-$(CONFIG_XWAY_SWAP_BYTES) += xway-swap-bytes$(SFX)
 BIN_FILES-y += mkenvimage$(SFX)
 BIN_FILES-y += mkimage$(SFX)
-BIN_FILES-$(CONFIG_SMDK5250) += mksmdk5250spl$(SFX)
+BIN_FILES-$(CONFIG_EXYNOS5250) += mk$(BOARD)spl$(SFX)
 BIN_FILES-$(CONFIG_MX23) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX)
 BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX)
@@ -100,7 +100,7 @@  NOPED_OBJ_FILES-y += image-host.o
 NOPED_OBJ_FILES-y += omapimage.o
 NOPED_OBJ_FILES-y += mkenvimage.o
 NOPED_OBJ_FILES-y += mkimage.o
-OBJ_FILES-$(CONFIG_SMDK5250) += mkexynosspl.o
+OBJ_FILES-$(CONFIG_EXYNOS5250) += mkexynosspl.o
 OBJ_FILES-$(CONFIG_MX23) += mxsboot.o
 OBJ_FILES-$(CONFIG_MX28) += mxsboot.o
 OBJ_FILES-$(CONFIG_NETCONSOLE) += ncb.o