Patchwork [GIT,PULL] Initial OLPC XO-1.75/XO-4 support

login
register
mail settings
Submitter Daniel Drake
Date July 2, 2013, 3:12 a.m.
Message ID <20130702031244.B2D74FAAD2@dev.laptop.org>
Download mbox
Permalink /patch/256260/
State New
Headers show

Pull-request

git://dev.laptop.org/users/dsd/linux-olpc arm-xo-boot

Comments

Daniel Drake - July 2, 2013, 3:12 a.m.
Hi,

These patches add support for booting OLPC XO-1.75 (Marvell MMP2) and OLPC
XO-4 (Marvell MMP3) which present device trees from OpenFirmware.

With the exception of the most recent patch, which has been acked (I think),
the other patches were posted about 2 weeks ago and haven't received
any comments from the MMP arch maintainers.

Please consider for the next available merge window (not sure if we're
now too late for 3.11, no big deal if so).

The following changes since commit 8bb495e3f02401ee6f76d1b1d77f3ac9f079e376:

  Linux 3.10 (2013-06-30 15:13:29 -0700)

are available in the git repository at:

  git://dev.laptop.org/users/dsd/linux-olpc arm-xo-boot

for you to fetch changes up to 99ba42c6d18a81935fcc40b604bbcccc1a04d0c5:

  mmp: irq: Don't clear unused interrupt enable bits (2013-07-01 20:54:12 -0600)

----------------------------------------------------------------
Chris Ball (1):
      ARM: mmp: Add compatible entries for OLPC XO laptops

Daniel Drake (4):
      clk: mmp: use global clock lock
      clk: mmp: add support for DT-defined clocks
      ARM: mmp: initialize l2x0 cache on MMP3
      mmp: irq: Don't clear unused interrupt enable bits

Mitch Bradley (1):
      ARM: mmp: irq: Improve DT layout

 .../devicetree/bindings/arm/mrvl/intc.txt          |  43 ++++---
 .../devicetree/bindings/arm/mrvl/mrvl.txt          |   8 ++
 .../devicetree/bindings/clock/mmp-apbc.txt         |  30 +++++
 .../devicetree/bindings/clock/mmp-apmu.txt         |  30 +++++
 arch/arm/Kconfig                                   |   5 +-
 arch/arm/boot/dts/mmp2.dtsi                        | 128 +++++++++----------
 arch/arm/mach-mmp/Kconfig                          |   5 +-
 arch/arm/mach-mmp/irq.c                            |  19 +--
 arch/arm/mach-mmp/mmp2-dt.c                        |   2 +
 arch/arm/mach-mmp/mmp2.c                           |   6 +
 drivers/clk/mmp/Makefile                           |   2 +-
 drivers/clk/mmp/clk-apbc.c                         | 104 +++++++++++-----
 drivers/clk/mmp/clk-apmu.c                         |  57 ++++++---
 drivers/clk/mmp/clk-mmp2.c                         | 135 ++++++++++++---------
 drivers/clk/mmp/clk.h                              |   8 +-
 drivers/clk/mmp/common.c                           |  13 ++
 16 files changed, 391 insertions(+), 204 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/mmp-apbc.txt
 create mode 100644 Documentation/devicetree/bindings/clock/mmp-apmu.txt
 create mode 100644 drivers/clk/mmp/common.c
Olof Johansson - July 2, 2013, 4:53 a.m.
On Mon, Jul 01, 2013 at 11:12:44PM -0400, Daniel Drake wrote:
> Hi,
> 
> These patches add support for booting OLPC XO-1.75 (Marvell MMP2) and OLPC
> XO-4 (Marvell MMP3) which present device trees from OpenFirmware.
> 
> With the exception of the most recent patch, which has been acked (I think),
> the other patches were posted about 2 weeks ago and haven't received
> any comments from the MMP arch maintainers.
> 
> Please consider for the next available merge window (not sure if we're
> now too late for 3.11, no big deal if so).

Daniel,

Unfortunately too late for 3.11 indeed, so this is 3.12 material at this point.
Given that the merge window just opened, most maintainers will be too busy to
look at much new patches at this time as well.

Can I ask you to do a few things though?

1) Please post the drivers/clk patches to mturquette. THey don't look dependent
   on the rest of the patches, just general improvements and cleanups.
2) I really wish there was a generic catch-all compat for the boards, so we
   didn't have to modify mmp2-dt.c for every new board added -- it really
   defies the purpose of only changing the data you pass into the kernel. This
   is mostly something for Eric/Haojian to sort out though.
3) Please post the patches as a series instead of a pull request, given that
   they should probably take different paths up the tree (clk vs the platform,
   etc). You should at least get review/acked-by of the clk pieces from Mike
   Turquette.

Beyond that I didn't look all that closely at the patches yet.


-Olof
Daniel Drake - July 2, 2013, 2:26 p.m.
On Mon, Jul 1, 2013 at 10:53 PM, Olof Johansson <olof@lixom.net> wrote:
> 1) Please post the drivers/clk patches to mturquette. THey don't look dependent
>    on the rest of the patches, just general improvements and cleanups.
> 2) I really wish there was a generic catch-all compat for the boards, so we
>    didn't have to modify mmp2-dt.c for every new board added -- it really
>    defies the purpose of only changing the data you pass into the kernel. This
>    is mostly something for Eric/Haojian to sort out though.
> 3) Please post the patches as a series instead of a pull request, given that
>    they should probably take different paths up the tree (clk vs the platform,
>    etc). You should at least get review/acked-by of the clk pieces from Mike
>    Turquette.

Thanks for the suggestions. I have already posted the patches as
emails a little more than 2 weeks ago, including sending the clock
ones to Mike. I will resend next week if they are still pending, when
the maintainers might be a bit less busy.

cheers
Daniel
Mike Turquette - July 2, 2013, 4:35 p.m.
Quoting Daniel Drake (2013-07-02 07:26:22)
> On Mon, Jul 1, 2013 at 10:53 PM, Olof Johansson <olof@lixom.net> wrote:
> > 1) Please post the drivers/clk patches to mturquette. THey don't look dependent
> >    on the rest of the patches, just general improvements and cleanups.
> > 2) I really wish there was a generic catch-all compat for the boards, so we
> >    didn't have to modify mmp2-dt.c for every new board added -- it really
> >    defies the purpose of only changing the data you pass into the kernel. This
> >    is mostly something for Eric/Haojian to sort out though.
> > 3) Please post the patches as a series instead of a pull request, given that
> >    they should probably take different paths up the tree (clk vs the platform,
> >    etc). You should at least get review/acked-by of the clk pieces from Mike
> >    Turquette.
> 
> Thanks for the suggestions. I have already posted the patches as
> emails a little more than 2 weeks ago, including sending the clock
> ones to Mike. I will resend next week if they are still pending, when
> the maintainers might be a bit less busy.

I saw the MMP patches but they were too late for me to take into
clk-next towards 3.11. When this happens I usually email the patch
author privately and let them know that I will take a look after the
merge window but I forgot to send you that email.

Regards,
Mike

> 
> cheers
> Daniel