Patchwork [-next] spi: tegra114: remove redundant dev_err call in tegra_spi_probe()

login
register
mail settings
Submitter Wei Yongjun
Date July 2, 2013, 12:37 a.m.
Message ID <CAPgLHd9XEH68ZnG2ou0K+EHn-ZWH7Ax_cmJOMBHjFcHgVscLDg@mail.gmail.com>
Download mbox | patch
Permalink /patch/256254/
State Not Applicable, archived
Headers show

Comments

Wei Yongjun - July 2, 2013, 12:37 a.m.
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/spi/spi-tegra114.c | 1 -
 1 file changed, 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown - July 2, 2013, 9:50 a.m.
On Tue, Jul 02, 2013 at 08:37:44AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied, thanks.

Patch

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e8f542a..8c99c00 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1068,7 +1068,6 @@  static int tegra_spi_probe(struct platform_device *pdev)
 	tspi->base = devm_ioremap_resource(&pdev->dev, r);
 	if (IS_ERR(tspi->base)) {
 		ret = PTR_ERR(tspi->base);
-		dev_err(&pdev->dev, "ioremap failed: err = %d\n", ret);
 		goto exit_free_master;
 	}