From patchwork Mon Jul 1 20:56:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Hill X-Patchwork-Id: 256220 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 784922C0087 for ; Tue, 2 Jul 2013 06:45:45 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=qjjh0jXRYvyF fuz3kPzcBP/G4PadFbYVgoygBVrW6OPE+6NdzstdIFswThZZrQmRSNeL9LmZSkD8 bSwUqobMfwwW6kgc4mAabvKv0OMEYHeq/VsKdZljk1D06GkJTy9fUpwzNSgedbkX IWrBRNJ2QuashdD9AlbklO6dUVx6RQg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=uaq3nOhwUCvc7CWqCQ B804j3WqQ=; b=lM4IPnGOr7t2sG9rL0LB0hukQGs/Pd0BLiyhMha3bL2QLCeRtb sGHTkPFFpDESYtV1UA3gj3B0pkfxlDu61CIwdQgPOSsNbxwwQCAtHBtt7M2dv/UU ei6vCcn/URaIPKaZWGtgJqIbLO/FMBggYO8qKGujlxNR8rhXUVbNHjEtY= Received: (qmail 12515 invoked by alias); 1 Jul 2013 20:45:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 12477 invoked by uid 89); 1 Jul 2013 20:45:35 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.1 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 20:45:35 +0000 Received: from caribou (71-17-69-121.yktn.hsdb.sasknet.sk.ca [71.17.69.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: dirtyepic) by smtp.gentoo.org (Postfix) with ESMTPSA id C9CD833E77E; Mon, 1 Jul 2013 20:45:33 +0000 (UTC) From: Ryan Hill To: gcc-patches@gcc.gnu.org Cc: Ryan Hill Subject: [PATCH] [libitm] Add --enable-werror. Date: Mon, 1 Jul 2013 14:56:01 -0600 Message-Id: <1372712161-8711-1-git-send-email-dirtyepic@gentoo.org> libitm is currently unconditionally built with -Werror. This patch adds --enable-werror to control it (enabled by default). Bootstrapped and tested on x86_64, and inspected build logs to ensure it was doing what it should. I'm assuming copyright assignment isn't necessary for a small change like this. I will also need someone to check this in for me please. gcc/libitm/ 2013-06-30 Ryan Hill * configure.ac: Add --enable-werror. (XCFLAGS): Use it. * configure: Regenerate. --- libitm/configure.ac | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libitm/configure.ac b/libitm/configure.ac index ff41266..5a9400d 100644 --- a/libitm/configure.ac +++ b/libitm/configure.ac @@ -252,9 +252,15 @@ GCC_CHECK_ELF_STYLE_WEAKREF CFLAGS="$save_CFLAGS" AC_CACHE_SAVE -# Add -Wall -Werror if we are using GCC. +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], + [turns on -Werror @<:@default=yes@:>@])]) +# Add -Wall if we are using GCC. if test "x$GCC" = "xyes"; then - XCFLAGS="$XCFLAGS -Wall -Werror" + XCFLAGS="$XCFLAGS -Wall" + # Add -Werror if requested. + if test "x$enable_werror" != "xno"; then + XCFLAGS="$XCFLAGS -Werror" + fi fi XCFLAGS="$XCFLAGS $XPCFLAGS"