Patchwork [v3,3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

login
register
mail settings
Submitter Kevin Wolf
Date July 1, 2013, 2:31 p.m.
Message ID <1372689112-8093-4-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/256153/
State New
Headers show

Comments

Kevin Wolf - July 1, 2013, 2:31 p.m.
We don't have to duplicate the definition any more now that we may refer
to a type instead.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qapi-schema.json | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
Michael Roth - July 1, 2013, 4:31 p.m.
On Mon, Jul 1, 2013 at 9:31 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qapi-schema.json | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 5c32528..a90aeb1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1709,16 +1709,7 @@
>  #
>  # Generates a synchronous snapshot of a block device.
>  #
> -# @device:  the name of the device to generate the snapshot from.
> -#
> -# @snapshot-file: the target of the new image. If the file exists, or if it
> -#                 is a device, the snapshot will be created in the existing
> -#                 file/device. If does not exist, a new file will be created.
> -#
> -# @format: #optional the format of the snapshot image, default is 'qcow2'.
> -#
> -# @mode: #optional whether and how QEMU should create a new image, default is
> -#        'absolute-paths'.
> +# For the arguments, see the documentation of BlockdevSnapshot.
>  #
>  # Returns: nothing on success
>  #          If @device is not a valid block device, DeviceNotFound
> @@ -1726,8 +1717,7 @@
>  # Since 0.14.0
>  ##
>  { 'command': 'blockdev-snapshot-sync',
> -  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> -            '*mode': 'NewImageMode'} }
> +  'data': 'BlockdevSnapshot' }
>
>  ##
>  # @human-monitor-command:
> --
> 1.8.1.4
>
Eric Blake - July 2, 2013, 7:57 p.m.
On 07/01/2013 08:31 AM, Kevin Wolf wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi-schema.json | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)

Since this patch is not in yet, but DriveBackup IS in via commit
3037f364, should you expand the scope of this patch to cover that
command at the same time?

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index 5c32528..a90aeb1 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1709,16 +1709,7 @@ 
 #
 # Generates a synchronous snapshot of a block device.
 #
-# @device:  the name of the device to generate the snapshot from.
-#
-# @snapshot-file: the target of the new image. If the file exists, or if it
-#                 is a device, the snapshot will be created in the existing
-#                 file/device. If does not exist, a new file will be created.
-#
-# @format: #optional the format of the snapshot image, default is 'qcow2'.
-#
-# @mode: #optional whether and how QEMU should create a new image, default is
-#        'absolute-paths'.
+# For the arguments, see the documentation of BlockdevSnapshot.
 #
 # Returns: nothing on success
 #          If @device is not a valid block device, DeviceNotFound
@@ -1726,8 +1717,7 @@ 
 # Since 0.14.0
 ##
 { 'command': 'blockdev-snapshot-sync',
-  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
-            '*mode': 'NewImageMode'} }
+  'data': 'BlockdevSnapshot' }
 
 ##
 # @human-monitor-command: