From patchwork Mon Jul 1 08:40:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 256033 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 8042B2C0351 for ; Mon, 1 Jul 2013 18:40:57 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=ty+x2u4A6u9mdo0bL/CrhbCZEV6gN4EDpWX53uebWhKkGO KpxWVhP5z6BFm8KA8k1SDhMgzukRRQUXTu8135JX3rm8ITeLj7FXGnV0eIKtG83C h00ef81IOVVPHaP8dhtMidDnnGLW7RfOhO9OI3pYQBCNHnuGRJthdx6MvLcsk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=9LUDqR8t6foFJZ/ivD8QV2cxpaU=; b=lJLF7UbTTGWQd/f+r+Qi 2puoIUUxaFcwHOvtYa74UbhOGtgNjimipORXpOjEEiFZEIzOEMkj2WtDV8AnzKv1 VMFRiOcz+EjXDhGq5CieLJzeDYEN9Ly/1QexbBrG8N7fdhOlXU/5jS4Fl3OjNfQT YMOcKm543UOj1sAgKPJwP/0= Received: (qmail 20334 invoked by alias); 1 Jul 2013 08:40:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 20260 invoked by uid 89); 1 Jul 2013 08:40:41 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 08:40:40 +0000 Received: from archimedes.net-b.de (port-92-206-14-23.dynamic.qsc.de [92.206.14.23]) by mx01.qsc.de (Postfix) with ESMTP id AB27E3C243; Mon, 1 Jul 2013 10:40:37 +0200 (CEST) Message-ID: <51D14084.6070609@net-b.de> Date: Mon, 01 Jul 2013 10:40:36 +0200 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: gcc patches , gfortran Subject: [Patch, Fortran] PR57469 - silence unused dummy arg warning, if it is used in a namelist X-Virus-Found: No Built and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2013-07-01 Tobias Burnus PR fortran/57469 * trans-decl.c (generate_local_decl): Don't warn that a dummy is unused, when it is in a namelist. 2013-07-01 Tobias Burnus PR fortran/57469 * gfortran.dg/warn_unused_dummy_argument_4.f90: New. diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c index fc3a725..6a8d98c 100644 --- a/gcc/fortran/trans-decl.c +++ b/gcc/fortran/trans-decl.c @@ -4726,7 +4726,7 @@ generate_local_decl (gfc_symbol * sym) gfc_get_symbol_decl (sym); /* Warnings for unused dummy arguments. */ - else if (sym->attr.dummy) + else if (sym->attr.dummy && !sym->attr.in_namelist) { /* INTENT(out) dummy arguments are likely meant to be set. */ if (gfc_option.warn_unused_dummy_argument --- /dev/null 2013-07-01 08:13:35.324165209 +0200 +++ gcc/gcc/testsuite/gfortran.dg/warn_unused_dummy_argument_4.f90 2013-07-01 10:21:47.718455463 +0200 @@ -0,0 +1,16 @@ +! { dg-do compile } +! { dg-options "-Wall" } +! +! PR fortran/57469 +! +! Contributed by Vladimir Fuka +! +! Don't warn for unused dummy arguments when it is used in namelists +! + subroutine read_command_line(line,a,b) + character(*),intent(in) :: line + intent(inout) :: a,b + namelist /cmd/ a,b + + read(line,nml = cmd) + end