Patchwork [U-Boot,1/3] lib/rsa/rsa-sig.c: compile on OS X

login
register
mail settings
Submitter Andreas Bießmann
Date June 30, 2013, 11:15 a.m.
Message ID <1372590906-75089-2-git-send-email-andreas.devel@googlemail.com>
Download mbox | patch
Permalink /patch/255877/
State Superseded
Headers show

Comments

Andreas Bießmann - June 30, 2013, 11:15 a.m.
Interfaces exposed by error.h seems not to be used in rsa-sig.c, remove it.
This also fixes an compile error on OS X:

---8<---
u-boot/lib/rsa/rsa-sign.c:23:19: error: error.h: No such file or directory
--->8---

Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
---
Supersedes http://patchwork.ozlabs.org/patch/255283/

 lib/rsa/rsa-sign.c | 1 -
 1 file changed, 1 deletion(-)
Lubomir Popov - July 1, 2013, 6:58 p.m.
Hi Andreas,

> Interfaces exposed by error.h seems not to be used in rsa-sig.c, remove it.
> This also fixes an compile error on OS X:
>
> ---8<---
> u-boot/lib/rsa/rsa-sign.c:23:19: error: error.h: No such file or directory
> --->8---
>
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> ---

Entire series

Tested-by: Lubomir Popov <lpopov@mm-sol.com>

on MacOS X 10.8.3 with the following tools used for building U-Boot
for one ARM (OMAP) board:

arm-none-eabi-gcc (GCC) 4.7.2
GNU ld (GNU Binutils) 2.23.1

Best regards,
Lubo
Simon Glass - July 3, 2013, 2:15 p.m.
On Sun, Jun 30, 2013 at 8:15 PM, Andreas Bießmann <
andreas.devel@googlemail.com> wrote:

> Interfaces exposed by error.h seems not to be used in rsa-sig.c, remove it.
> This also fixes an compile error on OS X:
>
> ---8<---
> u-boot/lib/rsa/rsa-sign.c:23:19: error: error.h: No such file or directory
> --->8---
>
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
>

Reviewed-by: Simon Glass <sjg@chromium.org?

Thanks for sorting this out. Might even break out my Mac to try it :-)


> ---
> Supersedes http://patchwork.ozlabs.org/patch/255283/
>
>  lib/rsa/rsa-sign.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c
> index a75ae24..e30d8ca 100644
> --- a/lib/rsa/rsa-sign.c
> +++ b/lib/rsa/rsa-sign.c
> @@ -20,7 +20,6 @@
>  #include "mkimage.h"
>  #include <stdio.h>
>  #include <string.h>
> -#include <error.h>
>  #include <image.h>
>  #include <time.h>
>  #include <openssl/rsa.h>
> --
> 1.8.3.1
>
>

Patch

diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c
index a75ae24..e30d8ca 100644
--- a/lib/rsa/rsa-sign.c
+++ b/lib/rsa/rsa-sign.c
@@ -20,7 +20,6 @@ 
 #include "mkimage.h"
 #include <stdio.h>
 #include <string.h>
-#include <error.h>
 #include <image.h>
 #include <time.h>
 #include <openssl/rsa.h>