From patchwork Sat Jun 29 15:10:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 255742 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 986C02C00A7 for ; Sun, 30 Jun 2013 01:11:17 +1000 (EST) Received: from localhost ([::1]:42575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uswny-0000HM-E4 for incoming@patchwork.ozlabs.org; Sat, 29 Jun 2013 11:11:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uswni-0000HE-52 for qemu-devel@nongnu.org; Sat, 29 Jun 2013 11:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uswnh-000472-1C for qemu-devel@nongnu.org; Sat, 29 Jun 2013 11:10:58 -0400 Received: from qemu.weilnetz.de ([37.221.198.45]:53089 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uswng-00044t-R3 for qemu-devel@nongnu.org; Sat, 29 Jun 2013 11:10:56 -0400 Received: by v2201305906712890.yourvserver.net (Postfix, from userid 1000) id D7FFB182D20; Sat, 29 Jun 2013 17:10:53 +0200 (CEST) From: Stefan Weil To: Date: Sat, 29 Jun 2013 17:10:48 +0200 Message-Id: <1372518648-10862-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 37.221.198.45 Cc: Stefan Weil , qemu-devel Subject: [Qemu-devel] [PATCH] aes: Remove unused code (NDEBUG, u16) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The current code includes assert.h very early (from qemu-common.h), so the definition of NDEBUG was without any effect. In the initial version from 2004, NDEBUG was used to disable the assertions. Those assertions are not in time critical code, so it is no longer reasonable to disable them and the definition of NDEBUG can be removed. Type u16 is also unused and therefore does not need a type definition. Signed-off-by: Stefan Weil --- util/aes.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/util/aes.c b/util/aes.c index 91e97fa..4b4d88e 100644 --- a/util/aes.c +++ b/util/aes.c @@ -30,12 +30,7 @@ #include "qemu-common.h" #include "qemu/aes.h" -#ifndef NDEBUG -#define NDEBUG -#endif - typedef uint32_t u32; -typedef uint16_t u16; typedef uint8_t u8; /* This controls loop-unrolling in aes_core.c */