From patchwork Fri Jun 28 16:22:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changli Gao X-Patchwork-Id: 255464 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EF0552C008E for ; Sat, 29 Jun 2013 02:24:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754704Ab3F1QYH (ORCPT ); Fri, 28 Jun 2013 12:24:07 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:36687 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753912Ab3F1QYG (ORCPT ); Fri, 28 Jun 2013 12:24:06 -0400 Received: by mail-pb0-f43.google.com with SMTP id md12so2457965pbc.16 for ; Fri, 28 Jun 2013 09:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=s61B9CSEsQOwgsbUnh2yIDi1MsAmB2Wtol05ybUvm1M=; b=mzVH1oXD3LlUl90af50CykPM1vm3VLtt+xGjNu0W2i7I3ZPLgfZGAB0zuY7Uz3H7Os 78k0OUjhd06f++RrPvX+u+xvfsvdhDOG9d4f9cKNcu3k4/JiPPsjNiaIdVmvdjZ7nMr6 lBV27PmdaI+xPr298ayryiiQbc2Kjnjlg5wTnt1F/mqGrHpJIrAg0G5RYpUotwrOoIJ7 5tYz0yDmXAPIIPQu/hh9gUVRg0w7o2Gs25BpW1pvalYNyMdl++LUFAQg5a69dTjVpMZB D2+vDMBIdGUfCIAJdlgdPNhzlvsxd8jS0VjjpTNgs+kV5meqATminfmqQmocDlTIjT50 c22g== X-Received: by 10.66.136.49 with SMTP id px17mr12330090pab.133.1372436645034; Fri, 28 Jun 2013 09:24:05 -0700 (PDT) Received: from localhost.localdomain ([111.164.173.3]) by mx.google.com with ESMTPSA id ag4sm8812271pbc.20.2013.06.28.09.23.59 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 28 Jun 2013 09:24:04 -0700 (PDT) From: Changli Gao To: "David S. Miller" Cc: Changli Gao , netdev@vger.kernel.org Subject: [PATCH v2] net: Check the argument for listen(2) Date: Sat, 29 Jun 2013 00:22:57 +0800 Message-Id: <1372436577-61749-1-git-send-email-xiaosuo@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org As we use u16 to save the value of the argument for listen(2), we'd better check if the value is larger than SINT_MAX other than cut it down silently on error. --- net/ipv4/af_inet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index b4d0be2..35aaf00 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -198,6 +198,9 @@ int inet_listen(struct socket *sock, int backlog) unsigned char old_state; int err; + if (backlog >= (1 << 16)) + return -EINVAL; + lock_sock(sk); err = -EINVAL;