From patchwork Fri Jun 28 11:31:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 255333 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A1EAB2C0182 for ; Fri, 28 Jun 2013 21:32:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840Ab3F1Lbq (ORCPT ); Fri, 28 Jun 2013 07:31:46 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:51303 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752718Ab3F1Lbp (ORCPT ); Fri, 28 Jun 2013 07:31:45 -0400 Received: from [173.51.221.202] (account joe@perches.com HELO [192.168.1.152]) by labridge.com (CommuniGate Pro SMTP 5.0.14) with ESMTPA id 21121079; Fri, 28 Jun 2013 04:31:44 -0700 Message-ID: <1372419104.2060.54.camel@joe-AO722> Subject: Re: [PATCH next] xen: Convert printks to pr_ From: Joe Perches To: Wei Liu Cc: Ian Campbell , Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , xen-devel@lists.xensource.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "virtualization@lists.osdl.org" Date: Fri, 28 Jun 2013 04:31:44 -0700 In-Reply-To: <20130628103605.GE16643@zion.uk.xensource.com> References: <1372395469.2060.36.camel@joe-AO722> <20130628080250.GA16643@zion.uk.xensource.com> <1372414901.2060.44.camel@joe-AO722> <20130628103605.GE16643@zion.uk.xensource.com> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2013-06-28 at 11:36 +0100, Wei Liu wrote: > I can clean up the rest in xen-netback after your previous patch goes > in. Here's a suggested change for drivers/net Convert printk to pr_ Add missing newlines to pr_debug Remove duplicate "s: " __func__ Reflow to 80 columns --- drivers/net/xen-netback/xenbus.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 04bd860..1fe48fe3 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -130,7 +130,7 @@ static int netback_probe(struct xenbus_device *dev, "feature-split-event-channels", "%u", separate_tx_rx_irq); if (err) - pr_debug("Error writing feature-split-event-channels"); + pr_debug("Error writing feature-split-event-channels\n"); err = xenbus_switch_state(dev, XenbusStateInitWait); if (err) @@ -145,7 +145,7 @@ abort_transaction: xenbus_transaction_end(xbt, 1); xenbus_dev_fatal(dev, err, "%s", message); fail: - pr_debug("failed"); + pr_debug("failed\n"); netback_remove(dev); return err; } @@ -228,15 +228,14 @@ static void frontend_changed(struct xenbus_device *dev, { struct backend_info *be = dev_get_drvdata(&dev->dev); - pr_debug("frontend state %s", xenbus_strstate(frontend_state)); + pr_debug("frontend state %s\n", xenbus_strstate(frontend_state)); be->frontend_state = frontend_state; switch (frontend_state) { case XenbusStateInitialising: if (dev->state == XenbusStateClosed) { - printk(KERN_INFO "%s: %s: prepare for reconnect\n", - __func__, dev->nodename); + pr_info("%s: prepare for reconnect\n", dev->nodename); xenbus_switch_state(dev, XenbusStateInitWait); } break;