Patchwork update_version.sh: use non-localised date representation

login
register
mail settings
Submitter Keng-Yu Lin
Date June 28, 2013, 8:28 a.m.
Message ID <1372408086-3743-1-git-send-email-kengyu@canonical.com>
Download mbox | patch
Permalink /patch/255308/
State Accepted
Headers show

Comments

Keng-Yu Lin - June 28, 2013, 8:28 a.m.
The patch makes the date representation look like this:

     2013-06-28 08:23:12

(tested in zh_TW, en_US, en_GB locales.)

Also date and time is in time zone UTC+0 with the patch.

Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
---
 update_version.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - June 28, 2013, 8:36 a.m.
On 28/06/13 09:28, Keng-Yu Lin wrote:
> The patch makes the date representation look like this:
> 
>      2013-06-28 08:23:12
> 
> (tested in zh_TW, en_US, en_GB locales.)
> 
> Also date and time is in time zone UTC+0 with the patch.
> 
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>  update_version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/update_version.sh b/update_version.sh
> index 2eefe10..a3a04ca 100755
> --- a/update_version.sh
> +++ b/update_version.sh
> @@ -27,7 +27,7 @@ cat << EOF > src/lib/include/fwts_version.h
>   */
>  EOF
>  echo '#define FWTS_VERSION "'$version'"' >> src/lib/include/fwts_version.h
> -echo '#define FWTS_DATE    "'`date "+%x %T"`'"' >> src/lib/include/fwts_version.h
> +echo '#define FWTS_DATE    "'`date --utc "+%F %T"`'"' >> src/lib/include/fwts_version.h
>  git add src/lib/include/fwts_version.h
>  git commit -s -m"lib: fwts_version.h - update to $version"
>  git tag -m'"Version '$1'"' $1
> 
Thanks Keng-Yu - I checked it from my locale and it looks good.

Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung - June 28, 2013, 8:41 a.m.
On 06/28/2013 04:28 PM, Keng-Yu Lin wrote:
> The patch makes the date representation look like this:
>
>       2013-06-28 08:23:12
>
> (tested in zh_TW, en_US, en_GB locales.)
>
> Also date and time is in time zone UTC+0 with the patch.
>
> Signed-off-by: Keng-Yu Lin <kengyu@canonical.com>
> ---
>   update_version.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/update_version.sh b/update_version.sh
> index 2eefe10..a3a04ca 100755
> --- a/update_version.sh
> +++ b/update_version.sh
> @@ -27,7 +27,7 @@ cat << EOF > src/lib/include/fwts_version.h
>    */
>   EOF
>   echo '#define FWTS_VERSION "'$version'"' >> src/lib/include/fwts_version.h
> -echo '#define FWTS_DATE    "'`date "+%x %T"`'"' >> src/lib/include/fwts_version.h
> +echo '#define FWTS_DATE    "'`date --utc "+%F %T"`'"' >> src/lib/include/fwts_version.h
>   git add src/lib/include/fwts_version.h
>   git commit -s -m"lib: fwts_version.h - update to $version"
>   git tag -m'"Version '$1'"' $1
>

Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/update_version.sh b/update_version.sh
index 2eefe10..a3a04ca 100755
--- a/update_version.sh
+++ b/update_version.sh
@@ -27,7 +27,7 @@  cat << EOF > src/lib/include/fwts_version.h
  */
 EOF
 echo '#define FWTS_VERSION "'$version'"' >> src/lib/include/fwts_version.h
-echo '#define FWTS_DATE    "'`date "+%x %T"`'"' >> src/lib/include/fwts_version.h
+echo '#define FWTS_DATE    "'`date --utc "+%F %T"`'"' >> src/lib/include/fwts_version.h
 git add src/lib/include/fwts_version.h
 git commit -s -m"lib: fwts_version.h - update to $version"
 git tag -m'"Version '$1'"' $1