From patchwork Fri Jun 28 07:35:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Byungho An X-Patchwork-Id: 255284 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 14F232C036A for ; Fri, 28 Jun 2013 17:35:38 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788Ab3F1Hfd (ORCPT ); Fri, 28 Jun 2013 03:35:33 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:19318 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754669Ab3F1Hfc (ORCPT ); Fri, 28 Jun 2013 03:35:32 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MP300FJFEF6CT20@mailout1.samsung.com> for netdev@vger.kernel.org; Fri, 28 Jun 2013 16:35:31 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 92.9E.17404.3CC3DC15; Fri, 28 Jun 2013 16:35:31 +0900 (KST) X-AuditID: cbfee68d-b7f096d0000043fc-f4-51cd3cc35a09 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id BC.93.21068.3CC3DC15; Fri, 28 Jun 2013 16:35:31 +0900 (KST) Received: from DObh74an01 ([12.23.120.86]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MP3001AUEF70Q60@mmp1.samsung.com>; Fri, 28 Jun 2013 16:35:31 +0900 (KST) From: Byungho An To: netdev@vger.kernel.org Cc: 'Giuseppe CAVALLARO' , =?ks_c_5601-1987?B?J7HosbnB+Cc=?= , davem@davemloft.net, cpgs@samsung.com Subject: [PATCH] net: stmmac: fixed operator typo Date: Fri, 28 Jun 2013 16:35:31 +0900 Message-id: <015701ce73d2$117b9040$3472b0c0$%an@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ks_c_5601-1987 Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac5z0hFVNgCeuyIyQBCP0UoYPxBUAQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t8zfd3DNmcDDa5eVbR4eUjTYs75FhaL 3gVX2SyOLRCz+P96K6MDq8eWlTeZPPq2rGL0ePpjL7PH501yASxRXDYpqTmZZalF+nYJXBk/ ds1iLVjBXfFz/mrGBsYdnF2MnBwSAiYSa9ZNY4awxSQu3FvPBmILCSxjlLjxvQ6m5vrd30xd jFxA8UWMEqtfz2KHKPrFKPF4uxeIzSagJtE88zJYs4iAlMTHHdvZQRqYBaYzSiy98IcVJCEs YChxs2M5mM0ioCrx/84xsAZeARuJjZvmMUHYghI/Jt9jAbGZBQwk3s/qY4Ww5SU2r3kLdCkH 0EXqEo/+6oKYIgJ6Ems2s0NUiEjse/GOEWSthMAhdokD258xQ6wSkPg2+RALRKusxKYDUP9K ShxccYNlAqPYLCSLZyFZPAvJ4llIVixgZFnFKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERJp vTsYbx+wPsSYDLR+IrOUaHI+MFLzSuINjc2MLExNTI2NzC3NSBNWEudVa7EOFBJITyxJzU5N LUgtii8qzUktPsTIxMEp1cDocyR1UqNQvl5EOfeDYp8MxoXhHyov3nErjzLZo3YmJkWJQ2Df ubbXBuxiwgE/62Z2/zVeylGeLxL9xWv2a6eLKxRv7PC0vcp0sezLxvCqC7ofLZKWOTqJSxxz /PD+ubP03El8W8VcL7k5V7xYamF+7dLB1G8zxaVqW6bGqlWv0F3qY26o0qbEUpyRaKjFXFSc CADsWzmZygIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKKsWRmVeSWpSXmKPExsVy+t9jAd3DNmcDDf4fl7V4eUjTYs75FhaL 3gVX2SyOLRCz+P96K6MDq8eWlTeZPPq2rGL0ePpjL7PH501yASxRDYw2GamJKalFCql5yfkp mXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBrlRTKEnNKgUIBicXFSvp2mCaE hrjpWsA0Ruj6hgTB9RgZoIGEdYwZP3bNYi1YwV3xc/5qxgbGHZxdjJwcEgImEtfv/maCsMUk Ltxbz9bFyMUhJLCIUWL161nsIAkhgV+MEo+3e4HYbAJqEs0zL7OB2CICUhIfd2xnB2lgFpjO KLH0wh9WkISwgKHEzY7lYDaLgKrE/zvHwBp4BWwkNm6axwRhC0r8mHyPBcRmFjCQeD+rjxXC lpfYvOYtcxcjB9BF6hKP/uqCmCICehJrNrNDVIhI7HvxjnECo8AsJINmIRk0C8mgWUhaFjCy rGIUTS1ILihOSs810itOzC0uzUvXS87P3cQIjuRn0jsYVzVYHGIU4GBU4uFtSDwTKMSaWFZc mXuIUYKDWUmE984CoBBvSmJlVWpRfnxRaU5q8SHGZKA/JzJLiSbnA5NMXkm8obGJmZGlkZmF kYm5OWnCSuK8B1utA4UE0hNLUrNTUwtSi2C2MHFwSjUwhq/6smPv2+U70/6eNLy2ef9N7pep antKxMyOMi9vWirn4qLuPkPyDIN8+f92rvMPecsW7Dl2ythq28GtixIWKF+Wv7J2217upll+ qlJeeSuZbaIVPqlmefrtszV/83/Fy9lmU0Obp9UcErO9umrribULF7dHzrM9zzp73v45ZRNv 5x40yWW7tV6JpTgj0VCLuag4EQCpbc7CKAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixed operator typo from & to ==. Due to incorrect operator, the result is incorrect. Signed-off-by: Byungho An Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 22 +++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c1ad5f4..f088633 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -788,13 +788,13 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv) int interface = priv->plat->interface; if (priv->dma_cap.pcs) { - if ((interface & PHY_INTERFACE_MODE_RGMII) || - (interface & PHY_INTERFACE_MODE_RGMII_ID) || - (interface & PHY_INTERFACE_MODE_RGMII_RXID) || - (interface & PHY_INTERFACE_MODE_RGMII_TXID)) { + if ((interface == PHY_INTERFACE_MODE_RGMII) || + (interface == PHY_INTERFACE_MODE_RGMII_ID) || + (interface == PHY_INTERFACE_MODE_RGMII_RXID) || + (interface == PHY_INTERFACE_MODE_RGMII_TXID)) { pr_debug("STMMAC: PCS RGMII support enable\n"); priv->pcs = STMMAC_PCS_RGMII; - } else if (interface & PHY_INTERFACE_MODE_SGMII) { + } else if (interface == PHY_INTERFACE_MODE_SGMII) { pr_debug("STMMAC: PCS SGMII support enable\n"); priv->pcs = STMMAC_PCS_SGMII; }