Patchwork powerpc/eeh: Update MAINTAINERS

login
register
mail settings
Submitter Gavin Shan
Date June 28, 2013, 1:59 a.m.
Message ID <1372384784-20788-1-git-send-email-shangw@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/255260/
State Superseded
Headers show

Comments

Gavin Shan - June 28, 2013, 1:59 a.m.
Update MAINTAINERS to reflect recent changes.

Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
 MAINTAINERS |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Benjamin Herrenschmidt - June 28, 2013, 2:11 a.m.
On Fri, 2013-06-28 at 09:59 +0800, Gavin Shan wrote:
> Update MAINTAINERS to reflect recent changes.
> 
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
> ---
>  MAINTAINERS |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5be702c..b447392 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6146,10 +6146,14 @@ F:	drivers/firmware/pcdp.*
>  
>  PCI ERROR RECOVERY
>  M:	 
> +M:	Gavin Shan <shangw@linux.vnet.ibm.com>

Remove Linas, he isn't involved anymore as far as I can tell
(are you ?)

>  L:	linux-pci@vger.kernel.org
> +L:	linuxppc-dev@lists.ozlabs.org
>  S:	Supported
>  F:	Documentation/PCI/pci-error-recovery.txt
>  F:	Documentation/powerpc/eeh-pci-error-recovery.txt
> +F:	arch/powerpc/kernel/eeh*.c
> +F:	drivers/pci/pcie/aer/

Not sure about the AER code. You are not maintaining *that* at least :-)
Maybe we should split EEH from the rest ?

Cheers,
Ben.

>  PCI SUBSYSTEM
>  M:	Bjorn Helgaas <bhelgaas@google.com>
Gavin Shan - June 28, 2013, 2:18 a.m.
On Fri, Jun 28, 2013 at 12:11:29PM +1000, Benjamin Herrenschmidt wrote:
>On Fri, 2013-06-28 at 09:59 +0800, Gavin Shan wrote:
>> Update MAINTAINERS to reflect recent changes.
>> 
>> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
>> ---
>>  MAINTAINERS |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 5be702c..b447392 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -6146,10 +6146,14 @@ F:	drivers/firmware/pcdp.*
>>  
>>  PCI ERROR RECOVERY
>>  M:	 
>> +M:	Gavin Shan <shangw@linux.vnet.ibm.com>
>
>Remove Linas, he isn't involved anymore as far as I can tell
>(are you ?)
>
>>  L:	linux-pci@vger.kernel.org
>> +L:	linuxppc-dev@lists.ozlabs.org
>>  S:	Supported
>>  F:	Documentation/PCI/pci-error-recovery.txt
>>  F:	Documentation/powerpc/eeh-pci-error-recovery.txt
>> +F:	arch/powerpc/kernel/eeh*.c
>> +F:	drivers/pci/pcie/aer/
>
>Not sure about the AER code. You are not maintaining *that* at least :-)
>Maybe we should split EEH from the rest ?
>

Ok. Split EEH from it and keep everything for "PCI ERROR RECOVERY".

Thanks,
Gavin
Linas Vepstas - June 28, 2013, 5:47 p.m.
Hi,

On 27 June 2013 21:11, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Fri, 2013-06-28 at 09:59 +0800, Gavin Shan wrote:
>> Update MAINTAINERS to reflect recent changes.
>>
>> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
>> ---
>>  MAINTAINERS |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 5be702c..b447392 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -6146,10 +6146,14 @@ F:    drivers/firmware/pcdp.*
>>
>>  PCI ERROR RECOVERY
>>  M:
>> +M:   Gavin Shan <shangw@linux.vnet.ibm.com>
>
> Remove Linas, he isn't involved anymore as far as I can tell
> (are you ?)

Not involved any more; I don't have access to equipment, don't have
time, expertise is fading.

>>  L:   linux-pci@vger.kernel.org
>> +L:   linuxppc-dev@lists.ozlabs.org
>>  S:   Supported
>>  F:   Documentation/PCI/pci-error-recovery.txt
>>  F:   Documentation/powerpc/eeh-pci-error-recovery.txt
>> +F:   arch/powerpc/kernel/eeh*.c
>> +F:   drivers/pci/pcie/aer/
>
> Not sure about the AER code. You are not maintaining *that* at least :-)
> Maybe we should split EEH from the rest ?

Based on recent discussions (a month ago?) regarding AER, its clear
that at least some of the AER code is mis-designed, and that some of
the patches being submitted against it were making things worse.   I
suggest keeping an eye on that ... the problem is that both AER and
EEH share a common framework in the PCI subsystem. As bugs in AER get
discovered, there's a chance that someone will submit a patch to the
common framework, or possibly start modifying assorted drivers, which
will then break EEH ... so I don't think it is wise/safe to ignore
AER.

(The point is that AER and EEH really should work exactly the same;
they differ merely by how they talk to the root port).

-- Linas

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 5be702c..b447392 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6146,10 +6146,14 @@  F:	drivers/firmware/pcdp.*
 
 PCI ERROR RECOVERY
 M:	Linas Vepstas <linasvepstas@gmail.com>
+M:	Gavin Shan <shangw@linux.vnet.ibm.com>
 L:	linux-pci@vger.kernel.org
+L:	linuxppc-dev@lists.ozlabs.org
 S:	Supported
 F:	Documentation/PCI/pci-error-recovery.txt
 F:	Documentation/powerpc/eeh-pci-error-recovery.txt
+F:	arch/powerpc/kernel/eeh*.c
+F:	drivers/pci/pcie/aer/
 
 PCI SUBSYSTEM
 M:	Bjorn Helgaas <bhelgaas@google.com>