Patchwork [3/3] lib: fwts_framework: remove some old and redundant #defines

login
register
mail settings
Submitter Colin King
Date June 28, 2013, 12:04 a.m.
Message ID <1372377851-23390-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/255255/
State Accepted
Headers show

Comments

Colin King - June 28, 2013, 12:04 a.m.
From: Colin Ian King <colin.king@canonical.com>

Remove FWTS_ARGS_WIDTH and FWTS_MIN_TTY_WIDTH - no longer used
legacy cruft.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_framework.c | 3 ---
 1 file changed, 3 deletions(-)
Keng-Yu Lin - June 28, 2013, 2:39 a.m.
On Fri, Jun 28, 2013 at 8:04 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove FWTS_ARGS_WIDTH and FWTS_MIN_TTY_WIDTH - no longer used
> legacy cruft.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_framework.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 6727d5a..1bda7b1 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -40,9 +40,6 @@
>          FWTS_FLAG_UTILS |                      \
>          FWTS_FLAG_UNSAFE)
>
> -#define FWTS_ARGS_WIDTH        28
> -#define FWTS_MIN_TTY_WIDTH     50
> -
>  static fwts_list tests_to_skip;
>
>  static fwts_option fwts_framework_options[] = {
> --
> 1.8.3.1
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Alex Hung - June 28, 2013, 3:33 a.m.
On 06/28/2013 08:04 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Remove FWTS_ARGS_WIDTH and FWTS_MIN_TTY_WIDTH - no longer used
> legacy cruft.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_framework.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 6727d5a..1bda7b1 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -40,9 +40,6 @@
>  	 FWTS_FLAG_UTILS |			\
>  	 FWTS_FLAG_UNSAFE)
>  
> -#define FWTS_ARGS_WIDTH 	28
> -#define FWTS_MIN_TTY_WIDTH	50
> -
>  static fwts_list tests_to_skip;
>  
>  static fwts_option fwts_framework_options[] = {
> 
Acked-by: Alex Hung <alex.hung@canonical.com>

Patch

diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index 6727d5a..1bda7b1 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -40,9 +40,6 @@ 
 	 FWTS_FLAG_UTILS |			\
 	 FWTS_FLAG_UNSAFE)
 
-#define FWTS_ARGS_WIDTH 	28
-#define FWTS_MIN_TTY_WIDTH	50
-
 static fwts_list tests_to_skip;
 
 static fwts_option fwts_framework_options[] = {