Patchwork eeh: add eeh_dev to the cache during boot

mail settings
Submitter Thadeu Lima de Souza Cascardo
Date June 27, 2013, 9 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/255227/
State Accepted, archived
Commit 1abd601864f42a5d10e6fa0b66582591b4497b94
Headers show


Thadeu Lima de Souza Cascardo - June 27, 2013, 9 p.m.
commit f8f7d63fd96ead101415a1302035137a866f8998 ("powerpc/eeh: Trace eeh
device from I/O cache") broke EEH on pseries for devices that were
present during boot and have not been hotplugged/DLPARed.

eeh_check_failure will get the eeh_dev from the cache, and will get
NULL. eeh_addr_cache_build adds the addresses to the cache, but eeh_dev
for the giving pci_device is not set yet. Just reordering the call to
eeh_addr_cache_insert_dev works fine. The ordering is similar to the one
in eeh_add_device_late.

Signed-off-by: Thadeu Lima de Souza Cascardo <>

Note that this is broken since v3.7-rc1 and this patch applies on top of
v3.10-rc7. Just changing the patches will apply it on top of
next-20130626, where it has moved to arch/powerpc/kernel/.

I also realized when writing the log that maybe calling
eeh_add_device_late instead could be a better option. Please, share your

 arch/powerpc/platforms/pseries/eeh_cache.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/arch/powerpc/platforms/pseries/eeh_cache.c b/arch/powerpc/platforms/pseries/eeh_cache.c
index 5a4c879..5ce3ba7 100644
--- a/arch/powerpc/platforms/pseries/eeh_cache.c
+++ b/arch/powerpc/platforms/pseries/eeh_cache.c
@@ -294,8 +294,6 @@  void __init eeh_addr_cache_build(void)
 	for_each_pci_dev(dev) {
-		eeh_addr_cache_insert_dev(dev);
 		dn = pci_device_to_OF_node(dev);
 		if (!dn)
@@ -308,6 +306,8 @@  void __init eeh_addr_cache_build(void)
 		dev->dev.archdata.edev = edev;
 		edev->pdev = dev;
+		eeh_addr_cache_insert_dev(dev);