Patchwork powerpc: PPC_CELL_NATIVE should select PCI

login
register
mail settings
Submitter Geert Uytterhoeven
Date April 1, 2009, 9:42 a.m.
Message ID <alpine.LRH.2.00.0904011141550.13419@vixen.sonytel.be>
Download mbox | patch
Permalink /patch/25478/
State New
Headers show

Comments

Geert Uytterhoeven - April 1, 2009, 9:42 a.m.
PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI,
causing build failures if PCI is not set.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
 arch/powerpc/platforms/cell/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Benjamin Herrenschmidt - April 1, 2009, 9:54 a.m.
On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote:
> PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI,
> causing build failures if PCI is not set.

Maybe it should only select it if PCI is enabled ? Is qpace using PCI ?

Cheers,
Ben.

> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> ---
>  arch/powerpc/platforms/cell/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
> index 40e24c3..33f534f 100644
> --- a/arch/powerpc/platforms/cell/Kconfig
> +++ b/arch/powerpc/platforms/cell/Kconfig
> @@ -14,6 +14,7 @@ config PPC_CELL_NATIVE
>  	bool
>  	select PPC_CELL_COMMON
>  	select PPC_OF_PLATFORM_PCI
> +	select PCI
>  	select MPIC
>  	select IBM_NEW_EMAC_EMAC4
>  	select IBM_NEW_EMAC_RGMII
Arnd Bergmann - April 1, 2009, 10:45 a.m.
On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote:
> On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote:
> > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI,
> > causing build failures if PCI is not set.
> 
> Maybe it should only select it if PCI is enabled ? Is qpace using PCI ?

No, QPACE does not have any PCI devices whatsoever.

	Arnd <><
Benjamin Herrenschmidt - April 1, 2009, 11:02 a.m.
On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote:
> On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote:
> > On Wed, 2009-04-01 at 11:42 +0200, Geert Uytterhoeven wrote:
> > > PPC_CELL_NATIVE selects PPC_OF_PLATFORM_PCI, but not the underlying PCI,
> > > causing build failures if PCI is not set.
> > 
> > Maybe it should only select it if PCI is enabled ? Is qpace using PCI ?
> 
> No, QPACE does not have any PCI devices whatsoever.

so something like select PPC_OF_PLATFORM_PCI if PCI would work you
think ?

Ben.
Arnd Bergmann - April 1, 2009, 12:11 p.m.
On Wednesday 01 April 2009, Benjamin Herrenschmidt wrote:
> On Wed, 2009-04-01 at 12:45 +0200, Arnd Bergmann wrote:

> > No, QPACE does not have any PCI devices whatsoever.
> 
> so something like select PPC_OF_PLATFORM_PCI if PCI would work you
> think ?


Yes, that sounds good.

	Arnd <><

Patch

diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
index 40e24c3..33f534f 100644
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -14,6 +14,7 @@  config PPC_CELL_NATIVE
 	bool
 	select PPC_CELL_COMMON
 	select PPC_OF_PLATFORM_PCI
+	select PCI
 	select MPIC
 	select IBM_NEW_EMAC_EMAC4
 	select IBM_NEW_EMAC_RGMII