Patchwork [06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups"

login
register
mail settings
Submitter Hiroshi Doyu
Date June 26, 2013, 9:28 a.m.
Message ID <1372238906-9346-7-git-send-email-hdoyu@nvidia.com>
Download mbox | patch
Permalink /patch/254658/
State Superseded, archived
Headers show

Comments

Hiroshi Doyu - June 26, 2013, 9:28 a.m.
This is a bitmap that indicates which HardWare Accelerators(HWA) are
supported on Tegra114 SoC.

Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
---
 arch/arm/boot/dts/tegra114.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thierry Reding - June 26, 2013, 10:52 a.m.
On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
> This is a bitmap that indicates which HardWare Accelerators(HWA) are
> supported on Tegra114 SoC.
> 
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> ---
>  arch/arm/boot/dts/tegra114.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index 1f45cf5..715b5d6 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -323,7 +323,7 @@
>  		       0x70019228 0x074>;
>  		nvidia,#asids = <4>;
>  		dma-window = <0 0x40000000>;
> -		nvidia,swgroups = <0x18659fe>;
> +		nvidia,swgroups = <0x00000000 0x01b659fe>;
>  		nvidia,ahb = <&ahb>;
>  	};

It seems like an nvidia,tegra114-smmu.txt file is missing from the
Documentation/devicetree/bindings/iommu directory. And similarily to my
comment for the tegra30.dtsi update this could be a symbolic value such
as TEGRA114_SWGID_ALL.

Thierry
Hiroshi Doyu - July 1, 2013, 8:24 a.m.
Thierry Reding <thierry.reding@gmail.com> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:

> * PGP Signed by an unknown key
> 
> On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
> > This is a bitmap that indicates which HardWare Accelerators(HWA) are
> > supported on Tegra114 SoC.
> > 
> > Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> > ---
> >  arch/arm/boot/dts/tegra114.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> > index 1f45cf5..715b5d6 100644
> > --- a/arch/arm/boot/dts/tegra114.dtsi
> > +++ b/arch/arm/boot/dts/tegra114.dtsi
> > @@ -323,7 +323,7 @@
> >  		       0x70019228 0x074>;
> >  		nvidia,#asids = <4>;
> >  		dma-window = <0 0x40000000>;
> > -		nvidia,swgroups = <0x18659fe>;
> > +		nvidia,swgroups = <0x00000000 0x01b659fe>;
> >  		nvidia,ahb = <&ahb>;
> >  	};
> 
> It seems like an nvidia,tegra114-smmu.txt file is missing from the
> Documentation/devicetree/bindings/iommu directory.

All difference between T30 and T114 is now provided from DT. They have
all same entries but only those values are different.

Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just
tweaking nvidia,tegra30-smmu.txt for t114 enough?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Warren - July 1, 2013, 11:10 p.m.
On 07/01/2013 02:24 AM, Hiroshi Doyu wrote:
> Thierry Reding <thierry.reding@gmail.com> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:
>> On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
>>> This is a bitmap that indicates which HardWare Accelerators(HWA) are
>>> supported on Tegra114 SoC.
...
>> It seems like an nvidia,tegra114-smmu.txt file is missing from the
>> Documentation/devicetree/bindings/iommu directory.
> 
> All difference between T30 and T114 is now provided from DT. They have
> all same entries but only those values are different.
> 
> Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just
> tweaking nvidia,tegra30-smmu.txt for t114 enough?

If the two HW are identical (at least as far as bindings), the existing
nvidia,tegra30-smmu.txt should be enough. We probably should at least
update it to list the additional supported compatible value though,
especially if the driver interprets the two compatible values in a
different way (e.g. there are HW differences, but they don't affect the
binding definition).
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 1f45cf5..715b5d6 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -323,7 +323,7 @@ 
 		       0x70019228 0x074>;
 		nvidia,#asids = <4>;
 		dma-window = <0 0x40000000>;
-		nvidia,swgroups = <0x18659fe>;
+		nvidia,swgroups = <0x00000000 0x01b659fe>;
 		nvidia,ahb = <&ahb>;
 	};