rds: only for x86 or 64-bit at the moment...
diff mbox

Message ID 20090331210609.GD25513@bombadil.infradead.org
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Kyle McMartin March 31, 2009, 9:06 p.m. UTC
From: Kyle McMartin <kyle@redhat.com>

set_64bit doesn't exist anywhere but x86 right now, so either
BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
build this module.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller March 31, 2009, 9:15 p.m. UTC | #1
From: Kyle McMartin <kyle@mcmartin.ca>
Date: Tue, 31 Mar 2009 17:06:09 -0400

> From: Kyle McMartin <kyle@redhat.com>
> 
> set_64bit doesn't exist anywhere but x86 right now, so either
> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
> build this module.
> 
> Signed-off-by: Kyle McMartin <kyle@redhat.com>

I would prefer the RDS folks simply fix this properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andy Grover March 31, 2009, 11:58 p.m. UTC | #2
David Miller wrote:
> From: Kyle McMartin <kyle@mcmartin.ca>
> Date: Tue, 31 Mar 2009 17:06:09 -0400
> 
>> From: Kyle McMartin <kyle@redhat.com>
>>
>> set_64bit doesn't exist anywhere but x86 right now, so either
>> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
>> build this module.
>>
>> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> 
> I would prefer the RDS folks simply fix this properly.

Ok... I'll redo the latest rds patchseries with crit fixes only and a
fix for this.

Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller March 31, 2009, 11:59 p.m. UTC | #3
From: Andy Grover <andy.grover@oracle.com>
Date: Tue, 31 Mar 2009 16:58:46 -0700

> David Miller wrote:
> > From: Kyle McMartin <kyle@mcmartin.ca>
> > Date: Tue, 31 Mar 2009 17:06:09 -0400
> > 
> >> From: Kyle McMartin <kyle@redhat.com>
> >>
> >> set_64bit doesn't exist anywhere but x86 right now, so either
> >> BITS_PER_LONG needs to be 64, or we need to be on x86, in order to
> >> build this module.
> >>
> >> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> > 
> > I would prefer the RDS folks simply fix this properly.
> 
> Ok... I'll redo the latest rds patchseries with crit fixes only and a
> fix for this.

Thanks a lot Andy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/net/rds/Kconfig b/net/rds/Kconfig
index 796773b..84df275 100644
--- a/net/rds/Kconfig
+++ b/net/rds/Kconfig
@@ -1,7 +1,7 @@ 
 
 config RDS
 	tristate "Reliable Datagram Sockets (RDS) (EXPERIMENTAL)"
-	depends on INET && INFINIBAND_IPOIB && EXPERIMENTAL
+	depends on INET && INFINIBAND_IPOIB && EXPERIMENTAL && (64BIT || X86)
 	depends on INFINIBAND && INFINIBAND_ADDR_TRANS
 	---help---
 	  RDS provides reliable, sequenced delivery of datagrams