Patchwork Build error

login
register
mail settings
Submitter Segher Boessenkool
Date March 31, 2009, 8:41 p.m.
Message ID <38D8651E-1AB6-4358-AD1F-408E3DB8F4E9@kernel.crashing.org>
Download mbox | patch
Permalink /patch/25444/
State Superseded, archived
Headers show

Comments

Segher Boessenkool - March 31, 2009, 8:41 p.m.
>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko]
>>>> undefined!
>>>>
>>>> I'll ask Linus to pull anyway though.
>>>>
>>>> Cheers,
>>>> Ben.
>>>
>>> I believe this is fixed in net-next (and possible linus has already
>>> pulled that in.)
>>
>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next'
>> branch nor in `merge' branch...
>
> Ah .. .weird :-)

I had this happen a few days ago already, on Linus' tree.  I also told
you about it (on IRC), but you were too busy or something :-)

A simple ppc6xx_defconfig is enough to reproduce, fwiw.

Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
you can handle it I'm sure :-)


Segher


Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>


Author: Segher Boessenkool <segher@kernel.crashing.org>
Date:   Fri Mar 27 21:10:59 2009 +0100

     powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name)

  static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
Grant Likely - March 31, 2009, 8:54 p.m.
On Tue, Mar 31, 2009 at 2:41 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko]
>>>>> undefined!
>>>>>
>>>> I believe this is fixed in net-next (and possible linus has already
>>>> pulled that in.)
>>>
>>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next'
>>> branch nor in `merge' branch...
>>
>> Ah .. .weird :-)
>
> I had this happen a few days ago already, on Linus' tree.  I also told
> you about it (on IRC), but you were too busy or something :-)
>
> A simple ppc6xx_defconfig is enough to reproduce, fwiw.
>
> Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
> you can handle it I'm sure :-)
>
> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>

Heh, you beat me to it Segher.

Acked-by: Grant Likely <grant.likely@secretlab.ca>

g.

>
>
> Author: Segher Boessenkool <segher@kernel.crashing.org>
> Date:   Fri Mar 27 21:10:59 2009 +0100
>
>    powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name)
>
> diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
> index b3079a5..a108332 100644
> --- a/drivers/net/fsl_pq_mdio.c
> +++ b/drivers/net/fsl_pq_mdio.c
> @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct device_node
> *np
>        snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name,
>                (unsigned long long)taddr);
>  }
> +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);
>
>  /* Scan the bus in reverse, looking for an empty spot */
>  static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
Anton Vorontsov - March 31, 2009, 8:57 p.m.
On Tue, Mar 31, 2009 at 10:41:38PM +0200, Segher Boessenkool wrote:
>>>>> ERROR: "fsl_pq_mdio_bus_name" [drivers/net/gianfar_driver.ko]
>>>>> undefined!
>>>>>
>>>>> I'll ask Linus to pull anyway though.
>>>>>
>>>>> Cheers,
>>>>> Ben.
>>>>
>>>> I believe this is fixed in net-next (and possible linus has already
>>>> pulled that in.)
>>>
>>> FWIW, I can't reproduce the issue neither in benh/powerpc.git `next'
>>> branch nor in `merge' branch...
>>
>> Ah .. .weird :-)
>
> I had this happen a few days ago already, on Linus' tree.  I also told
> you about it (on IRC), but you were too busy or something :-)
>
> A simple ppc6xx_defconfig is enough to reproduce, fwiw.
>
> Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
> you can handle it I'm sure :-)

Ah, the modular build. Yeah, I didn't try it, but should have... :-(

Thanks!

> Segher
>
>
> Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
>
>
> Author: Segher Boessenkool <segher@kernel.crashing.org>
> Date:   Fri Mar 27 21:10:59 2009 +0100
>
>     powerpc: EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name)
>
> diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
> index b3079a5..a108332 100644
> --- a/drivers/net/fsl_pq_mdio.c
> +++ b/drivers/net/fsl_pq_mdio.c
> @@ -204,6 +204,7 @@ void fsl_pq_mdio_bus_name(char *name, struct  
> device_node *np
>         snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name,
>                 (unsigned long long)taddr);
>  }
> +EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);
>
>  /* Scan the bus in reverse, looking for an empty spot */
>  static int fsl_pq_mdio_find_free(struct mii_bus *new_bus)
>

Patch

diff --git a/drivers/net/fsl_pq_mdio.c b/drivers/net/fsl_pq_mdio.c
index b3079a5..a108332 100644
--- a/drivers/net/fsl_pq_mdio.c
+++ b/drivers/net/fsl_pq_mdio.c
@@ -204,6 +204,7 @@  void fsl_pq_mdio_bus_name(char *name, struct  
device_node *np
         snprintf(name, MII_BUS_ID_SIZE, "%s@%llx", np->name,
                 (unsigned long long)taddr);
  }
+EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name);

  /* Scan the bus in reverse, looking for an empty spot */