Patchwork [U-Boot,1/2] board/bsc9132qds: Add DSP side tlb and laws

login
register
mail settings
Submitter Priyanka Jain
Date June 25, 2013, 5:27 a.m.
Message ID <1372138070-10431-1-git-send-email-Priyanka.Jain@freescale.com>
Download mbox | patch
Permalink /patch/254025/
State Superseded
Delegated to: Andy Fleming
Headers show

Comments

Priyanka Jain - June 25, 2013, 5:27 a.m.
BSC9132QDS is a Freescale Reference Design Board for BSC9132 SoC which is a
integrated device that contains two powerpc e500v2 cores and two DSP
starcores.

To support DSP starcore
-Creating LAW and TLB for DSP-CCSR space.
-Creating LAW for DSP-core subsystem M2 and M3 memory
-Creating LAW for 1GB DDR which is connected exclusively to DSP-cores

Signed-off-by: Manish Jaggi
Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
 README                                    |    8 ++++++++
 arch/powerpc/include/asm/config_mpc85xx.h |    4 ++++
 arch/powerpc/include/asm/fsl_law.h        |    6 +++++-
 board/freescale/bsc9132qds/law.c          |    8 ++++++++
 board/freescale/bsc9132qds/tlb.c          |    5 +++++
 include/configs/BSC9132QDS.h              |    4 ++++
 6 files changed, 34 insertions(+), 1 deletions(-)
prabhakar.csengg@gmail.com - June 25, 2013, 11:45 a.m.
On Tue, Jun 25, 2013 at 10:57 AM, Priyanka Jain
<Priyanka.Jain@freescale.com> wrote:
> BSC9132QDS is a Freescale Reference Design Board for BSC9132 SoC which is a
> integrated device that contains two powerpc e500v2 cores and two DSP
> starcores.
>
> To support DSP starcore
> -Creating LAW and TLB for DSP-CCSR space.
> -Creating LAW for DSP-core subsystem M2 and M3 memory
> -Creating LAW for 1GB DDR which is connected exclusively to DSP-cores
>
> Signed-off-by: Manish Jaggi

missing mail id ? and similarly for 2/2

Regards,
--Prabhakar Lad
Jain Priyanka-B32167 - June 27, 2013, 3:59 a.m.
Email-id is no longer valid as person has left the company. 
Git send-email was throwing error as it could not send message to that mail.

Regards
Priyanka

> -----Original Message-----
> From: Prabhakar Lad [mailto:prabhakar.csengg@gmail.com]
> Sent: Tuesday, June 25, 2013 5:15 PM
> To: Jain Priyanka-B32167
> Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING
> Subject: Re: [U-Boot] [PATCH 1/2] board/bsc9132qds: Add DSP side tlb and
> laws
> 
> On Tue, Jun 25, 2013 at 10:57 AM, Priyanka Jain
> <Priyanka.Jain@freescale.com> wrote:
> > BSC9132QDS is a Freescale Reference Design Board for BSC9132 SoC which
> > is a integrated device that contains two powerpc e500v2 cores and two
> > DSP starcores.
> >
> > To support DSP starcore
> > -Creating LAW and TLB for DSP-CCSR space.
> > -Creating LAW for DSP-core subsystem M2 and M3 memory -Creating LAW
> > for 1GB DDR which is connected exclusively to DSP-cores
> >
> > Signed-off-by: Manish Jaggi
> 
> missing mail id ? and similarly for 2/2
> 
> Regards,
> --Prabhakar Lad
Albert ARIBAUD - June 27, 2013, 7:51 a.m.
Hi Jain,

On Thu, 27 Jun 2013 03:59:16 +0000, Jain Priyanka-B32167
<B32167@freescale.com> wrote:

> Email-id is no longer valid as person has left the company. 
> Git send-email was throwing error as it could not send message to that mail.

(please do not top-post)

Without an e-mail address, I suspect we cannot consider that person's
Signed-off-by to be valid, if only because it does not identify a
single individual any more.

> Regards
> Priyanka

Amicalement,
prabhakar.csengg@gmail.com - June 27, 2013, 8:06 a.m.
On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Hi Jain,
>
> On Thu, 27 Jun 2013 03:59:16 +0000, Jain Priyanka-B32167
> <B32167@freescale.com> wrote:
>
>> Email-id is no longer valid as person has left the company.
>> Git send-email was throwing error as it could not send message to that mail.
>
> (please do not top-post)
>
> Without an e-mail address, I suspect we cannot consider that person's
> Signed-off-by to be valid, if only because it does not identify a
> single individual any more.
>
Yes that's rite! alternatively you can just mention his name in the
commit message(with _NO_ signed-of).

Regards,
--Prabhakar Lad
Albert ARIBAUD - June 27, 2013, 10:05 a.m.
Hi Prabhakar,

On Thu, 27 Jun 2013 13:36:16 +0530, Prabhakar Lad
<prabhakar.csengg@gmail.com> wrote:

> On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
> > Hi Jain,
> >
> > On Thu, 27 Jun 2013 03:59:16 +0000, Jain Priyanka-B32167
> > <B32167@freescale.com> wrote:
> >
> >> Email-id is no longer valid as person has left the company.
> >> Git send-email was throwing error as it could not send message to that mail.
> >
> > (please do not top-post)
> >
> > Without an e-mail address, I suspect we cannot consider that person's
> > Signed-off-by to be valid, if only because it does not identify a
> > single individual any more.
> >
> Yes that's rite! alternatively you can just mention his name in the
> commit message(with _NO_ signed-of).

Note however that we *do* need a signed-off-by line.

> Regards,
> --Prabhakar Lad

Amicalement,
Scott Wood - June 27, 2013, 6:24 p.m.
On 06/26/2013 10:59:16 PM, Jain Priyanka-B32167 wrote:
> Email-id is no longer valid as person has left the company.
> Git send-email was throwing error as it could not send message to  
> that mail.

You can use --suppress-cc=sob to tell git send-email to not  
automatically CC people with sign-off lines.

Or, you could use an ordinary e-mail client to send it, as long as it  
doesn't mangle the patch (mutt works well for this).

-Scott
Scott Wood - June 27, 2013, 6:25 p.m.
On 06/27/2013 05:05:55 AM, Albert ARIBAUD wrote:
> Hi Prabhakar,
> 
> On Thu, 27 Jun 2013 13:36:16 +0530, Prabhakar Lad
> <prabhakar.csengg@gmail.com> wrote:
> 
> > On Thu, Jun 27, 2013 at 1:21 PM, Albert ARIBAUD
> > <albert.u.boot@aribaud.net> wrote:
> > > Hi Jain,
> > >
> > > On Thu, 27 Jun 2013 03:59:16 +0000, Jain Priyanka-B32167
> > > <B32167@freescale.com> wrote:
> > >
> > >> Email-id is no longer valid as person has left the company.
> > >> Git send-email was throwing error as it could not send message  
> to that mail.
> > >
> > > (please do not top-post)
> > >
> > > Without an e-mail address, I suspect we cannot consider that  
> person's
> > > Signed-off-by to be valid, if only because it does not identify a
> > > single individual any more.
> > >
> > Yes that's rite! alternatively you can just mention his name in the
> > commit message(with _NO_ signed-of).
> 
> Note however that we *do* need a signed-off-by line.

We would still have Priyanka's signed-off-by.

-Scott

Patch

diff --git a/README b/README
index e8359f8..99a2c02 100644
--- a/README
+++ b/README
@@ -422,10 +422,18 @@  The following options need to be configured:
 		This is the value to write into CCSR offset 0x18600
 		according to the A004510 workaround.
 
+		CONFIG_SYS_FSL_DSP_DDR_ADDR
+		This value denotes start offset of DDR memory which is
+		connected exclusively to the DSP cores.
+
 		CONFIG_SYS_FSL_DSP_M2_RAM_ADDR
 		This value denotes start offset of M2 memory
 		which is directly connected to the DSP core.
 
+		CONFIG_SYS_FSL_DSP_M3_RAM_ADDR
+		This value denotes start offset of M3 memory which is directly
+		connected to the DSP core.
+
 		CONFIG_SYS_FSL_DSP_CCSRBAR_DEFAULT
 		This value denotes start offset of DSP CCSR space.
 
diff --git a/arch/powerpc/include/asm/config_mpc85xx.h b/arch/powerpc/include/asm/config_mpc85xx.h
index 1d46b14..16ef7df 100644
--- a/arch/powerpc/include/asm/config_mpc85xx.h
+++ b/arch/powerpc/include/asm/config_mpc85xx.h
@@ -506,6 +506,10 @@ 
 #define CONFIG_TSECV2
 #define CONFIG_SYS_FSL_SEC_COMPAT	4
 #define CONFIG_NUM_DDR_CONTROLLERS	2
+#define CONFIG_SYS_FSL_DSP_DDR_ADDR	0x40000000
+#define CONFIG_SYS_FSL_DSP_M2_RAM_ADDR	0xb0000000
+#define CONFIG_SYS_FSL_DSP_M3_RAM_ADDR	0xc0000000
+#define CONFIG_SYS_FSL_DSP_CCSRBAR_DEFAULT	0xff600000
 #define CONFIG_SYS_FSL_IFC_BANK_COUNT	3
 #define CONFIG_SYS_CCSRBAR_DEFAULT	0xff700000
 #define CONFIG_NAND_FSL_IFC
diff --git a/arch/powerpc/include/asm/fsl_law.h b/arch/powerpc/include/asm/fsl_law.h
index bea1636..fa51e59 100644
--- a/arch/powerpc/include/asm/fsl_law.h
+++ b/arch/powerpc/include/asm/fsl_law.h
@@ -82,7 +82,7 @@  enum law_trgt_if {
 #ifndef CONFIG_MPC8641
 	LAW_TRGT_IF_PCIE_1 = 0x02,
 #endif
-#if defined(CONFIG_BSC9131)
+#if defined(CONFIG_BSC9131) || defined(CONFIG_BSC9132)
 	LAW_TRGT_IF_OCN_DSP = 0x03,
 #else
 #if !defined(CONFIG_MPC8572) && !defined(CONFIG_P2020)
@@ -94,7 +94,11 @@  enum law_trgt_if {
 	LAW_TRGT_IF_DSP_CCSR = 0x09,
 	LAW_TRGT_IF_DDR_INTRLV = 0x0b,
 	LAW_TRGT_IF_RIO = 0x0c,
+#if defined(CONFIG_BSC9132)
+	LAW_TRGT_IF_CLASS_DSP = 0x0d,
+#else
 	LAW_TRGT_IF_RIO_2 = 0x0d,
+#endif
 	LAW_TRGT_IF_DPAA_SWP_SRAM = 0x0e,
 	LAW_TRGT_IF_DDR = 0x0f,
 	LAW_TRGT_IF_DDR_2 = 0x16,	/* 2nd controller */
diff --git a/board/freescale/bsc9132qds/law.c b/board/freescale/bsc9132qds/law.c
index b4bce99..99ea56b 100644
--- a/board/freescale/bsc9132qds/law.c
+++ b/board/freescale/bsc9132qds/law.c
@@ -32,6 +32,14 @@  struct law_entry law_table[] = {
 #ifdef CONFIG_SYS_FPGA_BASE_PHYS
 	SET_LAW(CONFIG_SYS_FPGA_BASE_PHYS, LAW_SIZE_128K, LAW_TRGT_IF_IFC),
 #endif
+	SET_LAW(CONFIG_SYS_FSL_DSP_CCSRBAR_PHYS, LAW_SIZE_1M,
+		LAW_TRGT_IF_DSP_CCSR),
+	SET_LAW(CONFIG_SYS_FSL_DSP_M2_RAM_ADDR, LAW_SIZE_32M,
+		LAW_TRGT_IF_OCN_DSP),
+	SET_LAW(CONFIG_SYS_FSL_DSP_M3_RAM_ADDR, LAW_SIZE_32K,
+		LAW_TRGT_IF_CLASS_DSP),
+	SET_LAW(CONFIG_SYS_FSL_DSP_DDR_ADDR, LAW_SIZE_1G,
+		LAW_TRGT_IF_CLASS_DSP)
 };
 
 int num_law_entries = ARRAY_SIZE(law_table);
diff --git a/board/freescale/bsc9132qds/tlb.c b/board/freescale/bsc9132qds/tlb.c
index 0ec9a85..734f3f8 100644
--- a/board/freescale/bsc9132qds/tlb.c
+++ b/board/freescale/bsc9132qds/tlb.c
@@ -57,6 +57,11 @@  struct fsl_e_tlb_entry tlb_table[] = {
 			MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
 			0, 1, BOOKE_PAGESZ_1M, 1),
 
+	/* CCSRBAR (DSP) */
+	SET_TLB_ENTRY(1, CONFIG_SYS_FSL_DSP_CCSRBAR,
+		      CONFIG_SYS_FSL_DSP_CCSRBAR_PHYS, MAS3_SW|MAS3_SR,
+		      MAS2_I|MAS2_G, 0, 2, BOOKE_PAGESZ_1M, 1),
+
 #ifndef CONFIG_SPL_BUILD
 	SET_TLB_ENTRY(1, CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_PHYS,
 			MAS3_SX|MAS3_SR, MAS2_W|MAS2_G,
diff --git a/include/configs/BSC9132QDS.h b/include/configs/BSC9132QDS.h
index 3aa4443..91105eb 100644
--- a/include/configs/BSC9132QDS.h
+++ b/include/configs/BSC9132QDS.h
@@ -240,6 +240,10 @@  combinations. this should be removed later
 
 #define CONFIG_SYS_IMMR		CONFIG_SYS_CCSRBAR
 
+/* DSP CCSRBAR */
+#define CONFIG_SYS_FSL_DSP_CCSRBAR	CONFIG_SYS_FSL_DSP_CCSRBAR_DEFAULT
+#define CONFIG_SYS_FSL_DSP_CCSRBAR_PHYS	CONFIG_SYS_FSL_DSP_CCSRBAR_DEFAULT
+
 /*
  * IFC Definitions
  */