From patchwork Tue Jun 25 05:03:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sharad Singhai X-Patchwork-Id: 254018 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7921A2C0087 for ; Tue, 25 Jun 2013 15:04:25 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; q=dns; s=default; b=vsyKMYaHgeMhDXm I6U12LhvVEJICDmFTvTC/cgMR44YakEfehkey6KqcGmDWrlQ79zfpa6CXZc3hdug g3jRvRh7ai3cH/Tr54sKo8PmbxwaXCJms2yq2IrvFsJIxx0B7hunDDS31pDH3cx/ YrYldMDbBXrMKM55Dv3oeIDwnxVU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; s=default; bh=Wd5+ou8XDaBwHAxGffddX TTkOS4=; b=gYMp71sWpLVyJsN49K5Zt7aGISq3XVVs7Iz1lirFIs27Surmypxn5 MuvvmJ1ljZQu6odQMsDR9OHTF3v4vlZ12UQM79Af/lu/FBHgXpejiKixCikRmXWy VTTQB4StY5eQlbBYMeMpAwcRmFzeIXJC4HyL6MD6wLNgUjW+USJxkM= Received: (qmail 29163 invoked by alias); 25 Jun 2013 05:04:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 29108 invoked by uid 89); 25 Jun 2013 05:04:10 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.1 Received: from mail-oa0-f53.google.com (HELO mail-oa0-f53.google.com) (209.85.219.53) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 05:04:09 +0000 Received: by mail-oa0-f53.google.com with SMTP id k14so12601144oag.40 for ; Mon, 24 Jun 2013 22:04:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=XaVs8NKzlyLBX5HP4yugp7eCzvUp5RdSEiDq2JYWC4Q=; b=Rf3Y4lI4kOFYi3TASw4wNIUMS7dz2kYqi/3GUd/+nIXKAVxNxnTruxsuTsE/TVKIz+ xsJIiUYEs7HQXSuLZhUj/kXbhyZ9wiINtrvmOJvozYSGW0+8W1MZfjHgUP9tsDCChPYO f6UAuUvOo+GkC5UMy5ERanuqnKA70Dysc0t+TuIuPpIIdrO5WxGQcPEO9XM1ifKCPkF6 +mCxSajIVQperH8d786s+f7SDtKWOzy2RkEWRsoRX+ZivU0Ig/7OAukKj06qHv8wKW5C OJBheV6xd0J5oOSx/pAn3JXBGcXq/T4U7Y2LSvhcgNWQz2Yf45oTsBlO5HdbEtQn5S6i 7raQ== X-Received: by 10.60.96.197 with SMTP id du5mr12005636oeb.127.1372136647813; Mon, 24 Jun 2013 22:04:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.160.67 with HTTP; Mon, 24 Jun 2013 22:03:27 -0700 (PDT) In-Reply-To: References: From: Sharad Singhai Date: Mon, 24 Jun 2013 22:03:27 -0700 Message-ID: Subject: Re: [google/gcc-4_8] Port -Wreal-conversion warning To: Xinliang David Li Cc: "gcc-patches@gcc.gnu.org" X-Gm-Message-State: ALoCoQlrguRcYCOZ/n9pf5UCzwO5xb2nnResn+7UyiEkapw7FLK4KzOjCDJUqnNaK+n6lPT0X5zWtQSa45G2ZTwwDV6MY+Gg6TbvbFiLjpSRRxTPZLg7wpygAuaqapx0myBOtq0QDvQVxFCAjth2rOpYez5/ayxAjpGg/xnarlgZN3M3GSKXE0mOVLSn+SZCimMg5iU3pf15ShmGJVrbx943Nvd1WWiXIQ== On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li wrote: > To avoid printing twice, can you just do > > opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion); > warning_at (loc, opt_type, ...); Thanks for the suggestion. I have updated the enclosed patch and retested. Okay for google/gcc-4_8? Thanks, Sharad 2013-06-24 * doc/invoke.texi: Document new option -Wreal-conversion. * c-family/c.opt: Handle new option. * c-family/c-opts.c (c_common_post_options): Ditto. * c-family/c-common.c (conversion_warning): Ditto. testsuite/ChangeLog: * testsuite/gcc.dg/Wreal-conversion-1.c: New test. * testsuite/g++.dg/warn/Wreal-conversion-1.C: Ditto. Index: doc/invoke.texi =================================================================== --- doc/invoke.texi (revision 200359) +++ doc/invoke.texi (working copy) @@ -237,7 +237,7 @@ Objective-C and Objective-C++ Dialects}. -Wno-attributes -Wno-builtin-macro-redefined @gol -Wc++-compat -Wc++11-compat -Wcast-align -Wcast-qual @gol -Wchar-subscripts -Wclobbered -Wcomment @gol --Wconversion -Wcoverage-mismatch -Wno-cpp -Wno-deprecated @gol +-Wconversion -Wreal-conversion -Wcoverage-mismatch -Wno-cpp -Wno-deprecated @gol -Wno-deprecated-declarations -Wdisabled-optimization @gol -Wno-div-by-zero -Wdouble-promotion -Wempty-body -Wenum-compare @gol -Wno-endif-labels -Werror -Werror=* @gol @@ -4452,6 +4452,12 @@ reference to them. Warnings about conversions betw unsigned integers are disabled by default in C++ unless @option{-Wsign-conversion} is explicitly enabled. +@item -Wreal-conversion +@opindex Wreal-conversion +@opindex Wno-real-conversion +Warn for implicit type conversions from real (@code{double} or @code{float}) +to integral values. + @item -Wno-conversion-null @r{(C++ and Objective-C++ only)} @opindex Wconversion-null @opindex Wno-conversion-null Index: testsuite/gcc.dg/Wreal-conversion-1.c =================================================================== --- testsuite/gcc.dg/Wreal-conversion-1.c (revision 0) +++ testsuite/gcc.dg/Wreal-conversion-1.c (revision 0) @@ -0,0 +1,23 @@ +// { dg-do compile } +// { dg-options "-Wreal-conversion" } + +#include + +int func1(int a) { + double f = a; + return f; // { dg-warning "conversion to" } +} + +double func3(); + +void func2() { + double g = 3.2; + float f; + int t = g; // { dg-warning "conversion to" } + int p; + p = f; // { dg-warning "conversion to" } + func1(g); // { dg-warning "conversion to" } + char c = f; // { dg-warning "conversion to" } + int q; + q = func3(); // { dg-warning "conversion to" } +} Index: testsuite/g++.dg/warn/Wreal-conversion-1.C =================================================================== --- testsuite/g++.dg/warn/Wreal-conversion-1.C (revision 0) +++ testsuite/g++.dg/warn/Wreal-conversion-1.C (revision 0) @@ -0,0 +1,24 @@ +// { dg-do compile } +// { dg-options "-Wreal-conversion" } + +#include + +int func1(int a) { + double f = a; + return f; // { dg-warning "conversion to" } +} + +double func3(); + +void func2() { + double g = 3.2; + float f; + int t = g; // { dg-warning "conversion to" } + bool b = g; + int p; + p = f; // { dg-warning "conversion to" } + func1(g); // { dg-warning "conversion to" } + char c = f; // { dg-warning "conversion to" } + int q; + q = func3(); // { dg-warning "conversion to" } +} Index: c-family/c.opt =================================================================== --- c-family/c.opt (revision 200359) +++ c-family/c.opt (working copy) @@ -677,6 +677,10 @@ Wsign-compare C ObjC C++ ObjC++ EnabledBy(Wextra) ; +Wreal-conversion +C ObjC C++ ObjC++ Var(warn_real_conversion) Init(-1) Warning +Warn for implicit type conversions from real to integral values + Wsign-conversion C ObjC C++ ObjC++ Var(warn_sign_conversion) LangEnabledBy(C ObjC,Wconversion) Warn for implicit type conversions between signed and unsigned integers Index: c-family/c-opts.c =================================================================== --- c-family/c-opts.c (revision 200359) +++ c-family/c-opts.c (working copy) @@ -876,6 +876,12 @@ c_common_post_options (const char **pfilename) if (warn_packed_bitfield_compat == -1) warn_packed_bitfield_compat = 1; + /* Enable warning for converting real values to integral values + when -Wconversion is specified (unless disabled through + -Wno-real-conversion). */ + if (warn_real_conversion == -1) + warn_real_conversion = warn_conversion; + /* Special format checking options don't work without -Wformat; warn if they are used. */ if (!warn_format) Index: c-family/c-common.c =================================================================== --- c-family/c-common.c (revision 200359) +++ c-family/c-common.c (working copy) @@ -2668,7 +2668,7 @@ conversion_warning (tree type, tree expr) tree expr_type = TREE_TYPE (expr); location_t loc = EXPR_LOC_OR_HERE (expr); - if (!warn_conversion && !warn_sign_conversion) + if (!warn_conversion && !warn_sign_conversion && !warn_real_conversion) return; switch (TREE_CODE (expr)) @@ -2715,9 +2715,12 @@ conversion_warning (tree type, tree expr) default: /* 'expr' is not a constant. */ if (unsafe_conversion_p (type, expr, true)) - warning_at (loc, OPT_Wconversion, - "conversion to %qT from %qT may alter its value", - type, expr_type); + { + int warn_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion); + warning_at (loc, warn_type, + "conversion to %qT from %qT may alter its value", + type, expr_type); + } } }