hso: add Vendor/Product ID's for new devices
diff mbox

Message ID 20090331115652.GA22106@raptor
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Jan Dumon March 31, 2009, 11:56 a.m. UTC
From: Jan Dumon <j.dumon@option.com>

Add Vendor/Product ID's for new devices.

Signed-off-by: Jan Dumon <j.dumon@option.com>
---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paulius Zaleckas April 1, 2009, 7:33 a.m. UTC | #1
Jan Dumon wrote:
> From: Jan Dumon <j.dumon@option.com>
> 
> Add Vendor/Product ID's for new devices.
> 
> Signed-off-by: Jan Dumon <j.dumon@option.com>
> ---
> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
> index fe98aca..d47c508 100644
> --- a/drivers/net/usb/hso.c
> +++ b/drivers/net/usb/hso.c
> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
>  	{USB_DEVICE(0x0af0, 0x7701)},
>  	{USB_DEVICE(0x0af0, 0x7801)},
>  	{USB_DEVICE(0x0af0, 0x7901)},
> -	{USB_DEVICE(0x0af0, 0x7361)},
> -	{USB_DEVICE(0x0af0, 0xd057)},

Please add comment in description why you are removing these IDs.

> +	{USB_DEVICE(0x0af0, 0x8200)},
> +	{USB_DEVICE(0x0af0, 0x8201)},
> +	{USB_DEVICE(0x0af0, 0xd035)},
>  	{USB_DEVICE(0x0af0, 0xd055)},
> +	{USB_DEVICE(0x0af0, 0xd155)},
> +	{USB_DEVICE(0x0af0, 0xd255)},
> +	{USB_DEVICE(0x0af0, 0xd057)},
> +	{USB_DEVICE(0x0af0, 0xd157)},
> +	{USB_DEVICE(0x0af0, 0xd257)},
> +	{USB_DEVICE(0x0af0, 0xd357)},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(usb, hso_ids);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Dumon April 1, 2009, 7:44 a.m. UTC | #2
Paulius Zaleckas wrote:
> Jan Dumon wrote:
>> From: Jan Dumon <j.dumon@option.com>
>>
>> Add Vendor/Product ID's for new devices.
>>
>> Signed-off-by: Jan Dumon <j.dumon@option.com>
>> ---
>> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
>> index fe98aca..d47c508 100644
>> --- a/drivers/net/usb/hso.c
>> +++ b/drivers/net/usb/hso.c
>> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
>>  	{USB_DEVICE(0x0af0, 0x7701)},
>>  	{USB_DEVICE(0x0af0, 0x7801)},
>>  	{USB_DEVICE(0x0af0, 0x7901)},
>> -	{USB_DEVICE(0x0af0, 0x7361)},
>> -	{USB_DEVICE(0x0af0, 0xd057)},
> 
> Please add comment in description why you are removing these IDs.

No ID's are removed.
0xd057 is added again by the same patch, 0x7361 was twice in the list.

>> +	{USB_DEVICE(0x0af0, 0x8200)},
>> +	{USB_DEVICE(0x0af0, 0x8201)},
>> +	{USB_DEVICE(0x0af0, 0xd035)},
>>  	{USB_DEVICE(0x0af0, 0xd055)},
>> +	{USB_DEVICE(0x0af0, 0xd155)},
>> +	{USB_DEVICE(0x0af0, 0xd255)},
>> +	{USB_DEVICE(0x0af0, 0xd057)},
>> +	{USB_DEVICE(0x0af0, 0xd157)},
>> +	{USB_DEVICE(0x0af0, 0xd257)},
>> +	{USB_DEVICE(0x0af0, 0xd357)},
>>  	{}
>>  };
>>  MODULE_DEVICE_TABLE(usb, hso_ids);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller April 1, 2009, 8:07 a.m. UTC | #3
From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Date: Wed, 01 Apr 2009 10:33:59 +0300

> Jan Dumon wrote:
> > @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
> >  	{USB_DEVICE(0x0af0, 0x7701)},
> >  	{USB_DEVICE(0x0af0, 0x7801)},
> >  	{USB_DEVICE(0x0af0, 0x7901)},
> > -	{USB_DEVICE(0x0af0, 0x7361)},
> > -	{USB_DEVICE(0x0af0, 0xd057)},
> 
> Please add comment in description why you are removing these IDs.

This isn't the first time they've been asked to do this.

--------------------

Subject: Re: [PATCH] hso: add new device id's
From: David Miller <davem@davemloft.net>
To: F.Aben@option.com
Cc: gregkh@suse.de, netdev@vger.kernel.org, linux-usb@vger.kernel.org
Date: Mon, 02 Feb 2009 16:33:00 -0800 (PST)
X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)

From: "Filip Aben" <F.Aben@option.com>
Date: Tue, 3 Feb 2009 01:26:14 +0100

> > -----Original Message-----
> > From: David Miller [mailto:davem@davemloft.net]
> > Sent: maandag 2 februari 2009 23:03
> > To: Filip Aben
> > Cc: gregkh@suse.de; netdev@vger.kernel.org; linux-usb@vger.kernel.org
> > Subject: Re: [PATCH] hso: add new device id's
> > 
> > Why won't 0xaf0/0xd051 ever be used?
> > 
> > You should explain such things in your commit message,
> > that way I don't have to ask.
> 
> That ID was used in an internal engineering version of a device and 
> will never see commercial light.
> Even if this ID will be 'recycled' in the future, which is very
> unlikely, 
> I don't know what kind of device will be behind it. Therefore it's safer
> to remove it.

Great, please add that information to the commit message
and resend your patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paulius Zaleckas April 1, 2009, 8:43 a.m. UTC | #4
Jan Dumon wrote:
> Paulius Zaleckas wrote:
>> Jan Dumon wrote:
>>> From: Jan Dumon <j.dumon@option.com>
>>>
>>> Add Vendor/Product ID's for new devices.
>>>
>>> Signed-off-by: Jan Dumon <j.dumon@option.com>
>>> ---
>>> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
>>> index fe98aca..d47c508 100644
>>> --- a/drivers/net/usb/hso.c
>>> +++ b/drivers/net/usb/hso.c
>>> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
>>>  	{USB_DEVICE(0x0af0, 0x7701)},
>>>  	{USB_DEVICE(0x0af0, 0x7801)},
>>>  	{USB_DEVICE(0x0af0, 0x7901)},
>>> -	{USB_DEVICE(0x0af0, 0x7361)},
>>> -	{USB_DEVICE(0x0af0, 0xd057)},
>> Please add comment in description why you are removing these IDs.
> 
> No ID's are removed.
> 0xd057 is added again by the same patch, 0x7361 was twice in the list.

OK for 0xd057, but please add comment that you are removing duplicate
definition of 0x7361.

> 
>>> +	{USB_DEVICE(0x0af0, 0x8200)},
>>> +	{USB_DEVICE(0x0af0, 0x8201)},
>>> +	{USB_DEVICE(0x0af0, 0xd035)},
>>>  	{USB_DEVICE(0x0af0, 0xd055)},
>>> +	{USB_DEVICE(0x0af0, 0xd155)},
>>> +	{USB_DEVICE(0x0af0, 0xd255)},
>>> +	{USB_DEVICE(0x0af0, 0xd057)},
>>> +	{USB_DEVICE(0x0af0, 0xd157)},
>>> +	{USB_DEVICE(0x0af0, 0xd257)},
>>> +	{USB_DEVICE(0x0af0, 0xd357)},
>>>  	{}
>>>  };
>>>  MODULE_DEVICE_TABLE(usb, hso_ids);
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index fe98aca..d47c508 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -462,9 +462,16 @@  static const struct usb_device_id hso_ids[] = {
 	{USB_DEVICE(0x0af0, 0x7701)},
 	{USB_DEVICE(0x0af0, 0x7801)},
 	{USB_DEVICE(0x0af0, 0x7901)},
-	{USB_DEVICE(0x0af0, 0x7361)},
-	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0x8200)},
+	{USB_DEVICE(0x0af0, 0x8201)},
+	{USB_DEVICE(0x0af0, 0xd035)},
 	{USB_DEVICE(0x0af0, 0xd055)},
+	{USB_DEVICE(0x0af0, 0xd155)},
+	{USB_DEVICE(0x0af0, 0xd255)},
+	{USB_DEVICE(0x0af0, 0xd057)},
+	{USB_DEVICE(0x0af0, 0xd157)},
+	{USB_DEVICE(0x0af0, 0xd257)},
+	{USB_DEVICE(0x0af0, 0xd357)},
 	{}
 };
 MODULE_DEVICE_TABLE(usb, hso_ids);